[INFO] updating cached repository tatref/markov [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tatref/markov [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tatref/markov" "work/ex/clippy-test-run/sources/stable/gh/tatref/markov"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tatref/markov'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tatref/markov" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tatref/markov"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tatref/markov'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4edc948d5457d9d00331459475f8154e8331e6fd [INFO] sha for GitHub repo tatref/markov: 4edc948d5457d9d00331459475f8154e8331e6fd [INFO] validating manifest of tatref/markov on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tatref/markov on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tatref/markov [INFO] finished frobbing tatref/markov [INFO] frobbed toml for tatref/markov written to work/ex/clippy-test-run/sources/stable/gh/tatref/markov/Cargo.toml [INFO] started frobbing tatref/markov [INFO] finished frobbing tatref/markov [INFO] frobbed toml for tatref/markov written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tatref/markov/Cargo.toml [INFO] crate tatref/markov has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting tatref/markov against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tatref/markov:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3fd220ab8a177e8a8058e99d0cdc569f1d44ed99f47891885bba1c1b29fd636d [INFO] running `"docker" "start" "-a" "3fd220ab8a177e8a8058e99d0cdc569f1d44ed99f47891885bba1c1b29fd636d"` [INFO] [stderr] Checking markov v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | let last = match last { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 71 | | &Token::Start => unreachable!(), [INFO] [stderr] 72 | | &Token::End => Token::End, [INFO] [stderr] 73 | | &Token::Word(ref w) => Token::Word(w.clone()), [INFO] [stderr] 74 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | let last = match *last { [INFO] [stderr] 71 | Token::Start => unreachable!(), [INFO] [stderr] 72 | Token::End => Token::End, [INFO] [stderr] 73 | Token::Word(ref w) => Token::Word(w.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:76:71 [INFO] [stderr] | [INFO] [stderr] 76 | let predictions = self.h.entry(prefix.into()).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | / match prediction { [INFO] [stderr] 128 | | &Token::Word(ref w) => w.clone(), [INFO] [stderr] 129 | | &Token::End => String::from("."), [INFO] [stderr] 130 | | &Token::Start => String::new(), [INFO] [stderr] 131 | | }) [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | match *prediction { [INFO] [stderr] 128 | Token::Word(ref w) => w.clone(), [INFO] [stderr] 129 | Token::End => String::from("."), [INFO] [stderr] 130 | Token::Start => String::new(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | let last = match last { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 71 | | &Token::Start => unreachable!(), [INFO] [stderr] 72 | | &Token::End => Token::End, [INFO] [stderr] 73 | | &Token::Word(ref w) => Token::Word(w.clone()), [INFO] [stderr] 74 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | let last = match *last { [INFO] [stderr] 71 | Token::Start => unreachable!(), [INFO] [stderr] 72 | Token::End => Token::End, [INFO] [stderr] 73 | Token::Word(ref w) => Token::Word(w.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:76:71 [INFO] [stderr] | [INFO] [stderr] 76 | let predictions = self.h.entry(prefix.into()).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | / match prediction { [INFO] [stderr] 128 | | &Token::Word(ref w) => w.clone(), [INFO] [stderr] 129 | | &Token::End => String::from("."), [INFO] [stderr] 130 | | &Token::Start => String::new(), [INFO] [stderr] 131 | | }) [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 127 | match *prediction { [INFO] [stderr] 128 | Token::Word(ref w) => w.clone(), [INFO] [stderr] 129 | Token::End => String::from("."), [INFO] [stderr] 130 | Token::Start => String::new(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.98s [INFO] running `"docker" "inspect" "3fd220ab8a177e8a8058e99d0cdc569f1d44ed99f47891885bba1c1b29fd636d"` [INFO] running `"docker" "rm" "-f" "3fd220ab8a177e8a8058e99d0cdc569f1d44ed99f47891885bba1c1b29fd636d"` [INFO] [stdout] 3fd220ab8a177e8a8058e99d0cdc569f1d44ed99f47891885bba1c1b29fd636d