[INFO] updating cached repository tarka/xcp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tarka/xcp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tarka/xcp" "work/ex/clippy-test-run/sources/stable/gh/tarka/xcp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tarka/xcp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tarka/xcp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tarka/xcp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tarka/xcp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7cfb8cba9503f6ccea8f4d8e4a57ecb70f2ba4e1 [INFO] sha for GitHub repo tarka/xcp: 7cfb8cba9503f6ccea8f4d8e4a57ecb70f2ba4e1 [INFO] validating manifest of tarka/xcp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tarka/xcp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tarka/xcp [INFO] finished frobbing tarka/xcp [INFO] frobbed toml for tarka/xcp written to work/ex/clippy-test-run/sources/stable/gh/tarka/xcp/Cargo.toml [INFO] started frobbing tarka/xcp [INFO] finished frobbing tarka/xcp [INFO] frobbed toml for tarka/xcp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tarka/xcp/Cargo.toml [INFO] crate tarka/xcp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tarka/xcp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tarka/xcp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 220ee2c53783fd66fcf17379ab368cd503c12f0a756c970976556183f6fc1077 [INFO] running `"docker" "start" "-a" "220ee2c53783fd66fcf17379ab368cd503c12f0a756c970976556183f6fc1077"` [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Compiling escargot v0.3.1 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking tempfile v3.0.4 [INFO] [stderr] Compiling syn v0.15.13 [INFO] [stderr] Checking crossbeam-epoch v0.6.0 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling synstructure v0.10.0 [INFO] [stderr] Compiling structopt-derive v0.2.12 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking structopt v0.2.12 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking xcp v0.1.1-alpha.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | batch_size: batch_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `batch_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | batch_size: batch_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `batch_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/os.rs:221:30 [INFO] [stderr] | [INFO] [stderr] 221 | write!(fd, "{}", "test")?; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/os.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | result_or_errno(r as i64, stat) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/os.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | result_or_errno(r as i64, ()) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/progress.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | Ok(self.send(update)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 80 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | fn to_enum(ft: &fs::FileType) -> FileType { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `fs::FileType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:62:31 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn expand_globs(patterns: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Checking serde_json v1.0.32 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | batch_size: batch_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `batch_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | batch_size: batch_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `batch_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/os.rs:221:30 [INFO] [stderr] | [INFO] [stderr] 221 | write!(fd, "{}", "test")?; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> tests/lib.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | write!(&file, "{}", text); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> tests/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | write!(fd, "{}", data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> tests/lib.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | write!(fd, "{}", data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> tests/lib.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | write!(fd, "{}", data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/os.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | result_or_errno(r as i64, stat) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/os.rs:127:21 [INFO] [stderr] | [INFO] [stderr] 127 | result_or_errno(r as i64, ()) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/progress.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | Ok(self.send(update)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 80 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utils.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | fn to_enum(ft: &fs::FileType) -> FileType { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `fs::FileType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:62:31 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn expand_globs(patterns: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `"docker" "inspect" "220ee2c53783fd66fcf17379ab368cd503c12f0a756c970976556183f6fc1077"` [INFO] running `"docker" "rm" "-f" "220ee2c53783fd66fcf17379ab368cd503c12f0a756c970976556183f6fc1077"` [INFO] [stdout] 220ee2c53783fd66fcf17379ab368cd503c12f0a756c970976556183f6fc1077