[INFO] updating cached repository tari/warcdedupe
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tari/warcdedupe
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tari/warcdedupe" "work/ex/clippy-test-run/sources/stable/gh/tari/warcdedupe"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tari/warcdedupe'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tari/warcdedupe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tari/warcdedupe"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tari/warcdedupe'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 91f0c60ad87d86016816be7a20b993bc1e24a8ab
[INFO] sha for GitHub repo tari/warcdedupe: 91f0c60ad87d86016816be7a20b993bc1e24a8ab
[INFO] validating manifest of tari/warcdedupe on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tari/warcdedupe on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tari/warcdedupe
[INFO] finished frobbing tari/warcdedupe
[INFO] frobbed toml for tari/warcdedupe written to work/ex/clippy-test-run/sources/stable/gh/tari/warcdedupe/Cargo.toml
[INFO] started frobbing tari/warcdedupe
[INFO] finished frobbing tari/warcdedupe
[INFO] frobbed toml for tari/warcdedupe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tari/warcdedupe/Cargo.toml
[INFO] crate tari/warcdedupe has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tari/warcdedupe against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tari/warcdedupe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7cda4b6bd21bea1633a348efd4b7f58d9ee2b0826753e84087e22d951fe11b9c
[INFO] running `"docker" "start" "-a" "7cda4b6bd21bea1633a348efd4b7f58d9ee2b0826753e84087e22d951fe11b9c"`
[INFO] [stderr]    Compiling pest v1.0.6
[INFO] [stderr]     Checking serde v1.0.38
[INFO] [stderr]     Checking cast v0.2.2
[INFO] [stderr]    Compiling crc v1.7.0
[INFO] [stderr]     Checking regex-syntax v0.5.5
[INFO] [stderr]     Checking num-integer v0.1.36
[INFO] [stderr]     Checking num-traits v0.1.43
[INFO] [stderr]     Checking term v0.5.1
[INFO] [stderr]    Compiling backtrace-sys v0.1.16
[INFO] [stderr]     Checking twoway v0.1.8
[INFO] [stderr]     Checking itertools-num v0.1.1
[INFO] [stderr]     Checking chrono v0.4.2
[INFO] [stderr]     Checking criterion-stats v0.2.3
[INFO] [stderr]     Checking criterion-plot v0.2.3
[INFO] [stderr]    Compiling pest_derive v1.0.7
[INFO] [stderr]    Compiling serde_derive_internals v0.23.1
[INFO] [stderr]     Checking sha-1 v0.7.0
[INFO] [stderr]     Checking libflate v0.1.14
[INFO] [stderr]     Checking simplelog v0.5.1
[INFO] [stderr]    Compiling serde_derive v1.0.38
[INFO] [stderr]     Checking regex v0.2.10
[INFO] [stderr]     Checking backtrace v0.3.6
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]     Checking serde_json v1.0.14
[INFO] [stderr]     Checking docopt v0.8.3
[INFO] [stderr]     Checking warcdedupe v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:258:16
[INFO] [stderr]     |
[INFO] [stderr] 258 |                header: header,
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:259:16
[INFO] [stderr]     |
[INFO] [stderr] 259 |                reader: reader,
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:138:16
[INFO] [stderr]     |
[INFO] [stderr] 138 |                version: version,
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:139:16
[INFO] [stderr]     |
[INFO] [stderr] 139 |                fields: fields,
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: replace it with: `fields`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:313:13
[INFO] [stderr]     |
[INFO] [stderr] 313 |             value: value,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]     Checking handlebars v0.31.0
[INFO] [stderr] warning: unused import: `Result as IoResult`
[INFO] [stderr]  --> src/reader.rs:5:33
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::io::{Error as IoError, Result as IoResult};
[INFO] [stderr]   |                                 ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`.
[INFO] [stderr]    --> src/reader.rs:279:13
[INFO] [stderr]     |
[INFO] [stderr] 279 |         let Record { header: _, bytes_remaining: _, reader: _, marker: _, debug_info: _ } = self;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Record { .. }` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::is_ascii': use inherent methods instead
[INFO] [stderr]    --> src/lib.rs:338:43
[INFO] [stderr]     |
[INFO] [stderr] 338 |             debug_assert!(m[1].iter().all(std::ascii::AsciiExt::is_ascii));
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/reader.rs:46:9
[INFO] [stderr]    |
[INFO] [stderr] 46 | /         match self {
[INFO] [stderr] 47 | |             &InvalidHeader(_) => "invalid or malformed WARC record",
[INFO] [stderr] 48 | |             &UnknownLength(_) => "missing or malformed record Content-Length",
[INFO] [stderr] 49 | |             &EndOfStream => "unexpected end of input",
[INFO] [stderr] 50 | |             &IoError(ref e) => e.description(),
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 46 |         match *self {
[INFO] [stderr] 47 |             InvalidHeader(_) => "invalid or malformed WARC record",
[INFO] [stderr] 48 |             UnknownLength(_) => "missing or malformed record Content-Length",
[INFO] [stderr] 49 |             EndOfStream => "unexpected end of input",
[INFO] [stderr] 50 |             IoError(ref e) => e.description(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/reader.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 | /         match self {
[INFO] [stderr] 56 | |             &InvalidRecord::IoError(ref e) => Some(e),
[INFO] [stderr] 57 | |             &InvalidRecord::InvalidHeader(ref e) => Some(e),
[INFO] [stderr] 58 | |             _ => None,
[INFO] [stderr] 59 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 55 |         match *self {
[INFO] [stderr] 56 |             InvalidRecord::IoError(ref e) => Some(e),
[INFO] [stderr] 57 |             InvalidRecord::InvalidHeader(ref e) => Some(e),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/reader.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 | /         match self {
[INFO] [stderr] 69 | |             &InvalidHeader(ref e) => write!(f, "invalid record header: {}", e),
[INFO] [stderr] 70 | |             &UnknownLength(None) => write!(f, "record missing required Content-Length header"),
[INFO] [stderr] 71 | |             &UnknownLength(Some(ref bytes)) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 77 | |             &IoError(ref e) => write!(f, "I/O error: {}", e),
[INFO] [stderr] 78 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 68 |         match *self {
[INFO] [stderr] 69 |             InvalidHeader(ref e) => write!(f, "invalid record header: {}", e),
[INFO] [stderr] 70 |             UnknownLength(None) => write!(f, "record missing required Content-Length header"),
[INFO] [stderr] 71 |             UnknownLength(Some(ref bytes)) => {
[INFO] [stderr] 72 |                 write!(f,
[INFO] [stderr] 73 |                        "illegal numeric value for Content-Length: {}",
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/reader.rs:212:9
[INFO] [stderr]     |
[INFO] [stderr] 212 | /         if let &FinishError::Io(ref e) = self {
[INFO] [stderr] 213 | |             write!(f, "I/O error: {}", e)
[INFO] [stderr] 214 | |         } else {
[INFO] [stderr] 215 | |             write!(f, "{}", self.description())
[INFO] [stderr] 216 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 212 |         if let FinishError::Io(ref e) = *self {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/reader.rs:223:9
[INFO] [stderr]     |
[INFO] [stderr] 223 | /         match self {
[INFO] [stderr] 224 | |             &MissingTail => "missing record tail",
[INFO] [stderr] 225 | |             &Io(ref e) => e.description(),
[INFO] [stderr] 226 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 223 |         match *self {
[INFO] [stderr] 224 |             MissingTail => "missing record tail",
[INFO] [stderr] 225 |             Io(ref e) => e.description(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/reader.rs:230:9
[INFO] [stderr]     |
[INFO] [stderr] 230 | /         if let &FinishError::Io(ref e) = self {
[INFO] [stderr] 231 | |             Some(e)
[INFO] [stderr] 232 | |         } else {
[INFO] [stderr] 233 | |             None
[INFO] [stderr] 234 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 230 |         if let FinishError::Io(ref e) = *self {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/reader.rs:308:13
[INFO] [stderr]     |
[INFO] [stderr] 308 | /             match self.reader.read_exact(&mut buf[..]) {
[INFO] [stderr] 309 | |                 Err(e) => {
[INFO] [stderr] 310 | |                     if e.kind() == ::std::io::ErrorKind::UnexpectedEof {
[INFO] [stderr] 311 | |                         return Err(FinishError::MissingTail);
[INFO] [stderr] ...   |
[INFO] [stderr] 315 | |                 Ok(_) => {}
[INFO] [stderr] 316 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 308 |             if let Err(e) = self.reader.read_exact(&mut buf[..]) {
[INFO] [stderr] 309 |     if e.kind() == ::std::io::ErrorKind::UnexpectedEof {
[INFO] [stderr] 310 |         return Err(FinishError::MissingTail);
[INFO] [stderr] 311 |     }
[INFO] [stderr] 312 |     return Err(e.into());
[INFO] [stderr] 313 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:375:12
[INFO] [stderr]     |
[INFO] [stderr] 375 |         if buf.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/warcdedupe.rs:20:15
[INFO] [stderr]    |
[INFO] [stderr] 20 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `output`
[INFO] [stderr]    --> src/bin/warcdedupe.rs:110:13
[INFO] [stderr]     |
[INFO] [stderr] 110 |     let mut output = open_output_stream(args.arg_outfile, args.flag_compress_output);
[INFO] [stderr]     |             ^^^^^^ help: consider using `_output` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]    --> src/bin/warcdedupe.rs:141:21
[INFO] [stderr]     |
[INFO] [stderr] 141 |                 Err(e) => unimplemented!(),
[INFO] [stderr]     |                     ^ help: consider using `_e` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/bin/warcdedupe.rs:110:9
[INFO] [stderr]     |
[INFO] [stderr] 110 |     let mut output = open_output_stream(args.arg_outfile, args.flag_compress_output);
[INFO] [stderr]     |         ----^^^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr]     Checking criterion v0.2.3
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:258:16
[INFO] [stderr]     |
[INFO] [stderr] 258 |                header: header,
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/reader.rs:259:16
[INFO] [stderr]     |
[INFO] [stderr] 259 |                reader: reader,
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/tests.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         fields: fields,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `fields`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:138:16
[INFO] [stderr]     |
[INFO] [stderr] 138 |                version: version,
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:139:16
[INFO] [stderr]     |
[INFO] [stderr] 139 |                fields: fields,
[INFO] [stderr]     |                ^^^^^^^^^^^^^^ help: replace it with: `fields`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:313:13
[INFO] [stderr]     |
[INFO] [stderr] 313 |             value: value,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Result as IoResult`
[INFO] [stderr]  --> src/reader.rs:5:33
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::io::{Error as IoError, Result as IoResult};
[INFO] [stderr]   |                                 ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`.
[INFO] [stderr]    --> src/reader.rs:279:13
[INFO] [stderr]     |
[INFO] [stderr] 279 |         let Record { header: _, bytes_remaining: _, reader: _, marker: _, debug_info: _ } = self;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Record { .. }` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::is_ascii': use inherent methods instead
[INFO] [stderr]    --> src/lib.rs:338:43
[INFO] [stderr]     |
[INFO] [stderr] 338 |             debug_assert!(m[1].iter().all(std::ascii::AsciiExt::is_ascii));
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/reader.rs:46:9
[INFO] [stderr]    |
[INFO] [stderr] 46 | /         match self {
[INFO] [stderr] 47 | |             &InvalidHeader(_) => "invalid or malformed WARC record",
[INFO] [stderr] 48 | |             &UnknownLength(_) => "missing or malformed record Content-Length",
[INFO] [stderr] 49 | |             &EndOfStream => "unexpected end of input",
[INFO] [stderr] 50 | |             &IoError(ref e) => e.description(),
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/warcdedupe.rs:20:15
[INFO] [stderr]    |
[INFO] [stderr] 20 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 46 |         match *self {
[INFO] [stderr] 47 |             InvalidHeader(_) => "invalid or malformed WARC record",
[INFO] [stderr] 48 |             UnknownLength(_) => "missing or malformed record Content-Length",
[INFO] [stderr] 49 |             EndOfStream => "unexpected end of input",
[INFO] [stderr] 50 |             IoError(ref e) => e.description(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/reader.rs:55:9
[INFO] [stderr]    |
[INFO] [stderr] 55 | /         match self {
[INFO] [stderr] 56 | |             &InvalidRecord::IoError(ref e) => Some(e),
[INFO] [stderr] 57 | |             &InvalidRecord::InvalidHeader(ref e) => Some(e),
[INFO] [stderr] 58 | |             _ => None,
[INFO] [stderr] 59 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 55 |         match *self {
[INFO] [stderr] 56 |             InvalidRecord::IoError(ref e) => Some(e),
[INFO] [stderr] 57 |             InvalidRecord::InvalidHeader(ref e) => Some(e),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/reader.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 | /         match self {
[INFO] [stderr] 69 | |             &InvalidHeader(ref e) => write!(f, "invalid record header: {}", e),
[INFO] [stderr] 70 | |             &UnknownLength(None) => write!(f, "record missing required Content-Length header"),
[INFO] [stderr] 71 | |             &UnknownLength(Some(ref bytes)) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 77 | |             &IoError(ref e) => write!(f, "I/O error: {}", e),
[INFO] [stderr] 78 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 68 |         match *self {
[INFO] [stderr] 69 |             InvalidHeader(ref e) => write!(f, "invalid record header: {}", e),
[INFO] [stderr] 70 |             UnknownLength(None) => write!(f, "record missing required Content-Length header"),
[INFO] [stderr] 71 |             UnknownLength(Some(ref bytes)) => {
[INFO] [stderr] 72 |                 write!(f,
[INFO] [stderr] 73 |                        "illegal numeric value for Content-Length: {}",
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/reader.rs:212:9
[INFO] [stderr]     |
[INFO] [stderr] 212 | /         if let &FinishError::Io(ref e) = self {
[INFO] [stderr] 213 | |             write!(f, "I/O error: {}", e)
[INFO] [stderr] 214 | |         } else {
[INFO] [stderr] 215 | |             write!(f, "{}", self.description())
[INFO] [stderr] 216 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 212 |         if let FinishError::Io(ref e) = *self {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/reader.rs:223:9
[INFO] [stderr]     |
[INFO] [stderr] 223 | /         match self {
[INFO] [stderr] 224 | |             &MissingTail => "missing record tail",
[INFO] [stderr] 225 | |             &Io(ref e) => e.description(),
[INFO] [stderr] 226 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 223 |         match *self {
[INFO] [stderr] 224 |             MissingTail => "missing record tail",
[INFO] [stderr] 225 |             Io(ref e) => e.description(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/reader.rs:230:9
[INFO] [stderr]     |
[INFO] [stderr] 230 | /         if let &FinishError::Io(ref e) = self {
[INFO] [stderr] 231 | |             Some(e)
[INFO] [stderr] 232 | |         } else {
[INFO] [stderr] 233 | |             None
[INFO] [stderr] 234 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 230 |         if let FinishError::Io(ref e) = *self {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/reader.rs:308:13
[INFO] [stderr]     |
[INFO] [stderr] 308 | /             match self.reader.read_exact(&mut buf[..]) {
[INFO] [stderr] 309 | |                 Err(e) => {
[INFO] [stderr] 310 | |                     if e.kind() == ::std::io::ErrorKind::UnexpectedEof {
[INFO] [stderr] 311 | |                         return Err(FinishError::MissingTail);
[INFO] [stderr] ...   |
[INFO] [stderr] 315 | |                 Ok(_) => {}
[INFO] [stderr] 316 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 308 |             if let Err(e) = self.reader.read_exact(&mut buf[..]) {
[INFO] [stderr] 309 |     if e.kind() == ::std::io::ErrorKind::UnexpectedEof {
[INFO] [stderr] 310 |         return Err(FinishError::MissingTail);
[INFO] [stderr] 311 |     }
[INFO] [stderr] 312 |     return Err(e.into());
[INFO] [stderr] 313 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/tests.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 | /             match self {
[INFO] [stderr] 53 | |                 &mut DoubleBuffer::Start(fst, _) => Ok(fst),
[INFO] [stderr] 54 | |                 &mut DoubleBuffer::Second(snd) => Ok(snd),
[INFO] [stderr] 55 | |                 &mut DoubleBuffer::Done(_) => panic!("Should not fill after snd"),
[INFO] [stderr] 56 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 52 |             match *self {
[INFO] [stderr] 53 |                 DoubleBuffer::Start(fst, _) => Ok(fst),
[INFO] [stderr] 54 |                 DoubleBuffer::Second(snd) => Ok(snd),
[INFO] [stderr] 55 |                 DoubleBuffer::Done(_) => panic!("Should not fill after snd"),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:375:12
[INFO] [stderr]     |
[INFO] [stderr] 375 |         if buf.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `output`
[INFO] [stderr]    --> src/bin/warcdedupe.rs:110:13
[INFO] [stderr]     |
[INFO] [stderr] 110 |     let mut output = open_output_stream(args.arg_outfile, args.flag_compress_output);
[INFO] [stderr]     |             ^^^^^^ help: consider using `_output` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]    --> src/bin/warcdedupe.rs:141:21
[INFO] [stderr]     |
[INFO] [stderr] 141 |                 Err(e) => unimplemented!(),
[INFO] [stderr]     |                     ^ help: consider using `_e` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/bin/warcdedupe.rs:110:9
[INFO] [stderr]     |
[INFO] [stderr] 110 |     let mut output = open_output_stream(args.arg_outfile, args.flag_compress_output);
[INFO] [stderr]     |         ----^^^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 03s
[INFO] running `"docker" "inspect" "7cda4b6bd21bea1633a348efd4b7f58d9ee2b0826753e84087e22d951fe11b9c"`
[INFO] running `"docker" "rm" "-f" "7cda4b6bd21bea1633a348efd4b7f58d9ee2b0826753e84087e22d951fe11b9c"`
[INFO] [stdout] 7cda4b6bd21bea1633a348efd4b7f58d9ee2b0826753e84087e22d951fe11b9c