[INFO] updating cached repository tamanishi/blockchain_tutorial [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tamanishi/blockchain_tutorial [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tamanishi/blockchain_tutorial" "work/ex/clippy-test-run/sources/stable/gh/tamanishi/blockchain_tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tamanishi/blockchain_tutorial'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tamanishi/blockchain_tutorial" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tamanishi/blockchain_tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tamanishi/blockchain_tutorial'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aee1f6a09050e274fc509873df28358f64317298 [INFO] sha for GitHub repo tamanishi/blockchain_tutorial: aee1f6a09050e274fc509873df28358f64317298 [INFO] validating manifest of tamanishi/blockchain_tutorial on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tamanishi/blockchain_tutorial on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tamanishi/blockchain_tutorial [INFO] finished frobbing tamanishi/blockchain_tutorial [INFO] frobbed toml for tamanishi/blockchain_tutorial written to work/ex/clippy-test-run/sources/stable/gh/tamanishi/blockchain_tutorial/Cargo.toml [INFO] started frobbing tamanishi/blockchain_tutorial [INFO] finished frobbing tamanishi/blockchain_tutorial [INFO] frobbed toml for tamanishi/blockchain_tutorial written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tamanishi/blockchain_tutorial/Cargo.toml [INFO] crate tamanishi/blockchain_tutorial has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tamanishi/blockchain_tutorial against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tamanishi/blockchain_tutorial:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0843338e31f75c20e8d9b651d5331f49375bc00552ed44fb0bd701cc89b132e9 [INFO] running `"docker" "start" "-a" "0843338e31f75c20e8d9b651d5331f49375bc00552ed44fb0bd701cc89b132e9"` [INFO] [stderr] Checking serde v1.0.30 [INFO] [stderr] Checking num-traits v0.2.1 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Compiling serde_derive_internals v0.20.0 [INFO] [stderr] Compiling serde_derive v1.0.30 [INFO] [stderr] Checking serde_json v1.0.11 [INFO] [stderr] Checking blockchain_tutorial v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | amount: amount, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | proof: proof, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `proof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | amount: amount, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return block; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `block` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | proof [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | let proof = blockchain.proof_of_work(&last_block); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return block; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `block` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | proof [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | let proof = blockchain.proof_of_work(&last_block); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.88s [INFO] running `"docker" "inspect" "0843338e31f75c20e8d9b651d5331f49375bc00552ed44fb0bd701cc89b132e9"` [INFO] running `"docker" "rm" "-f" "0843338e31f75c20e8d9b651d5331f49375bc00552ed44fb0bd701cc89b132e9"` [INFO] [stdout] 0843338e31f75c20e8d9b651d5331f49375bc00552ed44fb0bd701cc89b132e9