[INFO] updating cached repository tamamu/gmml [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tamamu/gmml [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tamamu/gmml" "work/ex/clippy-test-run/sources/stable/gh/tamamu/gmml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tamamu/gmml'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tamamu/gmml" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tamamu/gmml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tamamu/gmml'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b2e6d14a99b5b8f1ca7fb8cbd5f56a69a924781f [INFO] sha for GitHub repo tamamu/gmml: b2e6d14a99b5b8f1ca7fb8cbd5f56a69a924781f [INFO] validating manifest of tamamu/gmml on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tamamu/gmml on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tamamu/gmml [INFO] finished frobbing tamamu/gmml [INFO] frobbed toml for tamamu/gmml written to work/ex/clippy-test-run/sources/stable/gh/tamamu/gmml/Cargo.toml [INFO] started frobbing tamamu/gmml [INFO] finished frobbing tamamu/gmml [INFO] frobbed toml for tamamu/gmml written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tamamu/gmml/Cargo.toml [INFO] crate tamamu/gmml has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tamamu/gmml against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tamamu/gmml:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7043ebc599f2d16cf8501b732040a70017f52bee6aa6ccb6828823e59aeea4e1 [INFO] running `"docker" "start" "-a" "7043ebc599f2d16cf8501b732040a70017f52bee6aa6ccb6828823e59aeea4e1"` [INFO] [stderr] Checking gmml v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | toks: toks [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `toks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:315:46 [INFO] [stderr] | [INFO] [stderr] 315 | let block = AST::Block { name: name, content: content }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:315:58 [INFO] [stderr] | [INFO] [stderr] 315 | let block = AST::Block { name: name, content: content }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | toks: toks [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `toks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:315:46 [INFO] [stderr] | [INFO] [stderr] 315 | let block = AST::Block { name: name, content: content }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:315:58 [INFO] [stderr] | [INFO] [stderr] 315 | let block = AST::Block { name: name, content: content }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/parse.rs:349:21 [INFO] [stderr] | [INFO] [stderr] 349 | AST::Edge{from:_,to:_} => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Edge { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/parse.rs:349:21 [INFO] [stderr] | [INFO] [stderr] 349 | AST::Edge{from:_,to:_} => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Edge { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Semicolon` [INFO] [stderr] --> src/parse.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Semicolon, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bt` [INFO] [stderr] --> src/parse.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Bt, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Semicolon` [INFO] [stderr] --> src/parse.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Semicolon, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Bt` [INFO] [stderr] --> src/parse.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Bt, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parse.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | let c = self.buf.get(self.pos).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.buf.get(self.pos).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parse.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | let c = self.buf.get(self.pos).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.buf[self.pos]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parse.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | let d = self.buf.get(self.pos).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.buf[self.pos]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parse.rs:154:52 [INFO] [stderr] | [INFO] [stderr] 154 | while self.pos < self.buf.len() && self.buf.get(self.pos).unwrap() != &'\n' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.buf[self.pos]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parse.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | let c = self.buf.get(self.pos).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.buf.get(self.pos).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parse.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | let c = self.buf.get(self.pos).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.buf[self.pos]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parse.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | let d = self.buf.get(self.pos).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.buf[self.pos]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parse.rs:154:52 [INFO] [stderr] | [INFO] [stderr] 154 | while self.pos < self.buf.len() && self.buf.get(self.pos).unwrap() != &'\n' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.buf[self.pos]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:468:13 [INFO] [stderr] | [INFO] [stderr] 468 | / match second { [INFO] [stderr] 469 | | Token::Symbol(Symbol::RightParen) => { [INFO] [stderr] 470 | | return Ok(AST::List(content)); [INFO] [stderr] 471 | | }, [INFO] [stderr] 472 | | _ => {} [INFO] [stderr] 473 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 468 | if let Token::Symbol(Symbol::RightParen) = second { [INFO] [stderr] 469 | return Ok(AST::List(content)); [INFO] [stderr] 470 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:509:9 [INFO] [stderr] | [INFO] [stderr] 509 | / match second { [INFO] [stderr] 510 | | Token::Symbol(Symbol::RightBrace) => { [INFO] [stderr] 511 | | return Ok(AST::List(content)); [INFO] [stderr] 512 | | }, [INFO] [stderr] 513 | | _ => {} [INFO] [stderr] 514 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 509 | if let Token::Symbol(Symbol::RightBrace) = second { [INFO] [stderr] 510 | return Ok(AST::List(content)); [INFO] [stderr] 511 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:569:9 [INFO] [stderr] | [INFO] [stderr] 569 | / match second { [INFO] [stderr] 570 | | Token::Symbol(Symbol::RightParen) => { [INFO] [stderr] 571 | | break; [INFO] [stderr] 572 | | }, [INFO] [stderr] 573 | | _ => {} [INFO] [stderr] 574 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 569 | if let Token::Symbol(Symbol::RightParen) = second { [INFO] [stderr] 570 | break; [INFO] [stderr] 571 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:468:13 [INFO] [stderr] | [INFO] [stderr] 468 | / match second { [INFO] [stderr] 469 | | Token::Symbol(Symbol::RightParen) => { [INFO] [stderr] 470 | | return Ok(AST::List(content)); [INFO] [stderr] 471 | | }, [INFO] [stderr] 472 | | _ => {} [INFO] [stderr] 473 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 468 | if let Token::Symbol(Symbol::RightParen) = second { [INFO] [stderr] 469 | return Ok(AST::List(content)); [INFO] [stderr] 470 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:509:9 [INFO] [stderr] | [INFO] [stderr] 509 | / match second { [INFO] [stderr] 510 | | Token::Symbol(Symbol::RightBrace) => { [INFO] [stderr] 511 | | return Ok(AST::List(content)); [INFO] [stderr] 512 | | }, [INFO] [stderr] 513 | | _ => {} [INFO] [stderr] 514 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 509 | if let Token::Symbol(Symbol::RightBrace) = second { [INFO] [stderr] 510 | return Ok(AST::List(content)); [INFO] [stderr] 511 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:569:9 [INFO] [stderr] | [INFO] [stderr] 569 | / match second { [INFO] [stderr] 570 | | Token::Symbol(Symbol::RightParen) => { [INFO] [stderr] 571 | | break; [INFO] [stderr] 572 | | }, [INFO] [stderr] 573 | | _ => {} [INFO] [stderr] 574 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 569 | if let Token::Symbol(Symbol::RightParen) = second { [INFO] [stderr] 570 | break; [INFO] [stderr] 571 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | let sym: Vec = scanner.into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `scanner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | let sym: Vec = scanner.into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `scanner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.33s [INFO] running `"docker" "inspect" "7043ebc599f2d16cf8501b732040a70017f52bee6aa6ccb6828823e59aeea4e1"` [INFO] running `"docker" "rm" "-f" "7043ebc599f2d16cf8501b732040a70017f52bee6aa6ccb6828823e59aeea4e1"` [INFO] [stdout] 7043ebc599f2d16cf8501b732040a70017f52bee6aa6ccb6828823e59aeea4e1