[INFO] updating cached repository takluyver/trashexpiry [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/takluyver/trashexpiry [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/takluyver/trashexpiry" "work/ex/clippy-test-run/sources/stable/gh/takluyver/trashexpiry"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/takluyver/trashexpiry'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/takluyver/trashexpiry" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/takluyver/trashexpiry"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/takluyver/trashexpiry'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e7adc97b1409479d61a6378b13a6f3c1f01b3398 [INFO] sha for GitHub repo takluyver/trashexpiry: e7adc97b1409479d61a6378b13a6f3c1f01b3398 [INFO] validating manifest of takluyver/trashexpiry on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of takluyver/trashexpiry on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing takluyver/trashexpiry [INFO] finished frobbing takluyver/trashexpiry [INFO] frobbed toml for takluyver/trashexpiry written to work/ex/clippy-test-run/sources/stable/gh/takluyver/trashexpiry/Cargo.toml [INFO] started frobbing takluyver/trashexpiry [INFO] finished frobbing takluyver/trashexpiry [INFO] frobbed toml for takluyver/trashexpiry written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/takluyver/trashexpiry/Cargo.toml [INFO] crate takluyver/trashexpiry has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting takluyver/trashexpiry against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/takluyver/trashexpiry:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ef92e28c9a3986c055b0f22d81da3b6b832395614118449a120ede1df85c7af [INFO] running `"docker" "start" "-a" "5ef92e28c9a3986c055b0f22d81da3b6b832395614118449a120ede1df85c7af"` [INFO] [stderr] Checking rust-ini v0.10.0 [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Checking trashexpiry v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | deletion_date: deletion_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `deletion_date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | deletion_date: deletion_date, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `deletion_date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / return Ok(TrashInfo{ [INFO] [stderr] 64 | | info_file: PathBuf::from(info_file), [INFO] [stderr] 65 | | trashed_file: info_to_file(info_file)?, [INFO] [stderr] 66 | | original_path: PathBuf::from(orig_path), [INFO] [stderr] 67 | | deletion_date: deletion_date, [INFO] [stderr] 68 | | }) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | Ok(TrashInfo{ [INFO] [stderr] 64 | info_file: PathBuf::from(info_file), [INFO] [stderr] 65 | trashed_file: info_to_file(info_file)?, [INFO] [stderr] 66 | original_path: PathBuf::from(orig_path), [INFO] [stderr] 67 | deletion_date: deletion_date, [INFO] [stderr] 68 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / return Config{ [INFO] [stderr] 106 | | delete_after_days: 60, [INFO] [stderr] 107 | | warn_after_days: 50, [INFO] [stderr] 108 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | Config{ [INFO] [stderr] 106 | delete_after_days: 60, [INFO] [stderr] 107 | warn_after_days: 50, [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / return Ok(TrashInfo{ [INFO] [stderr] 64 | | info_file: PathBuf::from(info_file), [INFO] [stderr] 65 | | trashed_file: info_to_file(info_file)?, [INFO] [stderr] 66 | | original_path: PathBuf::from(orig_path), [INFO] [stderr] 67 | | deletion_date: deletion_date, [INFO] [stderr] 68 | | }) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | Ok(TrashInfo{ [INFO] [stderr] 64 | info_file: PathBuf::from(info_file), [INFO] [stderr] 65 | trashed_file: info_to_file(info_file)?, [INFO] [stderr] 66 | original_path: PathBuf::from(orig_path), [INFO] [stderr] 67 | deletion_date: deletion_date, [INFO] [stderr] 68 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / return Config{ [INFO] [stderr] 106 | | delete_after_days: 60, [INFO] [stderr] 107 | | warn_after_days: 50, [INFO] [stderr] 108 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | Config{ [INFO] [stderr] 106 | delete_after_days: 60, [INFO] [stderr] 107 | warn_after_days: 50, [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.27s [INFO] running `"docker" "inspect" "5ef92e28c9a3986c055b0f22d81da3b6b832395614118449a120ede1df85c7af"` [INFO] running `"docker" "rm" "-f" "5ef92e28c9a3986c055b0f22d81da3b6b832395614118449a120ede1df85c7af"` [INFO] [stdout] 5ef92e28c9a3986c055b0f22d81da3b6b832395614118449a120ede1df85c7af