[INFO] updating cached repository takluyver/deskent
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/takluyver/deskent
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/takluyver/deskent" "work/ex/clippy-test-run/sources/stable/gh/takluyver/deskent"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/takluyver/deskent'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/takluyver/deskent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/takluyver/deskent"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/takluyver/deskent'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] cc830775159723c119ee764ae0e3f66f94ca5017
[INFO] sha for GitHub repo takluyver/deskent: cc830775159723c119ee764ae0e3f66f94ca5017
[INFO] validating manifest of takluyver/deskent on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of takluyver/deskent on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing takluyver/deskent
[INFO] finished frobbing takluyver/deskent
[INFO] frobbed toml for takluyver/deskent written to work/ex/clippy-test-run/sources/stable/gh/takluyver/deskent/Cargo.toml
[INFO] started frobbing takluyver/deskent
[INFO] finished frobbing takluyver/deskent
[INFO] frobbed toml for takluyver/deskent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/takluyver/deskent/Cargo.toml
[INFO] crate takluyver/deskent has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting takluyver/deskent against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/takluyver/deskent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 743f5de5ca9cc2d251a5349dce0ce3f20db89486391725f17f542009a32f4908
[INFO] running `"docker" "start" "-a" "743f5de5ca9cc2d251a5349dce0ce3f20db89486391725f17f542009a32f4908"`
[INFO] [stderr]     Checking rust-ini v0.12.0
[INFO] [stderr]     Checking atty v0.2.10
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]     Checking deskent v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     return Ok(path.read_dir()?
[INFO] [stderr] 40 | |              .filter_map(|v| v.ok())
[INFO] [stderr] 41 | |              .filter(|e| match e.file_type() {
[INFO] [stderr] 42 | |                  Ok(ft) => (ft.is_file() | ft.is_symlink()),
[INFO] [stderr] ...  |
[INFO] [stderr] 45 | |              .filter(|e| e.file_name().to_string_lossy().ends_with(".desktop"))
[INFO] [stderr] 46 | |              .collect::<Vec<_>>());
[INFO] [stderr]    | |___________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 39 |     Ok(path.read_dir()?
[INFO] [stderr] 40 |              .filter_map(|v| v.ok())
[INFO] [stderr] 41 |              .filter(|e| match e.file_type() {
[INFO] [stderr] 42 |                  Ok(ft) => (ft.is_file() | ft.is_symlink()),
[INFO] [stderr] 43 |                  _ => false
[INFO] [stderr] 44 |               })
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     return Ok(path.read_dir()?
[INFO] [stderr] 40 | |              .filter_map(|v| v.ok())
[INFO] [stderr] 41 | |              .filter(|e| match e.file_type() {
[INFO] [stderr] 42 | |                  Ok(ft) => (ft.is_file() | ft.is_symlink()),
[INFO] [stderr] ...  |
[INFO] [stderr] 45 | |              .filter(|e| e.file_name().to_string_lossy().ends_with(".desktop"))
[INFO] [stderr] 46 | |              .collect::<Vec<_>>());
[INFO] [stderr]    | |___________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 39 |     Ok(path.read_dir()?
[INFO] [stderr] 40 |              .filter_map(|v| v.ok())
[INFO] [stderr] 41 |              .filter(|e| match e.file_type() {
[INFO] [stderr] 42 |                  Ok(ft) => (ft.is_file() | ft.is_symlink()),
[INFO] [stderr] 43 |                  _ => false
[INFO] [stderr] 44 |               })
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:16:24
[INFO] [stderr]    |
[INFO] [stderr] 16 |             let home = env::home_dir().ok_or(io::Error::new(io::ErrorKind::Other, "Couldn't get home dir"))?;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:16:24
[INFO] [stderr]    |
[INFO] [stderr] 16 |             let home = env::home_dir().ok_or(io::Error::new(io::ErrorKind::Other, "Couldn't get home dir"))?;
[INFO] [stderr]    |                        ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:16:40
[INFO] [stderr]    |
[INFO] [stderr] 16 |             let home = env::home_dir().ok_or(io::Error::new(io::ErrorKind::Other, "Couldn't get home dir"))?;
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Couldn't get home dir"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:16:40
[INFO] [stderr]    |
[INFO] [stderr] 16 |             let home = env::home_dir().ok_or(io::Error::new(io::ErrorKind::Other, "Couldn't get home dir"))?;
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Couldn't get home dir"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.50s
[INFO] running `"docker" "inspect" "743f5de5ca9cc2d251a5349dce0ce3f20db89486391725f17f542009a32f4908"`
[INFO] running `"docker" "rm" "-f" "743f5de5ca9cc2d251a5349dce0ce3f20db89486391725f17f542009a32f4908"`
[INFO] [stdout] 743f5de5ca9cc2d251a5349dce0ce3f20db89486391725f17f542009a32f4908