[INFO] updating cached repository tahnok/advent2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tahnok/advent2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tahnok/advent2018" "work/ex/clippy-test-run/sources/stable/gh/tahnok/advent2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tahnok/advent2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tahnok/advent2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tahnok/advent2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tahnok/advent2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6a2ad81a69efaeff50789257718686fa8d575216
[INFO] sha for GitHub repo tahnok/advent2018: 6a2ad81a69efaeff50789257718686fa8d575216
[INFO] validating manifest of tahnok/advent2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tahnok/advent2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tahnok/advent2018
[INFO] finished frobbing tahnok/advent2018
[INFO] frobbed toml for tahnok/advent2018 written to work/ex/clippy-test-run/sources/stable/gh/tahnok/advent2018/Cargo.toml
[INFO] started frobbing tahnok/advent2018
[INFO] finished frobbing tahnok/advent2018
[INFO] frobbed toml for tahnok/advent2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tahnok/advent2018/Cargo.toml
[INFO] crate tahnok/advent2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tahnok/advent2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tahnok/advent2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] abcf74b8ac0b213dbb9ea8a43e879203cbae26e6b338b6c90c7288447dfe0acc
[INFO] running `"docker" "start" "-a" "abcf74b8ac0b213dbb9ea8a43e879203cbae26e6b338b6c90c7288447dfe0acc"`
[INFO] [stderr]    Compiling libc v0.2.44
[INFO] [stderr]    Compiling unindent v0.1.3
[INFO] [stderr]    Compiling syn v0.15.22
[INFO] [stderr]     Checking memchr v2.1.1
[INFO] [stderr]     Checking aho-corasick v0.6.9
[INFO] [stderr]     Checking regex v1.1.0
[INFO] [stderr]    Compiling proc-macro-hack v0.5.3
[INFO] [stderr]    Compiling indoc-impl v0.3.1
[INFO] [stderr]     Checking indoc v0.3.1
[INFO] [stderr]     Checking advent2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `indoc::indoc`
[INFO] [stderr]  --> src/bin/day_07_2.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use indoc::indoc;
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/day_07_2.rs:61:17
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 return false;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/day_07_2.rs:63:17
[INFO] [stderr]    |
[INFO] [stderr] 63 |                 return true;
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/day_07_2.rs:81:17
[INFO] [stderr]    |
[INFO] [stderr] 81 |                 return false;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/day_07_2.rs:83:17
[INFO] [stderr]    |
[INFO] [stderr] 83 |                 return true;
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/bin/day_05_2.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 | /     loop {
[INFO] [stderr] 41 | |         if let Some(current) = chars.next() {
[INFO] [stderr] 42 | |             if current.to_ascii_lowercase() == to_drop.to_ascii_lowercase()  {
[INFO] [stderr] 43 | |                 continue;
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |         }
[INFO] [stderr] 56 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(current) = chars.next() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/bin/day_08_1.rs:11:52
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let mut nodes: Vec<usize> = input.trim().split(" ").map(|x| x.parse().unwrap()).collect();
[INFO] [stderr]    |                                                    ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/bin/day_05_1.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 | /     loop {
[INFO] [stderr] 21 | |         if let Some(current) = chars.next() {
[INFO] [stderr] 22 | |             if let Some(last) = result.pop() {
[INFO] [stderr] 23 | |                 if !reacts(current, last) {
[INFO] [stderr] ...  |
[INFO] [stderr] 32 | |         }
[INFO] [stderr] 33 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(current) = chars.next() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/bin/day_07_2.rs:26:35
[INFO] [stderr]    |
[INFO] [stderr] 26 |         result.entry(requirement).or_insert(HashSet::new());
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/bin/day_07_2.rs:28:58
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let mut dependencies = result.entry(required_by).or_insert(HashSet::new());
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/bin/day_07_2.rs:67:44
[INFO] [stderr]    |
[INFO] [stderr] 67 |         while resolving.len() < workers && nexts.len() > 0 {
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!nexts.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/bin/day_03_2.rs:44:51
[INFO] [stderr]    |
[INFO] [stderr] 44 |             let claim_at = claims.entry(position).or_insert(Vec::new());
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]   --> src/bin/day_03_2.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 | /         for id in &ids {
[INFO] [stderr] 57 | |             return *id;
[INFO] [stderr] 58 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `advent2018`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/bin/day_04_2.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 | /         if !guards_and_times.contains_key(&id) {
[INFO] [stderr] 27 | |             guards_and_times.insert(id, HashMap::new());
[INFO] [stderr] 28 | |         }
[INFO] [stderr]    | |_________^ help: consider using: `guards_and_times.entry(id).or_insert(HashMap::new())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::*`
[INFO] [stderr]   --> src/bin/template.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |     use super::*;
[INFO] [stderr]    |         ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/day_07_2.rs:61:17
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 return false;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/day_07_2.rs:63:17
[INFO] [stderr]    |
[INFO] [stderr] 63 |                 return true;
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/day_07_2.rs:81:17
[INFO] [stderr]    |
[INFO] [stderr] 81 |                 return false;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/day_07_2.rs:83:17
[INFO] [stderr]    |
[INFO] [stderr] 83 |                 return true;
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/bin/day_07_2.rs:26:35
[INFO] [stderr]    |
[INFO] [stderr] 26 |         result.entry(requirement).or_insert(HashSet::new());
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/bin/day_07_2.rs:28:58
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let mut dependencies = result.entry(required_by).or_insert(HashSet::new());
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/bin/day_07_2.rs:67:44
[INFO] [stderr]    |
[INFO] [stderr] 67 |         while resolving.len() < workers && nexts.len() > 0 {
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!nexts.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/bin/day_04_1.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 | /         if !guards_and_times.contains_key(&id) {
[INFO] [stderr] 27 | |             guards_and_times.insert(id, HashMap::new());
[INFO] [stderr] 28 | |         }
[INFO] [stderr]    | |_________^ help: consider using: `guards_and_times.entry(id).or_insert(HashMap::new())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/bin/day_04_1.rs:63:28
[INFO] [stderr]    |
[INFO] [stderr] 63 |     for (&time, &count) in guards_and_times.get(&sleepiest_guard).unwrap() {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&guards_and_times[&sleepiest_guard]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "abcf74b8ac0b213dbb9ea8a43e879203cbae26e6b338b6c90c7288447dfe0acc"`
[INFO] running `"docker" "rm" "-f" "abcf74b8ac0b213dbb9ea8a43e879203cbae26e6b338b6c90c7288447dfe0acc"`
[INFO] [stdout] abcf74b8ac0b213dbb9ea8a43e879203cbae26e6b338b6c90c7288447dfe0acc