[INFO] updating cached repository tafia/xl2txt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tafia/xl2txt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tafia/xl2txt" "work/ex/clippy-test-run/sources/stable/gh/tafia/xl2txt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tafia/xl2txt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tafia/xl2txt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tafia/xl2txt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tafia/xl2txt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c527d17870bb7bba0be662498ff60da99de80f89 [INFO] sha for GitHub repo tafia/xl2txt: c527d17870bb7bba0be662498ff60da99de80f89 [INFO] validating manifest of tafia/xl2txt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tafia/xl2txt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tafia/xl2txt [INFO] finished frobbing tafia/xl2txt [INFO] frobbed toml for tafia/xl2txt written to work/ex/clippy-test-run/sources/stable/gh/tafia/xl2txt/Cargo.toml [INFO] started frobbing tafia/xl2txt [INFO] finished frobbing tafia/xl2txt [INFO] frobbed toml for tafia/xl2txt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tafia/xl2txt/Cargo.toml [INFO] crate tafia/xl2txt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tafia/xl2txt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/tafia/xl2txt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dafbfa50da1dad6fffc21393dddd964deaa8ad4d987d52c1b2a8a979b7c5f5e6 [INFO] running `"docker" "start" "-a" "dafbfa50da1dad6fffc21393dddd964deaa8ad4d987d52c1b2a8a979b7c5f5e6"` [INFO] [stderr] Compiling backtrace v0.3.0 [INFO] [stderr] Compiling backtrace-sys v0.1.10 [INFO] [stderr] Compiling miniz-sys v0.1.9 [INFO] [stderr] Checking encoding_rs v0.6.6 [INFO] [stderr] Checking msdos_time v0.1.5 [INFO] [stderr] Checking flate2 v0.2.19 [INFO] [stderr] Checking zip v0.2.3 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking quick-xml v0.7.2 [INFO] [stderr] Checking calamine v0.11.4 [INFO] [stderr] Checking xl2txt v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:123:16 [INFO] [stderr] | [INFO] [stderr] 123 | orig: orig, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `orig` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:125:16 [INFO] [stderr] | [INFO] [stderr] 125 | formula: formula, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:126:16 [INFO] [stderr] | [INFO] [stderr] 126 | vba: vba, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:123:16 [INFO] [stderr] | [INFO] [stderr] 123 | orig: orig, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `orig` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:125:16 [INFO] [stderr] | [INFO] [stderr] 125 | formula: formula, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:126:16 [INFO] [stderr] | [INFO] [stderr] 126 | vba: vba, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | let file = args.by_ref() [INFO] [stderr] | ________________^ [INFO] [stderr] 16 | | .skip(1) [INFO] [stderr] 17 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | for c in scol..ecol + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `scol..=ecol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | let file = args.by_ref() [INFO] [stderr] | ________________^ [INFO] [stderr] 16 | | .skip(1) [INFO] [stderr] 17 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:145:14 [INFO] [stderr] | [INFO] [stderr] 145 | for c in scol..ecol + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `scol..=ecol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.09s [INFO] running `"docker" "inspect" "dafbfa50da1dad6fffc21393dddd964deaa8ad4d987d52c1b2a8a979b7c5f5e6"` [INFO] running `"docker" "rm" "-f" "dafbfa50da1dad6fffc21393dddd964deaa8ad4d987d52c1b2a8a979b7c5f5e6"` [INFO] [stdout] dafbfa50da1dad6fffc21393dddd964deaa8ad4d987d52c1b2a8a979b7c5f5e6