[INFO] updating cached repository syml/rust-webserver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/syml/rust-webserver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/syml/rust-webserver" "work/ex/clippy-test-run/sources/stable/gh/syml/rust-webserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/syml/rust-webserver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/syml/rust-webserver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/syml/rust-webserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/syml/rust-webserver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ba8ca64ad6a54e69550773f991219d1803bb683 [INFO] sha for GitHub repo syml/rust-webserver: 7ba8ca64ad6a54e69550773f991219d1803bb683 [INFO] validating manifest of syml/rust-webserver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of syml/rust-webserver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing syml/rust-webserver [INFO] finished frobbing syml/rust-webserver [INFO] frobbed toml for syml/rust-webserver written to work/ex/clippy-test-run/sources/stable/gh/syml/rust-webserver/Cargo.toml [INFO] started frobbing syml/rust-webserver [INFO] finished frobbing syml/rust-webserver [INFO] frobbed toml for syml/rust-webserver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/syml/rust-webserver/Cargo.toml [INFO] crate syml/rust-webserver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting syml/rust-webserver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/syml/rust-webserver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c15a2b0a68367a50900f3ba2eb1cb6173ceacb64129fa6e79046fe70182363b [INFO] running `"docker" "start" "-a" "7c15a2b0a68367a50900f3ba2eb1cb6173ceacb64129fa6e79046fe70182363b"` [INFO] [stderr] Checking libc v0.2.16 [INFO] [stderr] Checking regex-syntax v0.3.5 [INFO] [stderr] Compiling nix v0.6.0 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking regex v0.1.77 [INFO] [stderr] Checking mio v0.6.0 [INFO] [stderr] Checking webserver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_loop.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | num_workers: num_workers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_workers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_loop.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | event_handler: event_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_server.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | app: app, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_server.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_server.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | app: app, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_server.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | num_workers: num_workers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_workers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_server.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | app: app, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler_lib.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | handlers: handlers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `handlers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler_lib.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | handlers: handlers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `handlers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | num_workers: num_workers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_workers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_loop.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | num_workers: num_workers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_workers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_loop.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | event_handler: event_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_server.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | app: app, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_server.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_server.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | app: app, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_server.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | num_workers: num_workers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_workers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app_server.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | app: app, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `app` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler_lib.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | handlers: handlers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `handlers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler_lib.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | handlers: handlers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `handlers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | num_workers: num_workers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_workers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / return Status { [INFO] [stderr] 17 | | code: 200, [INFO] [stderr] 18 | | desc: "OK".to_string(), [INFO] [stderr] 19 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | Status { [INFO] [stderr] 17 | code: 200, [INFO] [stderr] 18 | desc: "OK".to_string(), [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return Status { [INFO] [stderr] 23 | | code: 404, [INFO] [stderr] 24 | | desc: "Not Found".to_string(), [INFO] [stderr] 25 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | Status { [INFO] [stderr] 23 | code: 404, [INFO] [stderr] 24 | desc: "Not Found".to_string(), [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / return Response { [INFO] [stderr] 40 | | version: "HTTP/1.1".to_string(), [INFO] [stderr] 41 | | status: Status::ok(), [INFO] [stderr] 42 | | headers: HashMap::new(), [INFO] [stderr] 43 | | body: Vec::new(), [INFO] [stderr] 44 | | stream: stream, [INFO] [stderr] 45 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | Response { [INFO] [stderr] 40 | version: "HTTP/1.1".to_string(), [INFO] [stderr] 41 | status: Status::ok(), [INFO] [stderr] 42 | headers: HashMap::new(), [INFO] [stderr] 43 | body: Vec::new(), [INFO] [stderr] 44 | stream: stream, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | return b; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / return Request { [INFO] [stderr] 136 | | method: Method::Get, [INFO] [stderr] 137 | | uri: String::new(), [INFO] [stderr] 138 | | params: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 141 | | body: Vec::new(), [INFO] [stderr] 142 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 135 | Request { [INFO] [stderr] 136 | method: Method::Get, [INFO] [stderr] 137 | uri: String::new(), [INFO] [stderr] 138 | params: HashMap::new(), [INFO] [stderr] 139 | version: String::new(), [INFO] [stderr] 140 | headers: HashMap::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / return RequestBuilder { [INFO] [stderr] 208 | | state: State::ParseRequestLine, [INFO] [stderr] 209 | | data: Vec::new(), [INFO] [stderr] 210 | | parsed: 0, [INFO] [stderr] 211 | | body_size: 0, [INFO] [stderr] 212 | | request: Request::new(), [INFO] [stderr] 213 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 207 | RequestBuilder { [INFO] [stderr] 208 | state: State::ParseRequestLine, [INFO] [stderr] 209 | data: Vec::new(), [INFO] [stderr] 210 | parsed: 0, [INFO] [stderr] 211 | body_size: 0, [INFO] [stderr] 212 | request: Request::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | return self.parse_request(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_request()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_loop.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return EventLoop { [INFO] [stderr] 31 | | host: host.to_string(), [INFO] [stderr] 32 | | num_workers: num_workers, [INFO] [stderr] 33 | | event_handler: event_handler, [INFO] [stderr] 34 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | EventLoop { [INFO] [stderr] 31 | host: host.to_string(), [INFO] [stderr] 32 | num_workers: num_workers, [INFO] [stderr] 33 | event_handler: event_handler, [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/app_server.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / return AppEventHandler { [INFO] [stderr] 42 | | app: app, [INFO] [stderr] 43 | | conns: HashMap::new(), [INFO] [stderr] 44 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 41 | AppEventHandler { [INFO] [stderr] 42 | app: app, [INFO] [stderr] 43 | conns: HashMap::new(), [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/app_server.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return Box::new(AppEventHandler::new(self.app.duplicate())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(AppEventHandler::new(self.app.duplicate()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/app_server.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / return AppServer { [INFO] [stderr] 101 | | host: host.to_string(), [INFO] [stderr] 102 | | num_workers: num_workers, [INFO] [stderr] 103 | | app: app, [INFO] [stderr] 104 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | AppServer { [INFO] [stderr] 101 | host: host.to_string(), [INFO] [stderr] 102 | num_workers: num_workers, [INFO] [stderr] 103 | app: app, [INFO] [stderr] 104 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handlers.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return Box::new(FileSystemHandler::new(&self.path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(FileSystemHandler::new(&self.path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handlers.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return Box::new(FileHandler::new(&self.path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(FileHandler::new(&self.path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handler_lib.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / return HandlerApp { [INFO] [stderr] 26 | | handlers: handlers, [INFO] [stderr] 27 | | builder: RequestBuilder::new(), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | HandlerApp { [INFO] [stderr] 26 | handlers: handlers, [INFO] [stderr] 27 | builder: RequestBuilder::new(), [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return WebServer { [INFO] [stderr] 23 | | host: host.to_string(), [INFO] [stderr] 24 | | handlers: Vec::new(), [INFO] [stderr] 25 | | num_workers: num_workers, [INFO] [stderr] 26 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | WebServer { [INFO] [stderr] 23 | host: host.to_string(), [INFO] [stderr] 24 | handlers: Vec::new(), [INFO] [stderr] 25 | num_workers: num_workers, [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / return Status { [INFO] [stderr] 17 | | code: 200, [INFO] [stderr] 18 | | desc: "OK".to_string(), [INFO] [stderr] 19 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | Status { [INFO] [stderr] 17 | code: 200, [INFO] [stderr] 18 | desc: "OK".to_string(), [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return Status { [INFO] [stderr] 23 | | code: 404, [INFO] [stderr] 24 | | desc: "Not Found".to_string(), [INFO] [stderr] 25 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | Status { [INFO] [stderr] 23 | code: 404, [INFO] [stderr] 24 | desc: "Not Found".to_string(), [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / return Response { [INFO] [stderr] 40 | | version: "HTTP/1.1".to_string(), [INFO] [stderr] 41 | | status: Status::ok(), [INFO] [stderr] 42 | | headers: HashMap::new(), [INFO] [stderr] 43 | | body: Vec::new(), [INFO] [stderr] 44 | | stream: stream, [INFO] [stderr] 45 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | Response { [INFO] [stderr] 40 | version: "HTTP/1.1".to_string(), [INFO] [stderr] 41 | status: Status::ok(), [INFO] [stderr] 42 | headers: HashMap::new(), [INFO] [stderr] 43 | body: Vec::new(), [INFO] [stderr] 44 | stream: stream, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | return b; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / return Request { [INFO] [stderr] 136 | | method: Method::Get, [INFO] [stderr] 137 | | uri: String::new(), [INFO] [stderr] 138 | | params: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 141 | | body: Vec::new(), [INFO] [stderr] 142 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 135 | Request { [INFO] [stderr] 136 | method: Method::Get, [INFO] [stderr] 137 | uri: String::new(), [INFO] [stderr] 138 | params: HashMap::new(), [INFO] [stderr] 139 | version: String::new(), [INFO] [stderr] 140 | headers: HashMap::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / return RequestBuilder { [INFO] [stderr] 208 | | state: State::ParseRequestLine, [INFO] [stderr] 209 | | data: Vec::new(), [INFO] [stderr] 210 | | parsed: 0, [INFO] [stderr] 211 | | body_size: 0, [INFO] [stderr] 212 | | request: Request::new(), [INFO] [stderr] 213 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 207 | RequestBuilder { [INFO] [stderr] 208 | state: State::ParseRequestLine, [INFO] [stderr] 209 | data: Vec::new(), [INFO] [stderr] 210 | parsed: 0, [INFO] [stderr] 211 | body_size: 0, [INFO] [stderr] 212 | request: Request::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | return self.parse_request(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_request()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event_loop.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return EventLoop { [INFO] [stderr] 31 | | host: host.to_string(), [INFO] [stderr] 32 | | num_workers: num_workers, [INFO] [stderr] 33 | | event_handler: event_handler, [INFO] [stderr] 34 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | EventLoop { [INFO] [stderr] 31 | host: host.to_string(), [INFO] [stderr] 32 | num_workers: num_workers, [INFO] [stderr] 33 | event_handler: event_handler, [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/app_server.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / return AppEventHandler { [INFO] [stderr] 42 | | app: app, [INFO] [stderr] 43 | | conns: HashMap::new(), [INFO] [stderr] 44 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 41 | AppEventHandler { [INFO] [stderr] 42 | app: app, [INFO] [stderr] 43 | conns: HashMap::new(), [INFO] [stderr] 44 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/app_server.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return Box::new(AppEventHandler::new(self.app.duplicate())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(AppEventHandler::new(self.app.duplicate()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/app_server.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / return AppServer { [INFO] [stderr] 101 | | host: host.to_string(), [INFO] [stderr] 102 | | num_workers: num_workers, [INFO] [stderr] 103 | | app: app, [INFO] [stderr] 104 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | AppServer { [INFO] [stderr] 101 | host: host.to_string(), [INFO] [stderr] 102 | num_workers: num_workers, [INFO] [stderr] 103 | app: app, [INFO] [stderr] 104 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handlers.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return Box::new(FileSystemHandler::new(&self.path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(FileSystemHandler::new(&self.path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handlers.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return Box::new(FileHandler::new(&self.path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(FileHandler::new(&self.path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handler_lib.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / return HandlerApp { [INFO] [stderr] 26 | | handlers: handlers, [INFO] [stderr] 27 | | builder: RequestBuilder::new(), [INFO] [stderr] 28 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | HandlerApp { [INFO] [stderr] 26 | handlers: handlers, [INFO] [stderr] 27 | builder: RequestBuilder::new(), [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return WebServer { [INFO] [stderr] 23 | | host: host.to_string(), [INFO] [stderr] 24 | | handlers: Vec::new(), [INFO] [stderr] 25 | | num_workers: num_workers, [INFO] [stderr] 26 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | WebServer { [INFO] [stderr] 23 | host: host.to_string(), [INFO] [stderr] 24 | handlers: Vec::new(), [INFO] [stderr] 25 | num_workers: num_workers, [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `http::RequestBuilder` [INFO] [stderr] --> src/http.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | / pub fn new() -> RequestBuilder { [INFO] [stderr] 207 | | return RequestBuilder { [INFO] [stderr] 208 | | state: State::ParseRequestLine, [INFO] [stderr] 209 | | data: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 213 | | }; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 205 | impl Default for http::RequestBuilder { [INFO] [stderr] 206 | fn default() -> Self { [INFO] [stderr] 207 | Self::new() [INFO] [stderr] 208 | } [INFO] [stderr] 209 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | / match self.data[i] { [INFO] [stderr] 220 | | LF => { [INFO] [stderr] 221 | | let res = &self.data[self.parsed..i]; [INFO] [stderr] 222 | | self.parsed = i + 1; [INFO] [stderr] ... | [INFO] [stderr] 225 | | _ => {} [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 219 | if let LF = self.data[i] { [INFO] [stderr] 220 | let res = &self.data[self.parsed..i]; [INFO] [stderr] 221 | self.parsed = i + 1; [INFO] [stderr] 222 | return Some(res.to_vec()); [INFO] [stderr] 223 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http.rs:256:57 [INFO] [stderr] | [INFO] [stderr] 256 | let parts = s.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/event_loop.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | / match poll.poll(&mut events, None) { [INFO] [stderr] 70 | | Err(e) => panic!("Error during poll(): {}", e), [INFO] [stderr] 71 | | Ok(_) => {} [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(e) = poll.poll(&mut events, None) { panic!("Error during poll(): {}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/http_file.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 23 | let mut buf: Vec = Vec::with_capacity(buf_size); [INFO] [stderr] | ---------------------------- help: consider replace allocation with: `vec![0; buf_size]` [INFO] [stderr] 24 | buf.resize(buf_size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `http::RequestBuilder` [INFO] [stderr] --> src/http.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | / pub fn new() -> RequestBuilder { [INFO] [stderr] 207 | | return RequestBuilder { [INFO] [stderr] 208 | | state: State::ParseRequestLine, [INFO] [stderr] 209 | | data: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 213 | | }; [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 205 | impl Default for http::RequestBuilder { [INFO] [stderr] 206 | fn default() -> Self { [INFO] [stderr] 207 | Self::new() [INFO] [stderr] 208 | } [INFO] [stderr] 209 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | / match self.data[i] { [INFO] [stderr] 220 | | LF => { [INFO] [stderr] 221 | | let res = &self.data[self.parsed..i]; [INFO] [stderr] 222 | | self.parsed = i + 1; [INFO] [stderr] ... | [INFO] [stderr] 225 | | _ => {} [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 219 | if let LF = self.data[i] { [INFO] [stderr] 220 | let res = &self.data[self.parsed..i]; [INFO] [stderr] 221 | self.parsed = i + 1; [INFO] [stderr] 222 | return Some(res.to_vec()); [INFO] [stderr] 223 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http.rs:256:57 [INFO] [stderr] | [INFO] [stderr] 256 | let parts = s.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/event_loop.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | / match poll.poll(&mut events, None) { [INFO] [stderr] 70 | | Err(e) => panic!("Error during poll(): {}", e), [INFO] [stderr] 71 | | Ok(_) => {} [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(e) = poll.poll(&mut events, None) { panic!("Error during poll(): {}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/http_file.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 23 | let mut buf: Vec = Vec::with_capacity(buf_size); [INFO] [stderr] | ---------------------------- help: consider replace allocation with: `vec![0; buf_size]` [INFO] [stderr] 24 | buf.resize(buf_size, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.37s [INFO] running `"docker" "inspect" "7c15a2b0a68367a50900f3ba2eb1cb6173ceacb64129fa6e79046fe70182363b"` [INFO] running `"docker" "rm" "-f" "7c15a2b0a68367a50900f3ba2eb1cb6173ceacb64129fa6e79046fe70182363b"` [INFO] [stdout] 7c15a2b0a68367a50900f3ba2eb1cb6173ceacb64129fa6e79046fe70182363b