[INFO] updating cached repository syberant/evolvim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/syberant/evolvim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/syberant/evolvim" "work/ex/clippy-test-run/sources/stable/gh/syberant/evolvim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/syberant/evolvim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/syberant/evolvim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/syberant/evolvim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/syberant/evolvim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f8f15c43218bb33ab4001b9db46e7b304a885c62 [INFO] sha for GitHub repo syberant/evolvim: f8f15c43218bb33ab4001b9db46e7b304a885c62 [INFO] validating manifest of syberant/evolvim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of syberant/evolvim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing syberant/evolvim [INFO] finished frobbing syberant/evolvim [INFO] frobbed toml for syberant/evolvim written to work/ex/clippy-test-run/sources/stable/gh/syberant/evolvim/Cargo.toml [INFO] started frobbing syberant/evolvim [INFO] finished frobbing syberant/evolvim [INFO] frobbed toml for syberant/evolvim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/syberant/evolvim/Cargo.toml [INFO] crate syberant/evolvim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting syberant/evolvim against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/syberant/evolvim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc096a8944a061953c93d71c5004d0d970ee798c91b261c37e0dc7d7ec00520c [INFO] running `"docker" "start" "-a" "dc096a8944a061953c93d71c5004d0d970ee798c91b261c37e0dc7d7ec00520c"` [INFO] [stderr] Compiling cc v1.0.23 [INFO] [stderr] Checking token_store v0.1.2 [INFO] [stderr] Compiling num-complex v0.2.0 [INFO] [stderr] Checking log v0.4.4 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking stb_truetype v0.2.3 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Checking tempfile v3.0.3 [INFO] [stderr] Checking approx v0.3.0 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking x11-dl v2.18.3 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking alga v0.7.1 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking nalgebra v0.16.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking noise v0.5.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking evolvim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return (self.0, self.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.0, self.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / return Board::new_random( [INFO] [stderr] 110 | | board_size, [INFO] [stderr] 111 | | noise_step_size, [INFO] [stderr] 112 | | creature_minimum, [INFO] [stderr] ... | [INFO] [stderr] 116 | | user_control, [INFO] [stderr] 117 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 109 | Board::new_random( [INFO] [stderr] 110 | board_size, [INFO] [stderr] 111 | noise_step_size, [INFO] [stderr] 112 | creature_minimum, [INFO] [stderr] 113 | amount_rocks, [INFO] [stderr] 114 | min_temp, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return board; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `board` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | / return self [INFO] [stderr] 360 | | .climate [INFO] [stderr] 361 | | .get_growth_over_time_range(self.year, last_updated); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 359 | self [INFO] [stderr] 360 | .climate [INFO] [stderr] 361 | .get_growth_over_time_range(self.year, last_updated) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | return self.year; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | return (self.board_width, self.board_height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.board_width, self.board_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:385:9 [INFO] [stderr] | [INFO] [stderr] 385 | return self.board_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.board_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:390:9 [INFO] [stderr] | [INFO] [stderr] 390 | return self.board_height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.board_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:412:9 [INFO] [stderr] | [INFO] [stderr] 412 | return self.creatures.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.creatures.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:422:9 [INFO] [stderr] | [INFO] [stderr] 422 | return SEASONS[season].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SEASONS[season].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/brain.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return self.a_3.as_slice(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.a_3.as_slice()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/brain.rs:163:35 [INFO] [stderr] | [INFO] [stderr] 163 | const MUTATE_MULTI: f64 = 0.001953125; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.001_953_125` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/climate.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / return self.min_temperature + temp_range * 0.5 [INFO] [stderr] 15 | | - temp_range * 0.5 * ((time % 1.0) * 2.0 * PI).cos(); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 14 | self.min_temperature + temp_range * 0.5 [INFO] [stderr] 15 | - temp_range * 0.5 * ((time % 1.0) * 2.0 * PI).cos() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/climate.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return (time - last_updated) * m [INFO] [stderr] 23 | | + (temp_range / PI / 4.0) * ((PI * 2.0 * last_updated).sin() - (PI * 2.0 * time).sin()); [INFO] [stderr] | |____________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | (time - last_updated) * m [INFO] [stderr] 23 | + (temp_range / PI / 4.0) * ((PI * 2.0 * last_updated).sin() - (PI * 2.0 * time).sin()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/climate.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return self.temperature; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.temperature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/sbip.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return SoftBodiesInPositions(allocated_rows); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SoftBodiesInPositions(allocated_rows)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/sbip.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return &self.0[x][y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.0[x][y]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/sbip.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return soft_body_bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `soft_body_bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/creature.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return self.get_energy() < SAFE_SIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_energy() < SAFE_SIZE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/creature.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return self.birth_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.birth_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/creature.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return time - self.birth_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `time - self.birth_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/creature.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return self.mouth_hue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.mouth_hue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return (self.energy / ENERGY_DENSITY / PI).sqrt().max(0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.energy / ENERGY_DENSITY / PI).sqrt().max(0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | return self.energy / ENERGY_DENSITY * self.density; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.energy / ENERGY_DENSITY * self.density` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | return (self.vx.powi(2) + self.vy.powi(2)).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.vx.powi(2) + self.vy.powi(2)).sqrt()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | / return self.prev_sbip_max_x != self.sbip_max_x [INFO] [stderr] 177 | | || self.prev_sbip_max_y != self.sbip_max_y [INFO] [stderr] 178 | | || self.prev_sbip_min_x != self.sbip_min_x [INFO] [stderr] 179 | | || self.prev_sbip_min_y != self.sbip_min_y; [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 176 | self.prev_sbip_max_x != self.sbip_max_x [INFO] [stderr] 177 | || self.prev_sbip_max_y != self.sbip_max_y [INFO] [stderr] 178 | || self.prev_sbip_min_x != self.sbip_min_x [INFO] [stderr] 179 | || self.prev_sbip_min_y != self.sbip_min_y [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | return (choice_x, choice_y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(choice_x, choice_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | return tile.is_water(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tile.is_water()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:305:9 [INFO] [stderr] | [INFO] [stderr] 305 | return self.energy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.energy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | return self.px; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.px` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | return self.py; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.py` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return self.0.read().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.0.read().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return self.0.write().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.0.write().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return self.0.try_write().is_ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.0.try_write().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | return x.max(0).min(board_width - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.max(0).min(board_width - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | return y.max(0).min(board_height - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `y.max(0).min(board_height - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | return self.get_creature().get_birth_time(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_creature().get_birth_time()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:409:9 [INFO] [stderr] | [INFO] [stderr] 409 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:425:9 [INFO] [stderr] | [INFO] [stderr] 425 | return self.get_creature().should_die(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_creature().should_die()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/tile.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | / return inter_color_fixed_hue( [INFO] [stderr] 64 | | c, [INFO] [stderr] 65 | | food_color, [INFO] [stderr] 66 | | (t.food_level / MAX_GROWTH_LEVEL) as f32, [INFO] [stderr] 67 | | t.food_type as f32, [INFO] [stderr] 68 | | ); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | inter_color_fixed_hue( [INFO] [stderr] 64 | c, [INFO] [stderr] 65 | food_color, [INFO] [stderr] 66 | (t.food_level / MAX_GROWTH_LEVEL) as f32, [INFO] [stderr] 67 | t.food_type as f32, [INFO] [stderr] 68 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/tile.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | return [COLOR_BARREN[0], COLOR_BARREN[1], COLOR_BARREN[2], 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[COLOR_BARREN[0], COLOR_BARREN[1], COLOR_BARREN[2], 1.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/tile.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | / return inter_color_fixed_hue( [INFO] [stderr] 74 | | food_color, [INFO] [stderr] 75 | | COLOR_BLACK, [INFO] [stderr] 76 | | 1.0 - (MAX_GROWTH_LEVEL / t.food_level) as f32, [INFO] [stderr] 77 | | t.food_type as f32, [INFO] [stderr] 78 | | ); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 73 | inter_color_fixed_hue( [INFO] [stderr] 74 | food_color, [INFO] [stderr] 75 | COLOR_BLACK, [INFO] [stderr] 76 | 1.0 - (MAX_GROWTH_LEVEL / t.food_level) as f32, [INFO] [stderr] 77 | t.food_type as f32, [INFO] [stderr] 78 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/tile.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return 1.0 - (self.food_type - hue).abs() / FOOD_SENSITIVITY; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `1.0 - (self.food_type - hue).abs() / FOOD_SENSITIVITY` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/tile.rs:216:5 [INFO] [stderr] | [INFO] [stderr] 216 | return a + (b - a) * x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + (b - a) * x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/mod.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return &mut self.tiles[x][y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.tiles[x][y]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return &self.tiles[x][y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.tiles[x][y]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/mod.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | return Terrain::generate_terrain_with_noise(noise_generator, board_size, step_size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Terrain::generate_terrain_with_noise(noise_generator, board_size, step_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/mod.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return self.tiles.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.tiles.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/mod.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return self.tiles[0].len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.tiles[0].len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return (self.0, self.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.0, self.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / return Board::new_random( [INFO] [stderr] 110 | | board_size, [INFO] [stderr] 111 | | noise_step_size, [INFO] [stderr] 112 | | creature_minimum, [INFO] [stderr] ... | [INFO] [stderr] 116 | | user_control, [INFO] [stderr] 117 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 109 | Board::new_random( [INFO] [stderr] 110 | board_size, [INFO] [stderr] 111 | noise_step_size, [INFO] [stderr] 112 | creature_minimum, [INFO] [stderr] 113 | amount_rocks, [INFO] [stderr] 114 | min_temp, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return board; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `board` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | / return self [INFO] [stderr] 360 | | .climate [INFO] [stderr] 361 | | .get_growth_over_time_range(self.year, last_updated); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 359 | self [INFO] [stderr] 360 | .climate [INFO] [stderr] 361 | .get_growth_over_time_range(self.year, last_updated) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | return self.year; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | return (self.board_width, self.board_height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.board_width, self.board_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:385:9 [INFO] [stderr] | [INFO] [stderr] 385 | return self.board_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.board_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:390:9 [INFO] [stderr] | [INFO] [stderr] 390 | return self.board_height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.board_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:412:9 [INFO] [stderr] | [INFO] [stderr] 412 | return self.creatures.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.creatures.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/board.rs:422:9 [INFO] [stderr] | [INFO] [stderr] 422 | return SEASONS[season].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SEASONS[season].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/brain.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return self.a_3.as_slice(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.a_3.as_slice()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/brain.rs:163:35 [INFO] [stderr] | [INFO] [stderr] 163 | const MUTATE_MULTI: f64 = 0.001953125; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.001_953_125` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/climate.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / return self.min_temperature + temp_range * 0.5 [INFO] [stderr] 15 | | - temp_range * 0.5 * ((time % 1.0) * 2.0 * PI).cos(); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 14 | self.min_temperature + temp_range * 0.5 [INFO] [stderr] 15 | - temp_range * 0.5 * ((time % 1.0) * 2.0 * PI).cos() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/climate.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / return (time - last_updated) * m [INFO] [stderr] 23 | | + (temp_range / PI / 4.0) * ((PI * 2.0 * last_updated).sin() - (PI * 2.0 * time).sin()); [INFO] [stderr] | |____________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | (time - last_updated) * m [INFO] [stderr] 23 | + (temp_range / PI / 4.0) * ((PI * 2.0 * last_updated).sin() - (PI * 2.0 * time).sin()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/climate.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return self.temperature; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.temperature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/sbip.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return SoftBodiesInPositions(allocated_rows); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SoftBodiesInPositions(allocated_rows)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/sbip.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return &self.0[x][y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.0[x][y]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/sbip.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return soft_body_bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `soft_body_bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/creature.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return self.get_energy() < SAFE_SIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_energy() < SAFE_SIZE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/creature.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return self.birth_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.birth_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/creature.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return time - self.birth_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `time - self.birth_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/creature.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return self.mouth_hue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.mouth_hue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return (self.energy / ENERGY_DENSITY / PI).sqrt().max(0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.energy / ENERGY_DENSITY / PI).sqrt().max(0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | return self.energy / ENERGY_DENSITY * self.density; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.energy / ENERGY_DENSITY * self.density` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | return (self.vx.powi(2) + self.vy.powi(2)).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.vx.powi(2) + self.vy.powi(2)).sqrt()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | / return self.prev_sbip_max_x != self.sbip_max_x [INFO] [stderr] 177 | | || self.prev_sbip_max_y != self.sbip_max_y [INFO] [stderr] 178 | | || self.prev_sbip_min_x != self.sbip_min_x [INFO] [stderr] 179 | | || self.prev_sbip_min_y != self.sbip_min_y; [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 176 | self.prev_sbip_max_x != self.sbip_max_x [INFO] [stderr] 177 | || self.prev_sbip_max_y != self.sbip_max_y [INFO] [stderr] 178 | || self.prev_sbip_min_x != self.sbip_min_x [INFO] [stderr] 179 | || self.prev_sbip_min_y != self.sbip_min_y [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | return (choice_x, choice_y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(choice_x, choice_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | return tile.is_water(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tile.is_water()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:305:9 [INFO] [stderr] | [INFO] [stderr] 305 | return self.energy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.energy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | return self.px; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.px` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/rock.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | return self.py; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.py` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return self.0.read().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.0.read().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return self.0.write().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.0.write().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return self.0.try_write().is_ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.0.try_write().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | return x.max(0).min(board_width - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.max(0).min(board_width - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | return y.max(0).min(board_height - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `y.max(0).min(board_height - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:353:9 [INFO] [stderr] | [INFO] [stderr] 353 | return self.get_creature().get_birth_time(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_creature().get_birth_time()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:409:9 [INFO] [stderr] | [INFO] [stderr] 409 | return input; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/softbody/mod.rs:425:9 [INFO] [stderr] | [INFO] [stderr] 425 | return self.get_creature().should_die(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_creature().should_die()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/tile.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | / return inter_color_fixed_hue( [INFO] [stderr] 64 | | c, [INFO] [stderr] 65 | | food_color, [INFO] [stderr] 66 | | (t.food_level / MAX_GROWTH_LEVEL) as f32, [INFO] [stderr] 67 | | t.food_type as f32, [INFO] [stderr] 68 | | ); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | inter_color_fixed_hue( [INFO] [stderr] 64 | c, [INFO] [stderr] 65 | food_color, [INFO] [stderr] 66 | (t.food_level / MAX_GROWTH_LEVEL) as f32, [INFO] [stderr] 67 | t.food_type as f32, [INFO] [stderr] 68 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/tile.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | return [COLOR_BARREN[0], COLOR_BARREN[1], COLOR_BARREN[2], 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[COLOR_BARREN[0], COLOR_BARREN[1], COLOR_BARREN[2], 1.0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/tile.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | / return inter_color_fixed_hue( [INFO] [stderr] 74 | | food_color, [INFO] [stderr] 75 | | COLOR_BLACK, [INFO] [stderr] 76 | | 1.0 - (MAX_GROWTH_LEVEL / t.food_level) as f32, [INFO] [stderr] 77 | | t.food_type as f32, [INFO] [stderr] 78 | | ); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 73 | inter_color_fixed_hue( [INFO] [stderr] 74 | food_color, [INFO] [stderr] 75 | COLOR_BLACK, [INFO] [stderr] 76 | 1.0 - (MAX_GROWTH_LEVEL / t.food_level) as f32, [INFO] [stderr] 77 | t.food_type as f32, [INFO] [stderr] 78 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/tile.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return 1.0 - (self.food_type - hue).abs() / FOOD_SENSITIVITY; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `1.0 - (self.food_type - hue).abs() / FOOD_SENSITIVITY` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/tile.rs:216:5 [INFO] [stderr] | [INFO] [stderr] 216 | return a + (b - a) * x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + (b - a) * x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/mod.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return &mut self.tiles[x][y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.tiles[x][y]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return &self.tiles[x][y]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.tiles[x][y]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/mod.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | return Terrain::generate_terrain_with_noise(noise_generator, board_size, step_size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Terrain::generate_terrain_with_noise(noise_generator, board_size, step_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/mod.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return self.tiles.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.tiles.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/terrain/mod.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return self.tiles[0].len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.tiles[0].len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib/board.rs:492:26 [INFO] [stderr] | [INFO] [stderr] 492 | .map(|c| HLSoftBody::from(c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HLSoftBody::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib/board.rs:495:46 [INFO] [stderr] | [INFO] [stderr] 495 | rocks_ir.into_iter().map(|r| HLSoftBody::from(r)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HLSoftBody::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a type alias [INFO] [stderr] --> src/lib/brain.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub type BrainOutput<'a> = &'a [FPN]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib/brain.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | #![warn(missing_docs)] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a type alias [INFO] [stderr] --> src/lib/brain.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub type BrainInput = [FPN; 9]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/brain.rs:149:28 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn evolve(parents: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[HLSoftBody]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib/brain.rs:220:30 [INFO] [stderr] | [INFO] [stderr] 220 | info.into_iter().map(|val| String::from(val)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/lib/sbip.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for i in 0..self.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for in &self { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/softbody/rock.rs:74:38 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn new_from_parents(parents: &Vec, energy: f64) -> Rock { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[HLSoftBody]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib/softbody/rock.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | self.prev_sbip_min_x..self.prev_sbip_max_x + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.prev_sbip_min_x..=self.prev_sbip_max_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib/softbody/rock.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | self.prev_sbip_min_y..self.prev_sbip_max_y + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.prev_sbip_min_y..=self.prev_sbip_max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib/softbody/rock.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | self.sbip_min_x..self.sbip_max_x + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.sbip_min_x..=self.sbip_max_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib/softbody/rock.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | self.sbip_min_y..self.sbip_max_y + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.sbip_min_y..=self.sbip_max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib/softbody/mod.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | Creature(Creature), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 290 | Creature(Box), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/softbody/mod.rs:405:20 [INFO] [stderr] | [INFO] [stderr] 405 | input[2] = c[0] as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/softbody/mod.rs:406:20 [INFO] [stderr] | [INFO] [stderr] 406 | input[3] = c[1] as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/softbody/mod.rs:407:20 [INFO] [stderr] | [INFO] [stderr] 407 | input[4] = c[2] as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib/board.rs:492:26 [INFO] [stderr] | [INFO] [stderr] 492 | .map(|c| HLSoftBody::from(c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HLSoftBody::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib/board.rs:495:46 [INFO] [stderr] | [INFO] [stderr] 495 | rocks_ir.into_iter().map(|r| HLSoftBody::from(r)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HLSoftBody::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/brain.rs:149:28 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn evolve(parents: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[HLSoftBody]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main/graphics/mod.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | let (r, g, b): (f32, f32, f32) = match h.ceil() as usize { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main/graphics/mod.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | let (r, g, b): (f32, f32, f32) = match h.ceil() as usize { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main/graphics/mod.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | let m = bri - c; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib/brain.rs:220:30 [INFO] [stderr] | [INFO] [stderr] 220 | info.into_iter().map(|val| String::from(val)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main/graphics/mod.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | let (r, g, b): (f32, f32, f32) = match h.ceil() as usize { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main/graphics/mod.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | let (r, g, b): (f32, f32, f32) = match h.ceil() as usize { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main/graphics/mod.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | let m = bri - c; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/lib/sbip.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for i in 0..self.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for in &self { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/softbody/rock.rs:74:38 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn new_from_parents(parents: &Vec, energy: f64) -> Rock { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[HLSoftBody]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib/softbody/rock.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | self.prev_sbip_min_x..self.prev_sbip_max_x + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.prev_sbip_min_x..=self.prev_sbip_max_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib/softbody/rock.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | self.prev_sbip_min_y..self.prev_sbip_max_y + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.prev_sbip_min_y..=self.prev_sbip_max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib/softbody/rock.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | self.sbip_min_x..self.sbip_max_x + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.sbip_min_x..=self.sbip_max_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib/softbody/rock.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | self.sbip_min_y..self.sbip_max_y + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.sbip_min_y..=self.sbip_max_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib/softbody/mod.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | Creature(Creature), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 290 | Creature(Box), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/softbody/mod.rs:405:20 [INFO] [stderr] | [INFO] [stderr] 405 | input[2] = c[0] as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/softbody/mod.rs:406:20 [INFO] [stderr] | [INFO] [stderr] 406 | input[3] = c[1] as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib/softbody/mod.rs:407:20 [INFO] [stderr] | [INFO] [stderr] 407 | input[4] = c[2] as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/ui.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return MouseCoordinate(x, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MouseCoordinate(x, y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/view.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return self.tile_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.tile_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/view.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | return self.precise_x.floor().max(0.0) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.precise_x.floor().max(0.0) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/view.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | return self.precise_y.floor().max(0.0) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.precise_y.floor().max(0.0) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/view.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | return self.precise_x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.precise_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/view.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return self.precise_y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.precise_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/mod.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return [r + m, g + m, b + m, alpha]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[r + m, g + m, b + m, alpha]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/ui.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return MouseCoordinate(x, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MouseCoordinate(x, y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/view.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | return self.tile_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.tile_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/view.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | return self.precise_x.floor().max(0.0) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.precise_x.floor().max(0.0) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/view.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | return self.precise_y.floor().max(0.0) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.precise_y.floor().max(0.0) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/view.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | return self.precise_x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.precise_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/view.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return self.precise_y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.precise_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main/graphics/mod.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return [r + m, g + m, b + m, alpha]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[r + m, g + m, b + m, alpha]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/checkTerrainGen.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | let color = match tile.is_water() { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 28 | | false => [ [INFO] [stderr] 29 | | // tile.get_food_type() as f32, [INFO] [stderr] 30 | | 0.0, [INFO] [stderr] ... | [INFO] [stderr] 35 | | true => [0.0, 0.0, 1.0, 1.0], [INFO] [stderr] 36 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 27 | let color = if tile.is_water() { [0.0, 0.0, 1.0, 1.0] } else { [ [INFO] [stderr] 28 | // tile.get_food_type() as f32, [INFO] [stderr] 29 | 0.0, [INFO] [stderr] 30 | tile.get_fertility() as f32, [INFO] [stderr] 31 | 0.0, [INFO] [stderr] 32 | 1.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/checkTerrainGen.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | / match button { [INFO] [stderr] 48 | | Keyboard(Key::Up) => { [INFO] [stderr] 49 | | board = Board::default(); [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | _ => (), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | if let Keyboard(Key::Up) = button { [INFO] [stderr] 48 | board = Board::default(); [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MinTemperature` [INFO] [stderr] --> src/main/graphics/ui.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | MinTemperature, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MaxTemperature` [INFO] [stderr] --> src/main/graphics/ui.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | MaxTemperature, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw_rock` [INFO] [stderr] --> src/main/graphics/mod.rs:163:1 [INFO] [stderr] | [INFO] [stderr] 163 | / pub fn draw_rock(rock: &Rock, context: Context, graphics: &mut G, view: &View) [INFO] [stderr] 164 | | where [INFO] [stderr] 165 | | G: Graphics, [INFO] [stderr] 166 | | { [INFO] [stderr] ... | [INFO] [stderr] 184 | | ellipse.draw(rect, &context.draw_state, transform, graphics); [INFO] [stderr] 185 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/main/graphics/ui.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | &self, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/main/graphics/ui.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | &self, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main/graphics/view.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match self.drag { [INFO] [stderr] 100 | | Board => { [INFO] [stderr] 101 | | self.change_precise_x(-change_x / MOUSE_SPEED); [INFO] [stderr] 102 | | self.change_precise_y(-change_y / MOUSE_SPEED); [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 99 | if let Board = self.drag { [INFO] [stderr] 100 | self.change_precise_x(-change_x / MOUSE_SPEED); [INFO] [stderr] 101 | self.change_precise_y(-change_y / MOUSE_SPEED); [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `text_to_draw`. [INFO] [stderr] --> src/main/graphics/mod.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..text_to_draw.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for in &text_to_draw { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main/mod.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | / match input { [INFO] [stderr] 97 | | Button(b_args) => match b_args.button { [INFO] [stderr] 98 | | Mouse(m_args) => match m_args { [INFO] [stderr] 99 | | Left => match b_args.state { [INFO] [stderr] ... | [INFO] [stderr] 107 | | _ => {} [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | if let Button(b_args) = input { match b_args.button { [INFO] [stderr] 97 | Mouse(m_args) => match m_args { [INFO] [stderr] 98 | Left => match b_args.state { [INFO] [stderr] 99 | Press => view.on_mouse_press(), [INFO] [stderr] 100 | Release => view.on_mouse_release(), [INFO] [stderr] 101 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main/mod.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | Button(b_args) => match b_args.button { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 98 | | Mouse(m_args) => match m_args { [INFO] [stderr] 99 | | Left => match b_args.state { [INFO] [stderr] 100 | | Press => view.on_mouse_press(), [INFO] [stderr] ... | [INFO] [stderr] 105 | | _ => {} [INFO] [stderr] 106 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | Button(b_args) => if let Mouse(m_args) = b_args.button { match m_args { [INFO] [stderr] 98 | Left => match b_args.state { [INFO] [stderr] 99 | Press => view.on_mouse_press(), [INFO] [stderr] 100 | Release => view.on_mouse_release(), [INFO] [stderr] 101 | }, [INFO] [stderr] 102 | _ => {} [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main/mod.rs:98:38 [INFO] [stderr] | [INFO] [stderr] 98 | Mouse(m_args) => match m_args { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 99 | | Left => match b_args.state { [INFO] [stderr] 100 | | Press => view.on_mouse_press(), [INFO] [stderr] 101 | | Release => view.on_mouse_release(), [INFO] [stderr] 102 | | }, [INFO] [stderr] 103 | | _ => {} [INFO] [stderr] 104 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | Mouse(m_args) => if let Left = m_args { match b_args.state { [INFO] [stderr] 99 | Press => view.on_mouse_press(), [INFO] [stderr] 100 | Release => view.on_mouse_release(), [INFO] [stderr] 101 | } }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/checkTerrainGen.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | let color = match tile.is_water() { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 28 | | false => [ [INFO] [stderr] 29 | | // tile.get_food_type() as f32, [INFO] [stderr] 30 | | 0.0, [INFO] [stderr] ... | [INFO] [stderr] 35 | | true => [0.0, 0.0, 1.0, 1.0], [INFO] [stderr] 36 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 27 | let color = if tile.is_water() { [0.0, 0.0, 1.0, 1.0] } else { [ [INFO] [stderr] 28 | // tile.get_food_type() as f32, [INFO] [stderr] 29 | 0.0, [INFO] [stderr] 30 | tile.get_fertility() as f32, [INFO] [stderr] 31 | 0.0, [INFO] [stderr] 32 | 1.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/checkTerrainGen.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | / match button { [INFO] [stderr] 48 | | Keyboard(Key::Up) => { [INFO] [stderr] 49 | | board = Board::default(); [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | _ => (), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | if let Keyboard(Key::Up) = button { [INFO] [stderr] 48 | board = Board::default(); [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MinTemperature` [INFO] [stderr] --> src/main/graphics/ui.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | MinTemperature, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MaxTemperature` [INFO] [stderr] --> src/main/graphics/ui.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | MaxTemperature, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw_rock` [INFO] [stderr] --> src/main/graphics/mod.rs:163:1 [INFO] [stderr] | [INFO] [stderr] 163 | / pub fn draw_rock(rock: &Rock, context: Context, graphics: &mut G, view: &View) [INFO] [stderr] 164 | | where [INFO] [stderr] 165 | | G: Graphics, [INFO] [stderr] 166 | | { [INFO] [stderr] ... | [INFO] [stderr] 184 | | ellipse.draw(rect, &context.draw_state, transform, graphics); [INFO] [stderr] 185 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/main/graphics/ui.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | &self, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/main/graphics/ui.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | &self, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main/graphics/view.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match self.drag { [INFO] [stderr] 100 | | Board => { [INFO] [stderr] 101 | | self.change_precise_x(-change_x / MOUSE_SPEED); [INFO] [stderr] 102 | | self.change_precise_y(-change_y / MOUSE_SPEED); [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 99 | if let Board = self.drag { [INFO] [stderr] 100 | self.change_precise_x(-change_x / MOUSE_SPEED); [INFO] [stderr] 101 | self.change_precise_y(-change_y / MOUSE_SPEED); [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `text_to_draw`. [INFO] [stderr] --> src/main/graphics/mod.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..text_to_draw.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for in &text_to_draw { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main/mod.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | / match input { [INFO] [stderr] 97 | | Button(b_args) => match b_args.button { [INFO] [stderr] 98 | | Mouse(m_args) => match m_args { [INFO] [stderr] 99 | | Left => match b_args.state { [INFO] [stderr] ... | [INFO] [stderr] 107 | | _ => {} [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | if let Button(b_args) = input { match b_args.button { [INFO] [stderr] 97 | Mouse(m_args) => match m_args { [INFO] [stderr] 98 | Left => match b_args.state { [INFO] [stderr] 99 | Press => view.on_mouse_press(), [INFO] [stderr] 100 | Release => view.on_mouse_release(), [INFO] [stderr] 101 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main/mod.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | Button(b_args) => match b_args.button { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 98 | | Mouse(m_args) => match m_args { [INFO] [stderr] 99 | | Left => match b_args.state { [INFO] [stderr] 100 | | Press => view.on_mouse_press(), [INFO] [stderr] ... | [INFO] [stderr] 105 | | _ => {} [INFO] [stderr] 106 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | Button(b_args) => if let Mouse(m_args) = b_args.button { match m_args { [INFO] [stderr] 98 | Left => match b_args.state { [INFO] [stderr] 99 | Press => view.on_mouse_press(), [INFO] [stderr] 100 | Release => view.on_mouse_release(), [INFO] [stderr] 101 | }, [INFO] [stderr] 102 | _ => {} [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main/mod.rs:98:38 [INFO] [stderr] | [INFO] [stderr] 98 | Mouse(m_args) => match m_args { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 99 | | Left => match b_args.state { [INFO] [stderr] 100 | | Press => view.on_mouse_press(), [INFO] [stderr] 101 | | Release => view.on_mouse_release(), [INFO] [stderr] 102 | | }, [INFO] [stderr] 103 | | _ => {} [INFO] [stderr] 104 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | Mouse(m_args) => if let Left = m_args { match b_args.state { [INFO] [stderr] 99 | Press => view.on_mouse_press(), [INFO] [stderr] 100 | Release => view.on_mouse_release(), [INFO] [stderr] 101 | } }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 20s [INFO] running `"docker" "inspect" "dc096a8944a061953c93d71c5004d0d970ee798c91b261c37e0dc7d7ec00520c"` [INFO] running `"docker" "rm" "-f" "dc096a8944a061953c93d71c5004d0d970ee798c91b261c37e0dc7d7ec00520c"` [INFO] [stdout] dc096a8944a061953c93d71c5004d0d970ee798c91b261c37e0dc7d7ec00520c