[INFO] updating cached repository sxend/rsrok [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sxend/rsrok [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sxend/rsrok" "work/ex/clippy-test-run/sources/stable/gh/sxend/rsrok"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sxend/rsrok'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sxend/rsrok" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sxend/rsrok"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sxend/rsrok'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 26bba68a40ec601b0b1ace69faf08072614cda31 [INFO] sha for GitHub repo sxend/rsrok: 26bba68a40ec601b0b1ace69faf08072614cda31 [INFO] validating manifest of sxend/rsrok on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sxend/rsrok on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sxend/rsrok [INFO] finished frobbing sxend/rsrok [INFO] frobbed toml for sxend/rsrok written to work/ex/clippy-test-run/sources/stable/gh/sxend/rsrok/Cargo.toml [INFO] started frobbing sxend/rsrok [INFO] finished frobbing sxend/rsrok [INFO] frobbed toml for sxend/rsrok written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sxend/rsrok/Cargo.toml [INFO] crate sxend/rsrok has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sxend/rsrok against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sxend/rsrok:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a5d09cfdd3ff3f3d50cca770480b848b382999f7ab6235551cb48d14992987c5 [INFO] running `"docker" "start" "-a" "a5d09cfdd3ff3f3d50cca770480b848b382999f7ab6235551cb48d14992987c5"` [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking conduit-mime-types v0.7.3 [INFO] [stderr] Checking error v0.1.9 [INFO] [stderr] Checking serde_json v1.0.3 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking url v1.5.1 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking rsrok v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rsrokd.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | rsrokd: rsrokd, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rsrokd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rsrokd.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | router: router, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `router` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rsrokd.rs:140:25 [INFO] [stderr] | [INFO] [stderr] 140 | TunnelHandler { rsrokd: rsrokd } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rsrokd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rsrokd.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | rsrokd: rsrokd, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rsrokd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rsrokd.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | router: router, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `router` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rsrokd.rs:140:25 [INFO] [stderr] | [INFO] [stderr] 140 | TunnelHandler { rsrokd: rsrokd } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rsrokd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/rsrok.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | use clap::{App, Arg, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::*` [INFO] [stderr] --> src/rsrok.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use iron::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::typemap` [INFO] [stderr] --> src/rsrok.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use iron::typemap; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::headers::*` [INFO] [stderr] --> src/rsrok.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use iron::headers::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `router::Router` [INFO] [stderr] --> src/rsrok.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use router::Router; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/rsrok.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | use clap::{App, Arg, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::*` [INFO] [stderr] --> src/rsrok.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use iron::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::typemap` [INFO] [stderr] --> src/rsrok.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use iron::typemap; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::headers::*` [INFO] [stderr] --> src/rsrok.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use iron::headers::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `router::Router` [INFO] [stderr] --> src/rsrok.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use router::Router; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/rsrokd.rs:105:27 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/rsrokd.rs:105:27 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/rsrokd.rs:105:27 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/rsrokd.rs:105:27 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/rsrokd.rs:104:14 [INFO] [stderr] | [INFO] [stderr] 104 | fn dummy(req: &mut Request) -> IronResult { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/rsrokd.rs:108:25 [INFO] [stderr] | [INFO] [stderr] 108 | let foo = move |req: &mut Request| { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/rsrokd.rs:104:14 [INFO] [stderr] | [INFO] [stderr] 104 | fn dummy(req: &mut Request) -> IronResult { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/rsrokd.rs:108:25 [INFO] [stderr] | [INFO] [stderr] 108 | let foo = move |req: &mut Request| { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/rsrokd.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | let foo = move |req: &mut Request| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/rsrokd.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | let foo = move |req: &mut Request| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.16s [INFO] running `"docker" "inspect" "a5d09cfdd3ff3f3d50cca770480b848b382999f7ab6235551cb48d14992987c5"` [INFO] running `"docker" "rm" "-f" "a5d09cfdd3ff3f3d50cca770480b848b382999f7ab6235551cb48d14992987c5"` [INFO] [stdout] a5d09cfdd3ff3f3d50cca770480b848b382999f7ab6235551cb48d14992987c5