[INFO] updating cached repository swizzard/boggler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/swizzard/boggler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/swizzard/boggler" "work/ex/clippy-test-run/sources/stable/gh/swizzard/boggler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/swizzard/boggler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/swizzard/boggler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/swizzard/boggler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/swizzard/boggler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cc01442ec61024df5448d8460f06d2fcdd7e2531 [INFO] sha for GitHub repo swizzard/boggler: cc01442ec61024df5448d8460f06d2fcdd7e2531 [INFO] validating manifest of swizzard/boggler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of swizzard/boggler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing swizzard/boggler [INFO] finished frobbing swizzard/boggler [INFO] frobbed toml for swizzard/boggler written to work/ex/clippy-test-run/sources/stable/gh/swizzard/boggler/Cargo.toml [INFO] started frobbing swizzard/boggler [INFO] finished frobbing swizzard/boggler [INFO] frobbed toml for swizzard/boggler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/swizzard/boggler/Cargo.toml [INFO] crate swizzard/boggler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting swizzard/boggler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/swizzard/boggler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ca0cad072ab23f7e2c76d6e4474d17b431ad653c6f24c47a6a22d6f38cee305a [INFO] running `"docker" "start" "-a" "ca0cad072ab23f7e2c76d6e4474d17b431ad653c6f24c47a6a22d6f38cee305a"` [INFO] [stderr] Checking ascii v0.8.7 [INFO] [stderr] Checking rand v0.5.1 [INFO] [stderr] Checking boggler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `seen` [INFO] [stderr] --> src/solver.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | let mut seen: HashSet = HashSet::with_capacity(16); [INFO] [stderr] | ^^^^ help: consider using `_seen` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `adjcts` [INFO] [stderr] --> src/solver.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | let adjcts = board.adjacents(x, y); [INFO] [stderr] | ^^^^^^ help: consider using `_adjcts` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/solver.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | let mut x = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/solver.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | let mut y = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/solver.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | let mut seen: HashSet = HashSet::with_capacity(16); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `find_letter` [INFO] [stderr] --> src/solver.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | fn find_letter(&self, chr: &AsciiChar) -> Option<&BTNode> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/board.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | s.push_str(&format!("{}", c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `c.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/board.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | Err(_) => panic!("empty die"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solver::BoardSolution` [INFO] [stderr] --> src/solver.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | BoardSolution { [INFO] [stderr] 25 | | words: Vec::new(), [INFO] [stderr] 26 | | score: 0, [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/solver.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | &bt.add_word(ascii_word); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bt.add_word(ascii_word);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/solver.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | &bt.add_word(&w); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `bt.add_word(&w);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/solver.rs:132:50 [INFO] [stderr] | [INFO] [stderr] 132 | Some(ch) => self.children.entry(*ch).or_insert(BTNode::new()).insert(&mut chrs, word) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTNode::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:149:32 [INFO] [stderr] | [INFO] [stderr] 149 | fn find_letter(&self, chr: &AsciiChar) -> Option<&BTNode> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `AsciiChar` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/solver.rs:157:15 [INFO] [stderr] | [INFO] [stderr] 157 | while x < 16 && y < 16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/solver.rs:181:48 [INFO] [stderr] | [INFO] [stderr] 181 | Some(c) => self.children.entry(*c).or_insert(BTNode::new()).insert(chrs, word), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTNode::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `boggler`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `seen` [INFO] [stderr] --> src/solver.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | let mut seen: HashSet = HashSet::with_capacity(16); [INFO] [stderr] | ^^^^ help: consider using `_seen` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `adjcts` [INFO] [stderr] --> src/solver.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | let adjcts = board.adjacents(x, y); [INFO] [stderr] | ^^^^^^ help: consider using `_adjcts` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/solver.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | let mut x = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/solver.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | let mut y = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/solver.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | let mut seen: HashSet = HashSet::with_capacity(16); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/board.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | s.push_str(&format!("{}", c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `c.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/board.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | Err(_) => panic!("empty die"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solver::BoardSolution` [INFO] [stderr] --> src/solver.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | BoardSolution { [INFO] [stderr] 25 | | words: Vec::new(), [INFO] [stderr] 26 | | score: 0, [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/solver.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | &bt.add_word(ascii_word); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bt.add_word(ascii_word);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/solver.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | &bt.add_word(&w); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `bt.add_word(&w);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/solver.rs:132:50 [INFO] [stderr] | [INFO] [stderr] 132 | Some(ch) => self.children.entry(*ch).or_insert(BTNode::new()).insert(&mut chrs, word) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTNode::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:149:32 [INFO] [stderr] | [INFO] [stderr] 149 | fn find_letter(&self, chr: &AsciiChar) -> Option<&BTNode> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `AsciiChar` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/solver.rs:157:15 [INFO] [stderr] | [INFO] [stderr] 157 | while x < 16 && y < 16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/solver.rs:181:48 [INFO] [stderr] | [INFO] [stderr] 181 | Some(c) => self.children.entry(*c).or_insert(BTNode::new()).insert(chrs, word), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTNode::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `boggler`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ca0cad072ab23f7e2c76d6e4474d17b431ad653c6f24c47a6a22d6f38cee305a"` [INFO] running `"docker" "rm" "-f" "ca0cad072ab23f7e2c76d6e4474d17b431ad653c6f24c47a6a22d6f38cee305a"` [INFO] [stdout] ca0cad072ab23f7e2c76d6e4474d17b431ad653c6f24c47a6a22d6f38cee305a