[INFO] updating cached repository swaggy/advent-of-code-2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/swaggy/advent-of-code-2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/swaggy/advent-of-code-2017" "work/ex/clippy-test-run/sources/stable/gh/swaggy/advent-of-code-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/swaggy/advent-of-code-2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/swaggy/advent-of-code-2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/swaggy/advent-of-code-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/swaggy/advent-of-code-2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 39e6efc8e93955bbf600b1418e85cda33da69de1 [INFO] sha for GitHub repo swaggy/advent-of-code-2017: 39e6efc8e93955bbf600b1418e85cda33da69de1 [INFO] validating manifest of swaggy/advent-of-code-2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of swaggy/advent-of-code-2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing swaggy/advent-of-code-2017 [INFO] finished frobbing swaggy/advent-of-code-2017 [INFO] frobbed toml for swaggy/advent-of-code-2017 written to work/ex/clippy-test-run/sources/stable/gh/swaggy/advent-of-code-2017/Cargo.toml [INFO] started frobbing swaggy/advent-of-code-2017 [INFO] finished frobbing swaggy/advent-of-code-2017 [INFO] frobbed toml for swaggy/advent-of-code-2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/swaggy/advent-of-code-2017/Cargo.toml [INFO] crate swaggy/advent-of-code-2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting swaggy/advent-of-code-2017 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/swaggy/advent-of-code-2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec691865fbc1940a757d01eb124ba34832e60e57262e1d83056b8352d1b06487 [INFO] running `"docker" "start" "-a" "ec691865fbc1940a757d01eb124ba34832e60e57262e1d83056b8352d1b06487"` [INFO] [stderr] Checking either v1.4.0 [INFO] [stderr] Checking itertools v0.7.4 [INFO] [stderr] Checking advent-of-code-2017 v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_3.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return [self.x.to_string(), self.y.to_string()].join(","); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[self.x.to_string(), self.y.to_string()].join(",")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_3.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return point; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_3.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_3.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return contents.lines().map(String::from).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `contents.lines().map(String::from).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_3.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return [self.x.to_string(), self.y.to_string()].join(","); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[self.x.to_string(), self.y.to_string()].join(",")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_3.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return point; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_3.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_3.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return contents.lines().map(String::from).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `contents.lines().map(String::from).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_1.rs:11:32 [INFO] [stderr] | [INFO] [stderr] 11 | fn sum_matching_digits(digits: &Vec, distance: usize) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_2.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | fn get_checksum(number_lines: &Vec>, line_value_operator: &Fn(&Vec) -> u32) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_2.rs:26:41 [INFO] [stderr] | [INFO] [stderr] 26 | fn min_max_difference_operator(numbers: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_2.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | fn evenly_divisible_division_operator(numbers: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_3.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | for _ in 2..number + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `2..=number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_3.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | for _ in 2..number + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `2..=number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/day_3.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / match spiral.get(&point.to_string()) { [INFO] [stderr] 136 | | Some(value) => sum += value, [INFO] [stderr] 137 | | None => {}, [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(value) = spiral.get(&point.to_string()) { sum += value }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_4.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | fn is_valid(words: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_6.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | let mut memory_banks: Vec = line.split("\t").map(|n| n.parse::().unwrap()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/utils.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | let mut file = File::open(&filename).expect( [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 8 | | format!("{} not found.", &filename).as_str()); [INFO] [stderr] | |_____________________________________________________^ help: try this: `unwrap_or_else(|_| panic!("{} not found.", &filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_1.rs:11:32 [INFO] [stderr] | [INFO] [stderr] 11 | fn sum_matching_digits(digits: &Vec, distance: usize) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_2.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | fn get_checksum(number_lines: &Vec>, line_value_operator: &Fn(&Vec) -> u32) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_2.rs:26:41 [INFO] [stderr] | [INFO] [stderr] 26 | fn min_max_difference_operator(numbers: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_2.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | fn evenly_divisible_division_operator(numbers: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_3.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | for _ in 2..number + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `2..=number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/day_3.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | for _ in 2..number + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `2..=number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/day_3.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / match spiral.get(&point.to_string()) { [INFO] [stderr] 136 | | Some(value) => sum += value, [INFO] [stderr] 137 | | None => {}, [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(value) = spiral.get(&point.to_string()) { sum += value }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day_4.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | fn is_valid(words: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_6.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | let mut memory_banks: Vec = line.split("\t").map(|n| n.parse::().unwrap()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/utils.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | let mut file = File::open(&filename).expect( [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 8 | | format!("{} not found.", &filename).as_str()); [INFO] [stderr] | |_____________________________________________________^ help: try this: `unwrap_or_else(|_| panic!("{} not found.", &filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.96s [INFO] running `"docker" "inspect" "ec691865fbc1940a757d01eb124ba34832e60e57262e1d83056b8352d1b06487"` [INFO] running `"docker" "rm" "-f" "ec691865fbc1940a757d01eb124ba34832e60e57262e1d83056b8352d1b06487"` [INFO] [stdout] ec691865fbc1940a757d01eb124ba34832e60e57262e1d83056b8352d1b06487