[INFO] updating cached repository svechinsky/slope [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/svechinsky/slope [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/svechinsky/slope" "work/ex/clippy-test-run/sources/stable/gh/svechinsky/slope"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/svechinsky/slope'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/svechinsky/slope" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/svechinsky/slope"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/svechinsky/slope'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 449bc356ee0edefe594416b8b08494fe50f37158 [INFO] sha for GitHub repo svechinsky/slope: 449bc356ee0edefe594416b8b08494fe50f37158 [INFO] validating manifest of svechinsky/slope on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of svechinsky/slope on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing svechinsky/slope [INFO] finished frobbing svechinsky/slope [INFO] frobbed toml for svechinsky/slope written to work/ex/clippy-test-run/sources/stable/gh/svechinsky/slope/Cargo.toml [INFO] started frobbing svechinsky/slope [INFO] finished frobbing svechinsky/slope [INFO] frobbed toml for svechinsky/slope written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/svechinsky/slope/Cargo.toml [INFO] crate svechinsky/slope has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting svechinsky/slope against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/svechinsky/slope:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 173d2bbb81b7fc72f9f53ddb748b32e8b5f09868d8a87e8a836286d68a9b9dd9 [INFO] running `"docker" "start" "-a" "173d2bbb81b7fc72f9f53ddb748b32e8b5f09868d8a87e8a836286d68a9b9dd9"` [INFO] [stderr] Compiling lazy_static v1.0.1 [INFO] [stderr] Compiling crunchy v0.1.6 [INFO] [stderr] Compiling num_cpus v1.8.0 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking serde_json v1.0.21 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Checking tiny-keccak v1.4.2 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking slope v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction/simple_transaction.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction/simple_transaction.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction/simple_transaction.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | to: to, [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/simple_vertex.rs:26:7 [INFO] [stderr] | [INFO] [stderr] 26 | transaction: transaction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction/simple_transaction.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction/simple_transaction.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction/simple_transaction.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | to: to, [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vertex/simple_vertex.rs:26:7 [INFO] [stderr] | [INFO] [stderr] 26 | transaction: transaction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `transaction::simple_transaction::SimpleTransaction` [INFO] [stderr] --> src/conflict_set/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use transaction::simple_transaction::SimpleTransaction; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conflict_set/simple_conflict_set.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return &self.prefered_vertex; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.prefered_vertex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conflict_set/simple_conflict_set.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return &self.vertices; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state/simple_state.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return self.state.get(&key).unwrap_or(&0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.state.get(&key).unwrap_or(&0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/state/simple_state.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | const MESSAGE: &'static [u8] = b"hello, world"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state/simple_state.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:45:25 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(_res) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:46:26 [INFO] [stderr] | [INFO] [stderr] 46 | Err(_err) => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return serde_json::to_string(&self).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::to_string(&self).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | return Ok(transaction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(transaction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | return Err(TransactionError::InvalidSigner); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransactionError::InvalidSigner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / return SimpleTransaction { [INFO] [stderr] 77 | | value: value, [INFO] [stderr] 78 | | timestamp: timestamp, [INFO] [stderr] 79 | | to: to, [INFO] [stderr] 80 | | from: public_key.iter().cloned().collect(), [INFO] [stderr] 81 | | signature: sig.as_ref().iter().cloned().collect(), [INFO] [stderr] 82 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | SimpleTransaction { [INFO] [stderr] 77 | value: value, [INFO] [stderr] 78 | timestamp: timestamp, [INFO] [stderr] 79 | to: to, [INFO] [stderr] 80 | from: public_key.iter().cloned().collect(), [INFO] [stderr] 81 | signature: sig.as_ref().iter().cloned().collect(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / return Ok(HEXLOWER [INFO] [stderr] 103 | | .decode(s.as_bytes()) [INFO] [stderr] 104 | | .unwrap() [INFO] [stderr] 105 | | .iter() [INFO] [stderr] 106 | | .cloned() [INFO] [stderr] 107 | | .collect()); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 102 | Ok(HEXLOWER [INFO] [stderr] 103 | .decode(s.as_bytes()) [INFO] [stderr] 104 | .unwrap() [INFO] [stderr] 105 | .iter() [INFO] [stderr] 106 | .cloned() [INFO] [stderr] 107 | .collect()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vertex/simple_vertex.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return confidence; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `confidence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vertex/simple_vertex.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / return SimpleVertex { [INFO] [stderr] 26 | | transaction: transaction, [INFO] [stderr] 27 | | parent_vertices: parent_set, [INFO] [stderr] 28 | | child_vertices: Vec::new(), [INFO] [stderr] 29 | | chit: 1, [INFO] [stderr] 30 | | confidence: 1, [INFO] [stderr] 31 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | SimpleVertex { [INFO] [stderr] 26 | transaction: transaction, [INFO] [stderr] 27 | parent_vertices: parent_set, [INFO] [stderr] 28 | child_vertices: Vec::new(), [INFO] [stderr] 29 | chit: 1, [INFO] [stderr] 30 | confidence: 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `transaction::simple_transaction::SimpleTransaction` [INFO] [stderr] --> src/conflict_set/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use transaction::simple_transaction::SimpleTransaction; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conflict_set/simple_conflict_set.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return &self.prefered_vertex; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.prefered_vertex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/conflict_set/simple_conflict_set.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return &self.vertices; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state/simple_state.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return self.state.get(&key).unwrap_or(&0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.state.get(&key).unwrap_or(&0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/state/simple_state.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | const MESSAGE: &'static [u8] = b"hello, world"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state/simple_state.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:45:25 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(_res) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:46:26 [INFO] [stderr] | [INFO] [stderr] 46 | Err(_err) => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return serde_json::to_string(&self).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::to_string(&self).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | return Ok(transaction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(transaction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | return Err(TransactionError::InvalidSigner); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TransactionError::InvalidSigner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / return SimpleTransaction { [INFO] [stderr] 77 | | value: value, [INFO] [stderr] 78 | | timestamp: timestamp, [INFO] [stderr] 79 | | to: to, [INFO] [stderr] 80 | | from: public_key.iter().cloned().collect(), [INFO] [stderr] 81 | | signature: sig.as_ref().iter().cloned().collect(), [INFO] [stderr] 82 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | SimpleTransaction { [INFO] [stderr] 77 | value: value, [INFO] [stderr] 78 | timestamp: timestamp, [INFO] [stderr] 79 | to: to, [INFO] [stderr] 80 | from: public_key.iter().cloned().collect(), [INFO] [stderr] 81 | signature: sig.as_ref().iter().cloned().collect(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transaction/simple_transaction.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / return Ok(HEXLOWER [INFO] [stderr] 103 | | .decode(s.as_bytes()) [INFO] [stderr] 104 | | .unwrap() [INFO] [stderr] 105 | | .iter() [INFO] [stderr] 106 | | .cloned() [INFO] [stderr] 107 | | .collect()); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 102 | Ok(HEXLOWER [INFO] [stderr] 103 | .decode(s.as_bytes()) [INFO] [stderr] 104 | .unwrap() [INFO] [stderr] 105 | .iter() [INFO] [stderr] 106 | .cloned() [INFO] [stderr] 107 | .collect()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vertex/simple_vertex.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return confidence; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `confidence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vertex/simple_vertex.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / return SimpleVertex { [INFO] [stderr] 26 | | transaction: transaction, [INFO] [stderr] 27 | | parent_vertices: parent_set, [INFO] [stderr] 28 | | child_vertices: Vec::new(), [INFO] [stderr] 29 | | chit: 1, [INFO] [stderr] 30 | | confidence: 1, [INFO] [stderr] 31 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | SimpleVertex { [INFO] [stderr] 26 | transaction: transaction, [INFO] [stderr] 27 | parent_vertices: parent_set, [INFO] [stderr] 28 | child_vertices: Vec::new(), [INFO] [stderr] 29 | chit: 1, [INFO] [stderr] 30 | confidence: 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `public` [INFO] [stderr] --> src/state/simple_state.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let public = key_pair.public_key_bytes(); [INFO] [stderr] | ^^^^^^ help: consider using `_public` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sig` [INFO] [stderr] --> src/state/simple_state.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | let sig = key_pair.sign(MESSAGE); [INFO] [stderr] | ^^^ help: consider using `_sig` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `transaction` [INFO] [stderr] --> src/state/simple_state.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | fn validate(&self, transaction: &SimpleTransaction) -> bool{ [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_transaction` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `public` [INFO] [stderr] --> src/state/simple_state.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let public = key_pair.public_key_bytes(); [INFO] [stderr] | ^^^^^^ help: consider using `_public` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sig` [INFO] [stderr] --> src/state/simple_state.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | let sig = key_pair.sign(MESSAGE); [INFO] [stderr] | ^^^ help: consider using `_sig` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `transaction` [INFO] [stderr] --> src/state/simple_state.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | fn validate(&self, transaction: &SimpleTransaction) -> bool{ [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_transaction` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SimpleConflictSet` [INFO] [stderr] --> src/conflict_set/simple_conflict_set.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct SimpleConflictSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SimpleState` [INFO] [stderr] --> src/state/simple_state.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub struct SimpleState{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/state/simple_state.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new() -> SimpleState { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/transaction/simple_transaction.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | from: public_key.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/transaction/simple_transaction.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | signature: sig.as_ref().iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/transaction/simple_transaction.rs:90:34 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn serialize(address: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/transaction/simple_transaction.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let s = format!("{}", &HEXLOWER.encode(address.as_slice())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&HEXLOWER.encode(address.as_slice()).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/transaction/simple_transaction.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | return Ok(HEXLOWER [INFO] [stderr] | ___________________^ [INFO] [stderr] 103 | | .decode(s.as_bytes()) [INFO] [stderr] 104 | | .unwrap() [INFO] [stderr] 105 | | .iter() [INFO] [stderr] 106 | | .cloned() [INFO] [stderr] 107 | | .collect()); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SimpleConflictSet` [INFO] [stderr] --> src/conflict_set/simple_conflict_set.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct SimpleConflictSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SimpleState` [INFO] [stderr] --> src/state/simple_state.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub struct SimpleState{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/state/simple_state.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new() -> SimpleState { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/vertex/simple_vertex.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | let mut confidence = self.chit as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.chit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vertex/simple_vertex.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | confidence = confidence + child.calculate_confidence(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `confidence += child.calculate_confidence()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/transaction/simple_transaction.rs:80:19 [INFO] [stderr] | [INFO] [stderr] 80 | from: public_key.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/transaction/simple_transaction.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | signature: sig.as_ref().iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/transaction/simple_transaction.rs:90:34 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn serialize(address: &Vec, serializer: S) -> Result [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/transaction/simple_transaction.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let s = format!("{}", &HEXLOWER.encode(address.as_slice())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&HEXLOWER.encode(address.as_slice()).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/transaction/simple_transaction.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | return Ok(HEXLOWER [INFO] [stderr] | ___________________^ [INFO] [stderr] 103 | | .decode(s.as_bytes()) [INFO] [stderr] 104 | | .unwrap() [INFO] [stderr] 105 | | .iter() [INFO] [stderr] 106 | | .cloned() [INFO] [stderr] 107 | | .collect()); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/vertex/simple_vertex.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | let mut confidence = self.chit as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.chit)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vertex/simple_vertex.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | confidence = confidence + child.calculate_confidence(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `confidence += child.calculate_confidence()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.53s [INFO] running `"docker" "inspect" "173d2bbb81b7fc72f9f53ddb748b32e8b5f09868d8a87e8a836286d68a9b9dd9"` [INFO] running `"docker" "rm" "-f" "173d2bbb81b7fc72f9f53ddb748b32e8b5f09868d8a87e8a836286d68a9b9dd9"` [INFO] [stdout] 173d2bbb81b7fc72f9f53ddb748b32e8b5f09868d8a87e8a836286d68a9b9dd9