[INFO] updating cached repository svarogg/rustynum [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/svarogg/rustynum [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/svarogg/rustynum" "work/ex/clippy-test-run/sources/stable/gh/svarogg/rustynum"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/svarogg/rustynum'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/svarogg/rustynum" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/svarogg/rustynum"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/svarogg/rustynum'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3c6e44a7f670dfa993e51c34a9ad9c74fadf42c3 [INFO] sha for GitHub repo svarogg/rustynum: 3c6e44a7f670dfa993e51c34a9ad9c74fadf42c3 [INFO] validating manifest of svarogg/rustynum on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of svarogg/rustynum on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing svarogg/rustynum [INFO] finished frobbing svarogg/rustynum [INFO] frobbed toml for svarogg/rustynum written to work/ex/clippy-test-run/sources/stable/gh/svarogg/rustynum/Cargo.toml [INFO] started frobbing svarogg/rustynum [INFO] finished frobbing svarogg/rustynum [INFO] frobbed toml for svarogg/rustynum written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/svarogg/rustynum/Cargo.toml [INFO] crate svarogg/rustynum has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting svarogg/rustynum against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/svarogg/rustynum:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 73fbe8f1ebdde90f352646488a0695e320aae599e28fe76d45d97d50c2870391 [INFO] running `"docker" "start" "-a" "73fbe8f1ebdde90f352646488a0695e320aae599e28fe76d45d97d50c2870391"` [INFO] [stderr] Checking rustynum v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tripletizer.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | Tripletizer { n: n } [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tripletizer.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | Tripletizer { n: n } [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logic.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZES: &'static [&'static str] = &["", " thousand", " million", " billion", " trillion"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logic.rs:3:25 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZES: &'static [&'static str] = &["", " thousand", " million", " billion", " trillion"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logic.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return String::from(if n < 0 { "minus " } else { "" }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(if n < 0 { "minus " } else { "" })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/logic.rs:109:34 [INFO] [stderr] | [INFO] [stderr] 109 | num_to_string(1355823)); [INFO] [stderr] | ^^^^^^^ help: consider: `1_355_823` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/logic.rs:111:49 [INFO] [stderr] | [INFO] [stderr] 111 | assert_eq!("one million", num_to_string(1000000)); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/logic.rs:112:63 [INFO] [stderr] | [INFO] [stderr] 112 | assert_eq!("one million, one thousand", num_to_string(1001000)); [INFO] [stderr] | ^^^^^^^ help: consider: `1_001_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/logic.rs:114:35 [INFO] [stderr] | [INFO] [stderr] 114 | num_to_string(-1355823)); [INFO] [stderr] | ^^^^^^^ help: consider: `1_355_823` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/logic.rs:116:34 [INFO] [stderr] | [INFO] [stderr] 116 | num_to_string(2147483647)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logic.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZES: &'static [&'static str] = &["", " thousand", " million", " billion", " trillion"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logic.rs:3:25 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZES: &'static [&'static str] = &["", " thousand", " million", " billion", " trillion"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logic.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return String::from(if n < 0 { "minus " } else { "" }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(if n < 0 { "minus " } else { "" })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/logic.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | parse_atomic(n).unwrap_or(parse_non_atomic(n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| parse_non_atomic(n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/logic.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | n = n % 100; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `n %= 100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/logic.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | parse_atomic(n).unwrap_or(parse_non_atomic(n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| parse_non_atomic(n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/logic.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | n = n % 100; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `n %= 100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "73fbe8f1ebdde90f352646488a0695e320aae599e28fe76d45d97d50c2870391"` [INFO] running `"docker" "rm" "-f" "73fbe8f1ebdde90f352646488a0695e320aae599e28fe76d45d97d50c2870391"` [INFO] [stdout] 73fbe8f1ebdde90f352646488a0695e320aae599e28fe76d45d97d50c2870391