[INFO] updating cached repository sureshsundriyal/dff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sureshsundriyal/dff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sureshsundriyal/dff" "work/ex/clippy-test-run/sources/stable/gh/sureshsundriyal/dff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sureshsundriyal/dff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sureshsundriyal/dff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sureshsundriyal/dff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sureshsundriyal/dff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 88002c3f54e44c53e0e474ddbf96f8e3077ad2c9 [INFO] sha for GitHub repo sureshsundriyal/dff: 88002c3f54e44c53e0e474ddbf96f8e3077ad2c9 [INFO] validating manifest of sureshsundriyal/dff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sureshsundriyal/dff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sureshsundriyal/dff [INFO] finished frobbing sureshsundriyal/dff [INFO] frobbed toml for sureshsundriyal/dff written to work/ex/clippy-test-run/sources/stable/gh/sureshsundriyal/dff/Cargo.toml [INFO] started frobbing sureshsundriyal/dff [INFO] finished frobbing sureshsundriyal/dff [INFO] frobbed toml for sureshsundriyal/dff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sureshsundriyal/dff/Cargo.toml [INFO] crate sureshsundriyal/dff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sureshsundriyal/dff against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sureshsundriyal/dff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] efd3f8a853f251190d6bd250c81b681ee37492450adc207b6629345619759832 [INFO] running `"docker" "start" "-a" "efd3f8a853f251190d6bd250c81b681ee37492450adc207b6629345619759832"` [INFO] [stderr] Checking libc v0.2.31 [INFO] [stderr] Checking serde v1.0.15 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking serde_json v1.0.3 [INFO] [stderr] Checking dff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:77:10 [INFO] [stderr] | [INFO] [stderr] 77 | vec: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | if let Ok(_) = file.read_to_end(&mut contents) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 87 | | hasher.write(&contents[..]); [INFO] [stderr] 88 | | hash = hasher.finish(); [INFO] [stderr] 89 | | } else { [INFO] [stderr] 90 | | warn!("Failed to read {}", file_entry); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________________- help: try this: `if file.read_to_end(&mut contents).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | files: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:145:12 [INFO] [stderr] | [INFO] [stderr] 145 | files: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:150:20 [INFO] [stderr] | [INFO] [stderr] 150 | if let Ok(_) = file.read_to_end(&mut contents) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 151 | | content_map [INFO] [stderr] 152 | | .entry(contents) [INFO] [stderr] 153 | | .or_insert_with(Vec::new) [INFO] [stderr] ... | [INFO] [stderr] 156 | | warn!("Failed to read {}", file_name); [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____________- help: try this: `if file.read_to_end(&mut contents).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:77:10 [INFO] [stderr] | [INFO] [stderr] 77 | vec: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | if let Ok(_) = file.read_to_end(&mut contents) { [INFO] [stderr] | _________________- ^^^^^ [INFO] [stderr] 87 | | hasher.write(&contents[..]); [INFO] [stderr] 88 | | hash = hasher.finish(); [INFO] [stderr] 89 | | } else { [INFO] [stderr] 90 | | warn!("Failed to read {}", file_entry); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________________- help: try this: `if file.read_to_end(&mut contents).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | files: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:145:12 [INFO] [stderr] | [INFO] [stderr] 145 | files: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:150:20 [INFO] [stderr] | [INFO] [stderr] 150 | if let Ok(_) = file.read_to_end(&mut contents) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 151 | | content_map [INFO] [stderr] 152 | | .entry(contents) [INFO] [stderr] 153 | | .or_insert_with(Vec::new) [INFO] [stderr] ... | [INFO] [stderr] 156 | | warn!("Failed to read {}", file_name); [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____________- help: try this: `if file.read_to_end(&mut contents).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.71s [INFO] running `"docker" "inspect" "efd3f8a853f251190d6bd250c81b681ee37492450adc207b6629345619759832"` [INFO] running `"docker" "rm" "-f" "efd3f8a853f251190d6bd250c81b681ee37492450adc207b6629345619759832"` [INFO] [stdout] efd3f8a853f251190d6bd250c81b681ee37492450adc207b6629345619759832