[INFO] updating cached repository superdump/partyarty [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/superdump/partyarty [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/superdump/partyarty" "work/ex/clippy-test-run/sources/stable/gh/superdump/partyarty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/superdump/partyarty'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/superdump/partyarty" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/superdump/partyarty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/superdump/partyarty'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2f8306d8601a0456ca8bc2ffe4caf9d654a94d61 [INFO] sha for GitHub repo superdump/partyarty: 2f8306d8601a0456ca8bc2ffe4caf9d654a94d61 [INFO] validating manifest of superdump/partyarty on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of superdump/partyarty on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing superdump/partyarty [INFO] finished frobbing superdump/partyarty [INFO] frobbed toml for superdump/partyarty written to work/ex/clippy-test-run/sources/stable/gh/superdump/partyarty/Cargo.toml [INFO] started frobbing superdump/partyarty [INFO] finished frobbing superdump/partyarty [INFO] frobbed toml for superdump/partyarty written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/superdump/partyarty/Cargo.toml [INFO] crate superdump/partyarty has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting superdump/partyarty against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/superdump/partyarty:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98c807f925076e7f1df6068a34dbe1b85f9bb7fc3ad1c7fe4a6d750a9789bae9 [INFO] running `"docker" "start" "-a" "98c807f925076e7f1df6068a34dbe1b85f9bb7fc3ad1c7fe4a6d750a9789bae9"` [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Compiling shred-derive v0.5.0 [INFO] [stderr] Compiling syn v0.15.13 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking shred v0.7.0 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling derivative v1.0.1 [INFO] [stderr] Compiling synstructure v0.10.0 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking specs v0.12.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking partyarty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | let c = oc.magnitude2() - h.radius * h.radius; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:45:25 [INFO] [stderr] | [INFO] [stderr] 45 | let p = r.at_t(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | let p = r.at_t(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/systems.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | let (a, r, g, b) = (pixel_color.0 / sample_count.0).as_argb8888(); [INFO] [stderr] | ^ [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | let c = oc.magnitude2() - h.radius * h.radius; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/systems.rs:157:28 [INFO] [stderr] | [INFO] [stderr] 157 | let (a, r, g, b) = (pixel_color.0 / sample_count.0).as_argb8888(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/systems.rs:157:31 [INFO] [stderr] | [INFO] [stderr] 157 | let (a, r, g, b) = (pixel_color.0 / sample_count.0).as_argb8888(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:45:25 [INFO] [stderr] | [INFO] [stderr] 45 | let p = r.at_t(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | let p = r.at_t(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/systems.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | let (a, r, g, b) = (pixel_color.0 / sample_count.0).as_argb8888(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/systems.rs:157:28 [INFO] [stderr] | [INFO] [stderr] 157 | let (a, r, g, b) = (pixel_color.0 / sample_count.0).as_argb8888(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/systems.rs:157:31 [INFO] [stderr] | [INFO] [stderr] 157 | let (a, r, g, b) = (pixel_color.0 / sample_count.0).as_argb8888(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:111:10 [INFO] [stderr] | [INFO] [stderr] 111 | ((color.a as u32) << 24) | ((color.r as u32) << 16) | ((color.g as u32) << 8) | (color.b as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(color.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:111:37 [INFO] [stderr] | [INFO] [stderr] 111 | ((color.a as u32) << 24) | ((color.r as u32) << 16) | ((color.g as u32) << 8) | (color.b as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(color.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:111:64 [INFO] [stderr] | [INFO] [stderr] 111 | ((color.a as u32) << 24) | ((color.r as u32) << 16) | ((color.g as u32) << 8) | (color.b as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(color.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:111:89 [INFO] [stderr] | [INFO] [stderr] 111 | ((color.a as u32) << 24) | ((color.r as u32) << 16) | ((color.g as u32) << 8) | (color.b as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(color.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:111:10 [INFO] [stderr] | [INFO] [stderr] 111 | ((color.a as u32) << 24) | ((color.r as u32) << 16) | ((color.g as u32) << 8) | (color.b as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(color.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:111:37 [INFO] [stderr] | [INFO] [stderr] 111 | ((color.a as u32) << 24) | ((color.r as u32) << 16) | ((color.g as u32) << 8) | (color.b as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(color.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:111:64 [INFO] [stderr] | [INFO] [stderr] 111 | ((color.a as u32) << 24) | ((color.r as u32) << 16) | ((color.g as u32) << 8) | (color.b as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(color.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:111:89 [INFO] [stderr] | [INFO] [stderr] 111 | ((color.a as u32) << 24) | ((color.r as u32) << 16) | ((color.g as u32) << 8) | (color.b as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(color.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/systems.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | rec.material = Some(material.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*material` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/systems.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | return (attenuation * color(&scattered, position, hitable, material, depth + 1)).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(attenuation * color(&scattered, position, hitable, material, depth + 1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 61 | | ReadStorage<'a, PixelPosition>, [INFO] [stderr] 62 | | Read<'a, Camera>, [INFO] [stderr] 63 | | Read<'a, Width>, [INFO] [stderr] ... | [INFO] [stderr] 74 | | Write<'a, PerfTimers>, [INFO] [stderr] 75 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i * 4` [INFO] [stderr] --> src/systems.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | buffer[i * 4 + 0] = r; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:179:23 [INFO] [stderr] | [INFO] [stderr] 179 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 180 | | Read<'a, ImageFilePrefix>, [INFO] [stderr] 181 | | Read<'a, Width>, [INFO] [stderr] 182 | | Read<'a, Height>, [INFO] [stderr] ... | [INFO] [stderr] 186 | | Write<'a, PerfTimers>, [INFO] [stderr] 187 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/systems.rs:205:59 [INFO] [stderr] | [INFO] [stderr] 205 | if samples < 1 || frame_count > samples as u32 || prefix.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prefix.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/systems.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | rec.material = Some(material.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*material` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/systems.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | return (attenuation * color(&scattered, position, hitable, material, depth + 1)).into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(attenuation * color(&scattered, position, hitable, material, depth + 1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 61 | | ReadStorage<'a, PixelPosition>, [INFO] [stderr] 62 | | Read<'a, Camera>, [INFO] [stderr] 63 | | Read<'a, Width>, [INFO] [stderr] ... | [INFO] [stderr] 74 | | Write<'a, PerfTimers>, [INFO] [stderr] 75 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/timers.rs:75:40 [INFO] [stderr] | [INFO] [stderr] 75 | (d.as_secs() as f64 * 1_000f64) + (d.subsec_nanos() as f64 / 1_000_000f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i * 4` [INFO] [stderr] --> src/systems.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | buffer[i * 4 + 0] = r; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:179:23 [INFO] [stderr] | [INFO] [stderr] 179 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 180 | | Read<'a, ImageFilePrefix>, [INFO] [stderr] 181 | | Read<'a, Width>, [INFO] [stderr] 182 | | Read<'a, Height>, [INFO] [stderr] ... | [INFO] [stderr] 186 | | Write<'a, PerfTimers>, [INFO] [stderr] 187 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/timers.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | self.timers.insert(name.clone(), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 106 | self.timers.insert(&(*name).clone(), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 106 | self.timers.insert(&str::clone(name), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/systems.rs:205:59 [INFO] [stderr] | [INFO] [stderr] 205 | if samples < 1 || frame_count > samples as u32 || prefix.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prefix.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/timers.rs:120:36 [INFO] [stderr] | [INFO] [stderr] 120 | self.timers.insert(name.clone(), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 120 | self.timers.insert(&(*name).clone(), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 120 | self.timers.insert(&str::clone(name), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/timers.rs:75:40 [INFO] [stderr] | [INFO] [stderr] 75 | (d.as_secs() as f64 * 1_000f64) + (d.subsec_nanos() as f64 / 1_000_000f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/timers.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | self.timers.insert(name.clone(), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 106 | self.timers.insert(&(*name).clone(), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 106 | self.timers.insert(&str::clone(name), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/timers.rs:120:36 [INFO] [stderr] | [INFO] [stderr] 120 | self.timers.insert(name.clone(), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 120 | self.timers.insert(&(*name).clone(), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 120 | self.timers.insert(&str::clone(name), Timer::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `partyarty`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `partyarty`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "98c807f925076e7f1df6068a34dbe1b85f9bb7fc3ad1c7fe4a6d750a9789bae9"` [INFO] running `"docker" "rm" "-f" "98c807f925076e7f1df6068a34dbe1b85f9bb7fc3ad1c7fe4a6d750a9789bae9"` [INFO] [stdout] 98c807f925076e7f1df6068a34dbe1b85f9bb7fc3ad1c7fe4a6d750a9789bae9