[INFO] updating cached repository supercrabtree/dtls [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/supercrabtree/dtls [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/supercrabtree/dtls" "work/ex/clippy-test-run/sources/stable/gh/supercrabtree/dtls"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/supercrabtree/dtls'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/supercrabtree/dtls" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/supercrabtree/dtls"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/supercrabtree/dtls'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ed34387418d18ab9df700e995911fd61a4196ff0 [INFO] sha for GitHub repo supercrabtree/dtls: ed34387418d18ab9df700e995911fd61a4196ff0 [INFO] validating manifest of supercrabtree/dtls on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of supercrabtree/dtls on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing supercrabtree/dtls [INFO] finished frobbing supercrabtree/dtls [INFO] frobbed toml for supercrabtree/dtls written to work/ex/clippy-test-run/sources/stable/gh/supercrabtree/dtls/Cargo.toml [INFO] started frobbing supercrabtree/dtls [INFO] finished frobbing supercrabtree/dtls [INFO] frobbed toml for supercrabtree/dtls written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/supercrabtree/dtls/Cargo.toml [INFO] crate supercrabtree/dtls has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting supercrabtree/dtls against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/supercrabtree/dtls:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd7cb0c097ac0f07c66187574bdc0f2695d184a12dff798dbaa47fcee567f82b [INFO] running `"docker" "start" "-a" "fd7cb0c097ac0f07c66187574bdc0f2695d184a12dff798dbaa47fcee567f82b"` [INFO] [stderr] Checking dtls v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / let mut directory = "."; [INFO] [stderr] 17 | | if args.len() == 2 { [INFO] [stderr] 18 | | directory = &args[1]; [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let directory = if args.len() == 2 { &args[1] } else { "." };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:55:26 [INFO] [stderr] | [INFO] [stderr] 55 | let mode_as_string = String::from(format!("{:o}", mode)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{:o}", mode)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / let mut directory = "."; [INFO] [stderr] 17 | | if args.len() == 2 { [INFO] [stderr] 18 | | directory = &args[1]; [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let directory = if args.len() == 2 { &args[1] } else { "." };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:55:26 [INFO] [stderr] | [INFO] [stderr] 55 | let mode_as_string = String::from(format!("{:o}", mode)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{:o}", mode)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "fd7cb0c097ac0f07c66187574bdc0f2695d184a12dff798dbaa47fcee567f82b"` [INFO] running `"docker" "rm" "-f" "fd7cb0c097ac0f07c66187574bdc0f2695d184a12dff798dbaa47fcee567f82b"` [INFO] [stdout] fd7cb0c097ac0f07c66187574bdc0f2695d184a12dff798dbaa47fcee567f82b