[INFO] updating cached repository sunjay/sudoku [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sunjay/sudoku [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sunjay/sudoku" "work/ex/clippy-test-run/sources/stable/gh/sunjay/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sunjay/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sunjay/sudoku" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sunjay/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sunjay/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 88a3f9c77bd288b52fa7ea0e6604768bdfd7730b [INFO] sha for GitHub repo sunjay/sudoku: 88a3f9c77bd288b52fa7ea0e6604768bdfd7730b [INFO] validating manifest of sunjay/sudoku on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sunjay/sudoku on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sunjay/sudoku [INFO] finished frobbing sunjay/sudoku [INFO] frobbed toml for sunjay/sudoku written to work/ex/clippy-test-run/sources/stable/gh/sunjay/sudoku/Cargo.toml [INFO] started frobbing sunjay/sudoku [INFO] finished frobbing sunjay/sudoku [INFO] frobbed toml for sunjay/sudoku written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sunjay/sudoku/Cargo.toml [INFO] crate sunjay/sudoku has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sunjay/sudoku against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sunjay/sudoku:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 75527236261b22d6693c0ea6b5608e1debabf759fe45f50566e06d6862b983bb [INFO] running `"docker" "start" "-a" "75527236261b22d6693c0ea6b5608e1debabf759fe45f50566e06d6862b983bb"` [INFO] [stderr] Compiling proc-macro2 v0.4.15 [INFO] [stderr] Compiling version_check v0.1.4 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Compiling cc v1.0.23 [INFO] [stderr] Compiling ryu v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling serde v1.0.75 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling regex v1.0.4 [INFO] [stderr] Checking ucd-util v0.1.1 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking utf8-ranges v1.0.1 [INFO] [stderr] Checking itoa v0.4.2 [INFO] [stderr] Checking byteorder v1.2.6 [INFO] [stderr] Checking rustc-demangle v0.1.9 [INFO] [stderr] Checking cfg-if v0.1.5 [INFO] [stderr] Compiling pest v1.0.6 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking thread-scoped v1.0.2 [INFO] [stderr] Checking same-file v1.0.3 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking sudoku v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking memchr v2.0.2 [INFO] [stderr] warning: the loop variable `col_i` is only used to index `buffer`. [INFO] [stderr] --> src/sudoku.rs:152:26 [INFO] [stderr] | [INFO] [stderr] 152 | for col_i in 0..BOARD_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 152 | for in buffer.iter().take(BOARD_SIZE) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/sudoku.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | NonZeroU8::new(value - b'0').map(|value| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 157 | || board.place(Pos {row: row_i, col: col_i}, value); [INFO] [stderr] 158 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(value) = NonZeroU8::new(value - b'0') { board.place(Pos {row: row_i, col: col_i}, value); }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `possible_values` [INFO] [stderr] --> src/sudoku.rs:246:18 [INFO] [stderr] | [INFO] [stderr] 246 | for i in 0..BOARD_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 246 | for (i, ) in possible_values.iter().enumerate().take(BOARD_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking regex-syntax v0.6.2 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Checking log v0.4.4 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking walkdir v2.2.5 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking criterion-plot v0.2.5 [INFO] [stderr] Checking itertools-num v0.1.2 [INFO] [stderr] Checking criterion-stats v0.2.5 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling pest_derive v1.0.8 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking simplelog v0.5.2 [INFO] [stderr] Checking serde_json v1.0.26 [INFO] [stderr] Checking csv v1.0.1 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.75 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking criterion v0.2.5 [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> tests/timer.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | let nanos = elapsed.as_secs() as u128 * 1_000_000_000 + elapsed.subsec_nanos() as u128; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(elapsed.as_secs())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u128 may become silently lossy if types change [INFO] [stderr] --> tests/timer.rs:27:65 [INFO] [stderr] | [INFO] [stderr] 27 | let nanos = elapsed.as_secs() as u128 * 1_000_000_000 + elapsed.subsec_nanos() as u128; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `col_i` is only used to index `buffer`. [INFO] [stderr] --> src/sudoku.rs:152:26 [INFO] [stderr] | [INFO] [stderr] 152 | for col_i in 0..BOARD_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 152 | for in buffer.iter().take(BOARD_SIZE) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/sudoku.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | NonZeroU8::new(value - b'0').map(|value| { [INFO] [stderr] | _____________________^ [INFO] [stderr] | |_____________________| [INFO] [stderr] | || [INFO] [stderr] 157 | || board.place(Pos {row: row_i, col: col_i}, value); [INFO] [stderr] 158 | || }); [INFO] [stderr] | ||______________________^- help: try this: `if let Some(value) = NonZeroU8::new(value - b'0') { board.place(Pos {row: row_i, col: col_i}, value); }` [INFO] [stderr] | |_______________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `possible_values` [INFO] [stderr] --> src/sudoku.rs:246:18 [INFO] [stderr] | [INFO] [stderr] 246 | for i in 0..BOARD_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 246 | for (i, ) in possible_values.iter().enumerate().take(BOARD_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 3m 11s [INFO] running `"docker" "inspect" "75527236261b22d6693c0ea6b5608e1debabf759fe45f50566e06d6862b983bb"` [INFO] running `"docker" "rm" "-f" "75527236261b22d6693c0ea6b5608e1debabf759fe45f50566e06d6862b983bb"` [INFO] [stdout] 75527236261b22d6693c0ea6b5608e1debabf759fe45f50566e06d6862b983bb