[INFO] updating cached repository sumproxy/tetris [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sumproxy/tetris [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sumproxy/tetris" "work/ex/clippy-test-run/sources/stable/gh/sumproxy/tetris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sumproxy/tetris'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sumproxy/tetris" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sumproxy/tetris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sumproxy/tetris'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e1e578547747ad811d70df1a2d4332a3bfc127e2 [INFO] sha for GitHub repo sumproxy/tetris: e1e578547747ad811d70df1a2d4332a3bfc127e2 [INFO] validating manifest of sumproxy/tetris on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sumproxy/tetris on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sumproxy/tetris [INFO] finished frobbing sumproxy/tetris [INFO] frobbed toml for sumproxy/tetris written to work/ex/clippy-test-run/sources/stable/gh/sumproxy/tetris/Cargo.toml [INFO] started frobbing sumproxy/tetris [INFO] finished frobbing sumproxy/tetris [INFO] frobbed toml for sumproxy/tetris written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sumproxy/tetris/Cargo.toml [INFO] crate sumproxy/tetris has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sumproxy/tetris against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sumproxy/tetris:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f27b697cca1a72979c59863eb508201f521b6cbc7a5fcc1e6140f5e8aa3fe74f [INFO] running `"docker" "start" "-a" "f27b697cca1a72979c59863eb508201f521b6cbc7a5fcc1e6140f5e8aa3fe74f"` [INFO] [stderr] Compiling libc v0.2.20 [INFO] [stderr] Compiling siphasher v0.2.1 [INFO] [stderr] Compiling serde v0.8.23 [INFO] [stderr] Checking num-traits v0.1.36 [INFO] [stderr] Compiling gcc v0.3.43 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Compiling x11-dl v2.12.0 [INFO] [stderr] Compiling wayland-scanner v0.7.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking gfx_core v0.6.0 [INFO] [stderr] Compiling phf_shared v0.7.21 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling glutin v0.7.4 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Compiling phf v0.7.21 [INFO] [stderr] Checking num-integer v0.1.32 [INFO] [stderr] Checking num-complex v0.1.35 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling cmake v0.1.20 [INFO] [stderr] Checking tempfile v2.1.5 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling wayland-client v0.7.7 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking num-iter v0.1.32 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling glfw-sys v3.2.1 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Compiling serde_json v0.8.6 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking glfw v0.12.0 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.7 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking winit v0.5.10 [INFO] [stderr] Checking gfx_device_gl v0.13.0 [INFO] [stderr] Checking gfx v0.14.0 [INFO] [stderr] Checking gfx_window_glfw v0.13.0 [INFO] [stderr] Checking gfx_window_glutin v0.14.0 [INFO] [stderr] Checking gfx_app v0.4.0 [INFO] [stderr] Checking tetris v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/queue.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | Queue { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/map.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/map.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/map.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:190:28 [INFO] [stderr] | [INFO] [stderr] 190 | let pos = Pos {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:190:34 [INFO] [stderr] | [INFO] [stderr] 190 | let pos = Pos {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:203:28 [INFO] [stderr] | [INFO] [stderr] 203 | let pos = Pos {x: x, y: 0}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:210:45 [INFO] [stderr] | [INFO] [stderr] 210 | let (old_pos, new_pos) = (Pos { x: x, y: y-1 }, Pos { x: x, y: y }); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:210:67 [INFO] [stderr] | [INFO] [stderr] 210 | let (old_pos, new_pos) = (Pos { x: x, y: y-1 }, Pos { x: x, y: y }); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:210:73 [INFO] [stderr] | [INFO] [stderr] 210 | let (old_pos, new_pos) = (Pos { x: x, y: y-1 }, Pos { x: x, y: y }); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/queue.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | Queue { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/map.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/map.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/map.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:190:28 [INFO] [stderr] | [INFO] [stderr] 190 | let pos = Pos {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:190:34 [INFO] [stderr] | [INFO] [stderr] 190 | let pos = Pos {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:203:28 [INFO] [stderr] | [INFO] [stderr] 203 | let pos = Pos {x: x, y: 0}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:210:45 [INFO] [stderr] | [INFO] [stderr] 210 | let (old_pos, new_pos) = (Pos { x: x, y: y-1 }, Pos { x: x, y: y }); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:210:67 [INFO] [stderr] | [INFO] [stderr] 210 | let (old_pos, new_pos) = (Pos { x: x, y: y-1 }, Pos { x: x, y: y }); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state/mod.rs:210:73 [INFO] [stderr] | [INFO] [stderr] 210 | let (old_pos, new_pos) = (Pos { x: x, y: y-1 }, Pos { x: x, y: y }); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: reference to uninitialized memory [INFO] [stderr] --> src/app.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / gfx_defines!{ [INFO] [stderr] 12 | | vertex Vertex { [INFO] [stderr] 13 | | pos: [f32; 2] = "pos", [INFO] [stderr] 14 | | } [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::invalid_ref)] on by default [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: reference to uninitialized memory [INFO] [stderr] --> src/app.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / gfx_defines!{ [INFO] [stderr] 12 | | vertex Vertex { [INFO] [stderr] 13 | | pos: [f32; 2] = "pos", [INFO] [stderr] 14 | | } [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::invalid_ref)] on by default [INFO] [stderr] = help: Creation of a null reference is undefined behavior; see https://doc.rust-lang.org/reference/behavior-considered-undefined.html [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_ref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state/template.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let mut piece = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state/template.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | let mut piece = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/state/timer.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn is_up(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state/template.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let mut piece = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state/template.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | let mut piece = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state/mod.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | let piece = self.piece.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.piece` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/state/timer.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn is_up(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state/mod.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | let mut piece = piece.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*piece` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/state/mod.rs:146:12 [INFO] [stderr] | [INFO] [stderr] 146 | if filled_rows.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!filled_rows.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state/mod.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | let piece = self.piece.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.piece` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state/mod.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | let mut piece = piece.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*piece` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/state/mod.rs:199:20 [INFO] [stderr] | [INFO] [stderr] 199 | for row in (1..y+1).rev() { [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/state/mod.rs:146:12 [INFO] [stderr] | [INFO] [stderr] 146 | if filled_rows.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!filled_rows.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/state/mod.rs:199:20 [INFO] [stderr] | [INFO] [stderr] 199 | for row in (1..y+1).rev() { [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tetris`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `tetris`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f27b697cca1a72979c59863eb508201f521b6cbc7a5fcc1e6140f5e8aa3fe74f"` [INFO] running `"docker" "rm" "-f" "f27b697cca1a72979c59863eb508201f521b6cbc7a5fcc1e6140f5e8aa3fe74f"` [INFO] [stdout] f27b697cca1a72979c59863eb508201f521b6cbc7a5fcc1e6140f5e8aa3fe74f