[INFO] updating cached repository suharshan/pgclir [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/suharshan/pgclir [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/suharshan/pgclir" "work/ex/clippy-test-run/sources/stable/gh/suharshan/pgclir"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/suharshan/pgclir'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/suharshan/pgclir" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/suharshan/pgclir"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/suharshan/pgclir'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3f1a50e7782c3f7acd18ecc7671ec4dac837bf2e [INFO] sha for GitHub repo suharshan/pgclir: 3f1a50e7782c3f7acd18ecc7671ec4dac837bf2e [INFO] validating manifest of suharshan/pgclir on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of suharshan/pgclir on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing suharshan/pgclir [INFO] finished frobbing suharshan/pgclir [INFO] frobbed toml for suharshan/pgclir written to work/ex/clippy-test-run/sources/stable/gh/suharshan/pgclir/Cargo.toml [INFO] started frobbing suharshan/pgclir [INFO] finished frobbing suharshan/pgclir [INFO] frobbed toml for suharshan/pgclir written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/suharshan/pgclir/Cargo.toml [INFO] crate suharshan/pgclir has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting suharshan/pgclir against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/suharshan/pgclir:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a0601781a4a148409ffe0e6b2a9085557bf618d5e47ab14f5baf0650b87b1747 [INFO] running `"docker" "start" "-a" "a0601781a4a148409ffe0e6b2a9085557bf618d5e47ab14f5baf0650b87b1747"` [INFO] [stderr] Compiling typenum v1.5.2 [INFO] [stderr] Checking odds v0.2.25 [INFO] [stderr] Checking byte-tools v0.1.3 [INFO] [stderr] Checking md5 v0.3.5 [INFO] [stderr] Checking fallible-iterator v0.1.3 [INFO] [stderr] Checking term v0.4.6 [INFO] [stderr] Checking rprompt v1.0.3 [INFO] [stderr] Checking encode_unicode v0.3.1 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Checking rpassword v1.0.2 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking nodrop v0.1.9 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking generic-array v0.7.2 [INFO] [stderr] Checking crypto-mac v0.3.0 [INFO] [stderr] Checking digest v0.5.2 [INFO] [stderr] Checking digest-buffer v0.3.1 [INFO] [stderr] Checking hmac v0.1.1 [INFO] [stderr] Checking sha2 v0.5.3 [INFO] [stderr] Checking postgres-protocol v0.3.0 [INFO] [stderr] Checking postgres-shared v0.4.0 [INFO] [stderr] Checking postgres v0.15.1 [INFO] [stderr] Checking r2d2_postgres v0.13.0 [INFO] [stderr] Checking pgclir v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: value assigned to `passwd` is never read [INFO] [stderr] --> src/main.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | let mut passwd = String::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sql` [INFO] [stderr] --> src/main.rs:146:7 [INFO] [stderr] | [INFO] [stderr] 146 | let sql = &conn.execute("create database $1 owner $2", &[&dbname,&owner]); [INFO] [stderr] | ^^^ help: consider using `_sql` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `params` is never read [INFO] [stderr] --> src/main.rs:225:11 [INFO] [stderr] | [INFO] [stderr] 225 | let mut params: Vec = Vec::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | io::stdin().read_line(&mut host); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | io::stdin().read_line(&mut database); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | io::stdin().read_line(&mut port); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:45:3 [INFO] [stderr] | [INFO] [stderr] 45 | io::stdin().read_line(&mut username); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:62:63 [INFO] [stderr] | [INFO] [stderr] 62 | fn list_databases(conn :&PostgresPooledConnection, operation: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:82:59 [INFO] [stderr] | [INFO] [stderr] 82 | fn list_users(conn :&PostgresPooledConnection, operation: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:108:64 [INFO] [stderr] | [INFO] [stderr] 108 | fn list_activities(conn :&PostgresPooledConnection, operation: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:130:64 [INFO] [stderr] | [INFO] [stderr] 130 | fn create_database(conn :&PostgresPooledConnection, operation: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:149:60 [INFO] [stderr] | [INFO] [stderr] 149 | fn create_user(conn :&PostgresPooledConnection, operation: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:165:3 [INFO] [stderr] | [INFO] [stderr] 165 | &conn.execute("CREATE ROLE $1 PASSWORD $2", &[&username,&passwd]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `conn.execute("CREATE ROLE $1 PASSWORD $2", &[&username,&passwd]);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `passwd` is never read [INFO] [stderr] --> src/main.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | let mut passwd = String::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sql` [INFO] [stderr] --> src/main.rs:146:7 [INFO] [stderr] | [INFO] [stderr] 146 | let sql = &conn.execute("create database $1 owner $2", &[&dbname,&owner]); [INFO] [stderr] | ^^^ help: consider using `_sql` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `params` is never read [INFO] [stderr] --> src/main.rs:225:11 [INFO] [stderr] | [INFO] [stderr] 225 | let mut params: Vec = Vec::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | io::stdin().read_line(&mut host); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | io::stdin().read_line(&mut database); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:3 [INFO] [stderr] | [INFO] [stderr] 39 | io::stdin().read_line(&mut port); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:45:3 [INFO] [stderr] | [INFO] [stderr] 45 | io::stdin().read_line(&mut username); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:62:63 [INFO] [stderr] | [INFO] [stderr] 62 | fn list_databases(conn :&PostgresPooledConnection, operation: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:82:59 [INFO] [stderr] | [INFO] [stderr] 82 | fn list_users(conn :&PostgresPooledConnection, operation: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:108:64 [INFO] [stderr] | [INFO] [stderr] 108 | fn list_activities(conn :&PostgresPooledConnection, operation: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:130:64 [INFO] [stderr] | [INFO] [stderr] 130 | fn create_database(conn :&PostgresPooledConnection, operation: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:149:60 [INFO] [stderr] | [INFO] [stderr] 149 | fn create_user(conn :&PostgresPooledConnection, operation: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:165:3 [INFO] [stderr] | [INFO] [stderr] 165 | &conn.execute("CREATE ROLE $1 PASSWORD $2", &[&username,&passwd]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `conn.execute("CREATE ROLE $1 PASSWORD $2", &[&username,&passwd]);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.44s [INFO] running `"docker" "inspect" "a0601781a4a148409ffe0e6b2a9085557bf618d5e47ab14f5baf0650b87b1747"` [INFO] running `"docker" "rm" "-f" "a0601781a4a148409ffe0e6b2a9085557bf618d5e47ab14f5baf0650b87b1747"` [INFO] [stdout] a0601781a4a148409ffe0e6b2a9085557bf618d5e47ab14f5baf0650b87b1747