[INFO] updating cached repository subu-cliqz/n64rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/subu-cliqz/n64rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/subu-cliqz/n64rust" "work/ex/clippy-test-run/sources/stable/gh/subu-cliqz/n64rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/subu-cliqz/n64rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/subu-cliqz/n64rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subu-cliqz/n64rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subu-cliqz/n64rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 22bb8e8e0100b6ab476dfccebaaa292cbfc166ce [INFO] sha for GitHub repo subu-cliqz/n64rust: 22bb8e8e0100b6ab476dfccebaaa292cbfc166ce [INFO] validating manifest of subu-cliqz/n64rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of subu-cliqz/n64rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing subu-cliqz/n64rust [INFO] finished frobbing subu-cliqz/n64rust [INFO] frobbed toml for subu-cliqz/n64rust written to work/ex/clippy-test-run/sources/stable/gh/subu-cliqz/n64rust/Cargo.toml [INFO] started frobbing subu-cliqz/n64rust [INFO] finished frobbing subu-cliqz/n64rust [INFO] frobbed toml for subu-cliqz/n64rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subu-cliqz/n64rust/Cargo.toml [INFO] crate subu-cliqz/n64rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting subu-cliqz/n64rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/subu-cliqz/n64rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0689b9279d2dd49823d44318697da1300f8bd501ab21728bdd7918d773ff644b [INFO] running `"docker" "start" "-a" "0689b9279d2dd49823d44318697da1300f8bd501ab21728bdd7918d773ff644b"` [INFO] [stderr] Checking n64rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | interconnect: interconnect [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interconnect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interconnect.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | pif_rom: pif_rom [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pif_rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | interconnect: interconnect [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interconnect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interconnect.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | pif_rom: pif_rom [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pif_rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | let opcode = (instruction >> 26) & 0b111111; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:66:4 [INFO] [stderr] | [INFO] [stderr] 66 | 0b001111 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `cpu::Cpu` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use cpu::Cpu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | let opcode = (instruction >> 26) & 0b111111; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:66:4 [INFO] [stderr] | [INFO] [stderr] 66 | 0b001111 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `cpu::Cpu` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use cpu::Cpu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom` [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let rom = read_bin(rom_file_name); [INFO] [stderr] | ^^^ help: consider using `_rom` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom` [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let rom = read_bin(rom_file_name); [INFO] [stderr] | ^^^ help: consider using `_rom` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `run` [INFO] [stderr] --> src/cpu.rs:49:2 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn run(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DxxDxx` [INFO] [stderr] --> src/cpu.rs:101:2 [INFO] [stderr] | [INFO] [stderr] 101 | DxxDxx, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RFU` [INFO] [stderr] --> src/cpu.rs:102:2 [INFO] [stderr] | [INFO] [stderr] 102 | RFU [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LittteEndian` [INFO] [stderr] --> src/cpu.rs:113:2 [INFO] [stderr] | [INFO] [stderr] 113 | LittteEndian, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `run` [INFO] [stderr] --> src/n64.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn run(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIF_ROM_SIZE` [INFO] [stderr] --> src/interconnect.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const PIF_ROM_SIZE: usize = 2048; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ram` [INFO] [stderr] --> src/interconnect.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | ram: Vec [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:71:37 [INFO] [stderr] | [INFO] [stderr] 71 | self.write_reg_gpr(rt as usize, (imm << 16) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(imm << 16)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | ((self.pif_rom[(rel_addr + 0) as usize] as u32) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pif_rom[(rel_addr + 0) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `rel_addr` [INFO] [stderr] --> src/interconnect.rs:25:19 [INFO] [stderr] | [INFO] [stderr] 25 | ((self.pif_rom[(rel_addr + 0) as usize] as u32) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | ((self.pif_rom[(rel_addr + 1) as usize] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pif_rom[(rel_addr + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | ((self.pif_rom[(rel_addr + 2) as usize] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pif_rom[(rel_addr + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.pif_rom[(rel_addr + 3) as usize] as u32)` [INFO] [stderr] --> src/interconnect.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | ((self.pif_rom[(rel_addr + 3) as usize] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | ((self.pif_rom[(rel_addr + 3) as usize] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pif_rom[(rel_addr + 3) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method is never used: `run` [INFO] [stderr] --> src/cpu.rs:49:2 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn run(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DxxDxx` [INFO] [stderr] --> src/cpu.rs:101:2 [INFO] [stderr] | [INFO] [stderr] 101 | DxxDxx, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RFU` [INFO] [stderr] --> src/cpu.rs:102:2 [INFO] [stderr] | [INFO] [stderr] 102 | RFU [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LittteEndian` [INFO] [stderr] --> src/cpu.rs:113:2 [INFO] [stderr] | [INFO] [stderr] 113 | LittteEndian, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `run` [INFO] [stderr] --> src/n64.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn run(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIF_ROM_SIZE` [INFO] [stderr] --> src/interconnect.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const PIF_ROM_SIZE: usize = 2048; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ram` [INFO] [stderr] --> src/interconnect.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | ram: Vec [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:71:37 [INFO] [stderr] | [INFO] [stderr] 71 | self.write_reg_gpr(rt as usize, (imm << 16) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(imm << 16)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | ((self.pif_rom[(rel_addr + 0) as usize] as u32) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pif_rom[(rel_addr + 0) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `rel_addr` [INFO] [stderr] --> src/interconnect.rs:25:19 [INFO] [stderr] | [INFO] [stderr] 25 | ((self.pif_rom[(rel_addr + 0) as usize] as u32) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | ((self.pif_rom[(rel_addr + 1) as usize] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pif_rom[(rel_addr + 1) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | ((self.pif_rom[(rel_addr + 2) as usize] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pif_rom[(rel_addr + 2) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(self.pif_rom[(rel_addr + 3) as usize] as u32)` [INFO] [stderr] --> src/interconnect.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | ((self.pif_rom[(rel_addr + 3) as usize] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/interconnect.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | ((self.pif_rom[(rel_addr + 3) as usize] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.pif_rom[(rel_addr + 3) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "0689b9279d2dd49823d44318697da1300f8bd501ab21728bdd7918d773ff644b"` [INFO] running `"docker" "rm" "-f" "0689b9279d2dd49823d44318697da1300f8bd501ab21728bdd7918d773ff644b"` [INFO] [stdout] 0689b9279d2dd49823d44318697da1300f8bd501ab21728bdd7918d773ff644b