[INFO] updating cached repository subgraph/sgmenu [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/subgraph/sgmenu [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/subgraph/sgmenu" "work/ex/clippy-test-run/sources/stable/gh/subgraph/sgmenu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/subgraph/sgmenu'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/subgraph/sgmenu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subgraph/sgmenu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subgraph/sgmenu'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 00a379f414095946a5ccad177d609df8f8cf05cc [INFO] sha for GitHub repo subgraph/sgmenu: 00a379f414095946a5ccad177d609df8f8cf05cc [INFO] validating manifest of subgraph/sgmenu on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of subgraph/sgmenu on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing subgraph/sgmenu [INFO] finished frobbing subgraph/sgmenu [INFO] frobbed toml for subgraph/sgmenu written to work/ex/clippy-test-run/sources/stable/gh/subgraph/sgmenu/Cargo.toml [INFO] started frobbing subgraph/sgmenu [INFO] finished frobbing subgraph/sgmenu [INFO] frobbed toml for subgraph/sgmenu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subgraph/sgmenu/Cargo.toml [INFO] crate subgraph/sgmenu has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting subgraph/sgmenu against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/subgraph/sgmenu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f297f774726a9722b427050ec068cc2fdf1dc814f40a41c3d05a17cb86e1b4b [INFO] running `"docker" "start" "-a" "9f297f774726a9722b427050ec068cc2fdf1dc814f40a41c3d05a17cb86e1b4b"` [INFO] [stderr] Compiling gdk-pixbuf v0.3.0 [INFO] [stderr] Compiling cairo-rs v0.3.0 [INFO] [stderr] Compiling gio v0.3.0 [INFO] [stderr] Checking c_vec v1.2.1 [INFO] [stderr] Compiling gdk v0.7.0 [INFO] [stderr] Compiling glib-sys v0.5.0 [INFO] [stderr] Compiling gobject-sys v0.5.0 [INFO] [stderr] Compiling gio-sys v0.5.0 [INFO] [stderr] Compiling pango-sys v0.5.0 [INFO] [stderr] Compiling cairo-sys-rs v0.5.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.5.0 [INFO] [stderr] Compiling gdk-sys v0.5.0 [INFO] [stderr] Checking atty v0.2.8 [INFO] [stderr] Checking errno v0.1.8 [INFO] [stderr] Checking regex v0.2.7 [INFO] [stderr] Checking pty v0.2.2 [INFO] [stderr] Checking env_logger v0.5.5 [INFO] [stderr] Checking glib v0.4.1 [INFO] [stderr] Checking pango v0.3.0 [INFO] [stderr] Checking sgmenu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return apps [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `apps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return apps [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `apps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return apps [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `apps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return app_names.join("\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `app_names.join("\n")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return args [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return codes.contains(arg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `codes.contains(arg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return args.into_iter().filter(|arg| !self.is_field_code(arg)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `args.into_iter().filter(|arg| !self.is_field_code(arg)).collect::>()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | const DEFAULT_DMENU_COMMAND: &'static str = "rofi -dmenu -i -normal-window -theme Pop-Dark -p '> '"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | const EXEC_PREFIX: &'static str = "/usr/bin/realms"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return apps [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `apps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return apps [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `apps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return apps [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `apps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return app_names.join("\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `app_names.join("\n")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return args [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return codes.contains(arg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `codes.contains(arg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return args.into_iter().filter(|arg| !self.is_field_code(arg)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `args.into_iter().filter(|arg| !self.is_field_code(arg)).collect::>()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/launcher.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | const DEFAULT_DMENU_COMMAND: &'static str = "rofi -dmenu -i -normal-window -theme Pop-Dark -p '> '"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | const EXEC_PREFIX: &'static str = "/usr/bin/realms"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/launcher.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | let app_names = apps.keys().map(|v| v.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `apps.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/launcher.rs:89:12 [INFO] [stderr] | [INFO] [stderr] 89 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/launcher.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / if let Some(mut master) = fork.is_parent().ok() { [INFO] [stderr] 104 | | let mut output = String::new(); [INFO] [stderr] 105 | | match master.read_to_string(&mut output) { [INFO] [stderr] 106 | | Ok(_nread) => info!("Child output: {}", output.trim()), [INFO] [stderr] ... | [INFO] [stderr] 110 | | self.launch(cmd); [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut master)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/launcher.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | let app_names = apps.keys().map(|v| v.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `apps.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/launcher.rs:89:12 [INFO] [stderr] | [INFO] [stderr] 89 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/launcher.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / if let Some(mut master) = fork.is_parent().ok() { [INFO] [stderr] 104 | | let mut output = String::new(); [INFO] [stderr] 105 | | match master.read_to_string(&mut output) { [INFO] [stderr] 106 | | Ok(_nread) => info!("Child output: {}", output.trim()), [INFO] [stderr] ... | [INFO] [stderr] 110 | | self.launch(cmd); [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut master)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.75s [INFO] running `"docker" "inspect" "9f297f774726a9722b427050ec068cc2fdf1dc814f40a41c3d05a17cb86e1b4b"` [INFO] running `"docker" "rm" "-f" "9f297f774726a9722b427050ec068cc2fdf1dc814f40a41c3d05a17cb86e1b4b"` [INFO] [stdout] 9f297f774726a9722b427050ec068cc2fdf1dc814f40a41c3d05a17cb86e1b4b