[INFO] updating cached repository subgraph/desktopd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/subgraph/desktopd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/subgraph/desktopd" "work/ex/clippy-test-run/sources/stable/gh/subgraph/desktopd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/subgraph/desktopd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/subgraph/desktopd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subgraph/desktopd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subgraph/desktopd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 62837261f8f80c102c9f093398aa7f60b55e64df [INFO] sha for GitHub repo subgraph/desktopd: 62837261f8f80c102c9f093398aa7f60b55e64df [INFO] validating manifest of subgraph/desktopd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of subgraph/desktopd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing subgraph/desktopd [INFO] finished frobbing subgraph/desktopd [INFO] frobbed toml for subgraph/desktopd written to work/ex/clippy-test-run/sources/stable/gh/subgraph/desktopd/Cargo.toml [INFO] started frobbing subgraph/desktopd [INFO] finished frobbing subgraph/desktopd [INFO] frobbed toml for subgraph/desktopd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subgraph/desktopd/Cargo.toml [INFO] crate subgraph/desktopd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting subgraph/desktopd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/subgraph/desktopd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91357b9c87ed7bb5e02c1af84a65c40661f60da272d62b2f9b9cdb0fb6370492 [INFO] running `"docker" "start" "-a" "91357b9c87ed7bb5e02c1af84a65c40661f60da272d62b2f9b9cdb0fb6370492"` [INFO] [stderr] Checking termcolor v0.3.3 [INFO] [stderr] Checking inotify-sys v0.1.2 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking inotify v0.5.0 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Checking env_logger v0.5.3 [INFO] [stderr] Checking desktopd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:155:24 [INFO] [stderr] | [INFO] [stderr] 155 | const DESKTOP_ACTION: &'static str = "Desktop Action "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | return Some(Line::GroupHeader(content.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Line::GroupHeader(content.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/monitor.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 160 | | if is_create { [INFO] [stderr] 161 | | handler.file_added(path)?; [INFO] [stderr] 162 | | } else { [INFO] [stderr] 163 | | handler.file_removed(path)?; [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if is_create { [INFO] [stderr] 160 | handler.file_added(path)?; [INFO] [stderr] 161 | } else { [INFO] [stderr] 162 | handler.file_removed(path)?; [INFO] [stderr] 163 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser.rs:155:24 [INFO] [stderr] | [INFO] [stderr] 155 | const DESKTOP_ACTION: &'static str = "Desktop Action "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | return Some(Line::GroupHeader(content.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Line::GroupHeader(content.to_string()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/monitor.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 160 | | if is_create { [INFO] [stderr] 161 | | handler.file_added(path)?; [INFO] [stderr] 162 | | } else { [INFO] [stderr] 163 | | handler.file_removed(path)?; [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if is_create { [INFO] [stderr] 160 | handler.file_added(path)?; [INFO] [stderr] 161 | } else { [INFO] [stderr] 162 | handler.file_removed(path)?; [INFO] [stderr] 163 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/desktop.rs:129:61 [INFO] [stderr] | [INFO] [stderr] 129 | let map = self.groups.entry(action.to_string()).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:111:49 [INFO] [stderr] | [INFO] [stderr] 111 | for s in value.split_terminator(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:209:49 [INFO] [stderr] | [INFO] [stderr] 209 | let parts: Vec<&str> = self.s.splitn(2, "=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:215:26 [INFO] [stderr] | [INFO] [stderr] 215 | if !key.contains("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:225:28 [INFO] [stderr] | [INFO] [stderr] 225 | let idx = key.find("[").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | .ok_or(format_err!("missing '[options]' section")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("missing '[options]' section"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/monitor.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / loop { [INFO] [stderr] 127 | | match self.read_events(&mut buffer)? { [INFO] [stderr] 128 | | Some(events) => self.process_events(events), [INFO] [stderr] 129 | | None => break, [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(events) = self.read_events(&mut buffer)? { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/monitor.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | .ok_or(format_err!("inotify event received without a filename"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("inotify event received without a filename"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/monitor.rs:139:14 [INFO] [stderr] | [INFO] [stderr] 139 | .ok_or(format_err!("Failed to find descriptor for received inotify event"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Failed to find descriptor for received inotify event"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/desktop.rs:129:61 [INFO] [stderr] | [INFO] [stderr] 129 | let map = self.groups.entry(action.to_string()).or_insert(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashMap::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:111:49 [INFO] [stderr] | [INFO] [stderr] 111 | for s in value.split_terminator(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:209:49 [INFO] [stderr] | [INFO] [stderr] 209 | let parts: Vec<&str> = self.s.splitn(2, "=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:215:26 [INFO] [stderr] | [INFO] [stderr] 215 | if !key.contains("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:225:28 [INFO] [stderr] | [INFO] [stderr] 225 | let idx = key.find("[").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | .ok_or(format_err!("missing '[options]' section")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("missing '[options]' section"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/monitor.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / loop { [INFO] [stderr] 127 | | match self.read_events(&mut buffer)? { [INFO] [stderr] 128 | | Some(events) => self.process_events(events), [INFO] [stderr] 129 | | None => break, [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(events) = self.read_events(&mut buffer)? { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/monitor.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | .ok_or(format_err!("inotify event received without a filename"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("inotify event received without a filename"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/monitor.rs:139:14 [INFO] [stderr] | [INFO] [stderr] 139 | .ok_or(format_err!("Failed to find descriptor for received inotify event"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Failed to find descriptor for received inotify event"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.87s [INFO] running `"docker" "inspect" "91357b9c87ed7bb5e02c1af84a65c40661f60da272d62b2f9b9cdb0fb6370492"` [INFO] running `"docker" "rm" "-f" "91357b9c87ed7bb5e02c1af84a65c40661f60da272d62b2f9b9cdb0fb6370492"` [INFO] [stdout] 91357b9c87ed7bb5e02c1af84a65c40661f60da272d62b2f9b9cdb0fb6370492