[INFO] updating cached repository subcomponent/subcomponent [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/subcomponent/subcomponent [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/subcomponent/subcomponent" "work/ex/clippy-test-run/sources/stable/gh/subcomponent/subcomponent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/subcomponent/subcomponent'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/subcomponent/subcomponent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subcomponent/subcomponent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subcomponent/subcomponent'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c2bc977a648f872e5eaf45e8ccbf55f0ec167233 [INFO] sha for GitHub repo subcomponent/subcomponent: c2bc977a648f872e5eaf45e8ccbf55f0ec167233 [INFO] validating manifest of subcomponent/subcomponent on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of subcomponent/subcomponent on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing subcomponent/subcomponent [INFO] finished frobbing subcomponent/subcomponent [INFO] frobbed toml for subcomponent/subcomponent written to work/ex/clippy-test-run/sources/stable/gh/subcomponent/subcomponent/Cargo.toml [INFO] started frobbing subcomponent/subcomponent [INFO] finished frobbing subcomponent/subcomponent [INFO] frobbed toml for subcomponent/subcomponent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/subcomponent/subcomponent/Cargo.toml [INFO] crate subcomponent/subcomponent has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting subcomponent/subcomponent against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/subcomponent/subcomponent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3196c12c630c808fe5fee718a0345caff0c29639efc51e8aa15c2f3819d7d393 [INFO] running `"docker" "start" "-a" "3196c12c630c808fe5fee718a0345caff0c29639efc51e8aa15c2f3819d7d393"` [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Checking tempdir v0.3.5 [INFO] [stderr] Checking term v0.4.4 [INFO] [stderr] Checking subcomponent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | tty: tty, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | dependencies: dependencies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependencies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | hooks: hooks, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hooks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hook.rs:44:10 [INFO] [stderr] | [INFO] [stderr] 44 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hook.rs:45:10 [INFO] [stderr] | [INFO] [stderr] 45 | exec: exec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `exec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hook.rs:46:10 [INFO] [stderr] | [INFO] [stderr] 46 | cwd: cwd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hook.rs:47:10 [INFO] [stderr] | [INFO] [stderr] 47 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | tty: tty, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | dependencies: dependencies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependencies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | hooks: hooks, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hooks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hook.rs:44:10 [INFO] [stderr] | [INFO] [stderr] 44 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hook.rs:45:10 [INFO] [stderr] | [INFO] [stderr] 45 | exec: exec, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `exec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hook.rs:46:10 [INFO] [stderr] | [INFO] [stderr] 46 | cwd: cwd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hook.rs:47:10 [INFO] [stderr] | [INFO] [stderr] 47 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/lexer.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/common.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | const SUB_DIR: &'static str = "subcomponent"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/common.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | const SUB_FILE: &'static str = "components.sub"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:51:48 [INFO] [stderr] | [INFO] [stderr] 51 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:239:48 [INFO] [stderr] | [INFO] [stderr] 239 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmd/template.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | const PROLOG: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmd/template.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | const TEMPLATE: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmd/fetch.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | const PROLOG: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmd/status.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | const PROLOG: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/status.rs:41:47 [INFO] [stderr] | [INFO] [stderr] 41 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/status.rs:54:47 [INFO] [stderr] | [INFO] [stderr] 54 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/status.rs:69:47 [INFO] [stderr] | [INFO] [stderr] 69 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/mod.rs:93:51 [INFO] [stderr] | [INFO] [stderr] 93 | #[cfg_attr(feature = "cargo-clippy", allow(match_same_arms))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/mod.rs:266:44 [INFO] [stderr] | [INFO] [stderr] 266 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/compiler/parser.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | / if tok_right == &LexemeKind::ListSeparator { [INFO] [stderr] 305 | | if self.token_value_check(tok_left) { [INFO] [stderr] 306 | | return true; [INFO] [stderr] 307 | | } [INFO] [stderr] 308 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 304 | if tok_right == &LexemeKind::ListSeparator && self.token_value_check(tok_left) { [INFO] [stderr] 305 | return true; [INFO] [stderr] 306 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 328 | let seq = [tok!(0)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 328 | let seq = [tok!(0)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 389 | if (seq == comp) && self.token_value_check(tok!(2)) { [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 389 | if (seq == comp) && self.token_value_check(tok!(2)) { [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 395 | let seq = [tok!(0), tok!(1)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 395 | let seq = [tok!(0), tok!(1)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 395 | let seq = [tok!(0), tok!(1)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 395 | let seq = [tok!(0), tok!(1)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/fetcher/git.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | const METHOD_NAME: &'static str = "git"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/fetcher/git.rs:745:5 [INFO] [stderr] | [INFO] [stderr] 745 | / if git_version.major <= 2 && git_version.minor < 9 { [INFO] [stderr] 746 | | if shallow_submodules { [INFO] [stderr] 747 | | warn!("Shallow submodules are enabled for component {}, but the \ [INFO] [stderr] 748 | | git version you are using ({}) has no support for them.", [INFO] [stderr] ... | [INFO] [stderr] 751 | | } [INFO] [stderr] 752 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 745 | if git_version.major <= 2 && git_version.minor < 9 && shallow_submodules { [INFO] [stderr] 746 | warn!("Shallow submodules are enabled for component {}, but the \ [INFO] [stderr] 747 | git version you are using ({}) has no support for them.", [INFO] [stderr] 748 | component, git_version); [INFO] [stderr] 749 | shallow_submodules = false; [INFO] [stderr] 750 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/fetcher/artifact.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | const METHOD_NAME: &'static str = "artifact"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | const PROLOG: &'static str = "Usage: [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:51:48 [INFO] [stderr] | [INFO] [stderr] 51 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/common.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | const SUB_DIR: &'static str = "subcomponent"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/common.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | const SUB_FILE: &'static str = "components.sub"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:51:48 [INFO] [stderr] | [INFO] [stderr] 51 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:239:48 [INFO] [stderr] | [INFO] [stderr] 239 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmd/template.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | const PROLOG: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmd/template.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | const TEMPLATE: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmd/fetch.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | const PROLOG: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmd/status.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | const PROLOG: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/status.rs:41:47 [INFO] [stderr] | [INFO] [stderr] 41 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/status.rs:54:47 [INFO] [stderr] | [INFO] [stderr] 54 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/status.rs:69:47 [INFO] [stderr] | [INFO] [stderr] 69 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/mod.rs:93:51 [INFO] [stderr] | [INFO] [stderr] 93 | #[cfg_attr(feature = "cargo-clippy", allow(match_same_arms))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/mod.rs:266:44 [INFO] [stderr] | [INFO] [stderr] 266 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/compiler/parser.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | / if tok_right == &LexemeKind::ListSeparator { [INFO] [stderr] 305 | | if self.token_value_check(tok_left) { [INFO] [stderr] 306 | | return true; [INFO] [stderr] 307 | | } [INFO] [stderr] 308 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 304 | if tok_right == &LexemeKind::ListSeparator && self.token_value_check(tok_left) { [INFO] [stderr] 305 | return true; [INFO] [stderr] 306 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 328 | let seq = [tok!(0)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 328 | let seq = [tok!(0)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 351 | let seq_pre = [tok!(0), tok!(1), tok!(2), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 384 | let seq = [tok!(0), tok!(1), tok!(3)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 389 | if (seq == comp) && self.token_value_check(tok!(2)) { [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 389 | if (seq == comp) && self.token_value_check(tok!(2)) { [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 395 | let seq = [tok!(0), tok!(1)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 395 | let seq = [tok!(0), tok!(1)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/compiler/parser.rs:318:17 [INFO] [stderr] | [INFO] [stderr] 318 | kind [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 395 | let seq = [tok!(0), tok!(1)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/compiler/parser.rs:317:28 [INFO] [stderr] | [INFO] [stderr] 317 | let kind = tokens[$x].kind_get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 395 | let seq = [tok!(0), tok!(1)]; [INFO] [stderr] | ------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/fetcher/git.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | const METHOD_NAME: &'static str = "git"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/fetcher/git.rs:745:5 [INFO] [stderr] | [INFO] [stderr] 745 | / if git_version.major <= 2 && git_version.minor < 9 { [INFO] [stderr] 746 | | if shallow_submodules { [INFO] [stderr] 747 | | warn!("Shallow submodules are enabled for component {}, but the \ [INFO] [stderr] 748 | | git version you are using ({}) has no support for them.", [INFO] [stderr] ... | [INFO] [stderr] 751 | | } [INFO] [stderr] 752 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 745 | if git_version.major <= 2 && git_version.minor < 9 && shallow_submodules { [INFO] [stderr] 746 | warn!("Shallow submodules are enabled for component {}, but the \ [INFO] [stderr] 747 | git version you are using ({}) has no support for them.", [INFO] [stderr] 748 | component, git_version); [INFO] [stderr] 749 | shallow_submodules = false; [INFO] [stderr] 750 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/fetcher/artifact.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | const METHOD_NAME: &'static str = "artifact"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | const PROLOG: &'static str = "Usage: [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `borrowed_box` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/config.rs:51:48 [INFO] [stderr] | [INFO] [stderr] 51 | #[cfg_attr(feature = "cargo-clippy", allow(borrowed_box))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::borrowed_box` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `dependencies` [INFO] [stderr] --> src/config.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | dependencies: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/config.rs:75:42 [INFO] [stderr] | [INFO] [stderr] 75 | let subkey = &visit_key[0..index_increment+index+1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=index_increment+index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/compiler/parser.rs:481:24 [INFO] [stderr] | [INFO] [stderr] 481 | if pkey.chars().last().unwrap() == '/' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `pkey.ends_with('/')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: field is never used: `dependencies` [INFO] [stderr] --> src/config.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | dependencies: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/config.rs:75:42 [INFO] [stderr] | [INFO] [stderr] 75 | let subkey = &visit_key[0..index_increment+index+1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=index_increment+index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/compiler/parser.rs:481:24 [INFO] [stderr] | [INFO] [stderr] 481 | if pkey.chars().last().unwrap() == '/' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `pkey.ends_with('/')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.94s [INFO] running `"docker" "inspect" "3196c12c630c808fe5fee718a0345caff0c29639efc51e8aa15c2f3819d7d393"` [INFO] running `"docker" "rm" "-f" "3196c12c630c808fe5fee718a0345caff0c29639efc51e8aa15c2f3819d7d393"` [INFO] [stdout] 3196c12c630c808fe5fee718a0345caff0c29639efc51e8aa15c2f3819d7d393