[INFO] updating cached repository stumoss/chromecastise [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stumoss/chromecastise [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stumoss/chromecastise" "work/ex/clippy-test-run/sources/stable/gh/stumoss/chromecastise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stumoss/chromecastise'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stumoss/chromecastise" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stumoss/chromecastise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stumoss/chromecastise'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] de522b0a5f8d349f403bb27e852904e8224eed36 [INFO] sha for GitHub repo stumoss/chromecastise: de522b0a5f8d349f403bb27e852904e8224eed36 [INFO] validating manifest of stumoss/chromecastise on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stumoss/chromecastise on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stumoss/chromecastise [INFO] finished frobbing stumoss/chromecastise [INFO] frobbed toml for stumoss/chromecastise written to work/ex/clippy-test-run/sources/stable/gh/stumoss/chromecastise/Cargo.toml [INFO] started frobbing stumoss/chromecastise [INFO] finished frobbing stumoss/chromecastise [INFO] frobbed toml for stumoss/chromecastise written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stumoss/chromecastise/Cargo.toml [INFO] crate stumoss/chromecastise has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting stumoss/chromecastise against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stumoss/chromecastise:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 570168c5cfc6680c5d2e3f2b2f8a2180382f727ef67b700cf5cae122cc4a8800 [INFO] running `"docker" "start" "-a" "570168c5cfc6680c5d2e3f2b2f8a2180382f727ef67b700cf5cae122cc4a8800"` [INFO] [stderr] Checking chromecastise v1.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | const KNOWN_FILE_EXTENSIONS: [&'static str; 12] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:24:33 [INFO] [stderr] | [INFO] [stderr] 24 | const SUPPORTED_VIDEO_CODECS: [&'static str; 1] = ["AVC"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | const SUPPORTED_AUDIO_CODECS: [&'static str; 1] = ["AAC"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | const DEFAULT_VIDEO_CODEC: &'static str = "libx264"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | const DEFAULT_AUDIO_CODEC: &'static str = "aac"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | const KNOWN_FILE_EXTENSIONS: [&'static str; 12] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:24:33 [INFO] [stderr] | [INFO] [stderr] 24 | const SUPPORTED_VIDEO_CODECS: [&'static str; 1] = ["AVC"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | const SUPPORTED_AUDIO_CODECS: [&'static str; 1] = ["AAC"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | const DEFAULT_VIDEO_CODEC: &'static str = "libx264"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | const DEFAULT_AUDIO_CODEC: &'static str = "aac"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / let mut container_format = "mp4"; [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | if matches.is_present("mkv") { [INFO] [stderr] 36 | | container_format = "mkv"; [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let container_format = if matches.is_present("mkv") { "mkv" } else { "mp4" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / let mut container_format = "mp4"; [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | if matches.is_present("mkv") { [INFO] [stderr] 36 | | container_format = "mkv"; [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let container_format = if matches.is_present("mkv") { "mkv" } else { "mp4" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "570168c5cfc6680c5d2e3f2b2f8a2180382f727ef67b700cf5cae122cc4a8800"` [INFO] running `"docker" "rm" "-f" "570168c5cfc6680c5d2e3f2b2f8a2180382f727ef67b700cf5cae122cc4a8800"` [INFO] [stdout] 570168c5cfc6680c5d2e3f2b2f8a2180382f727ef67b700cf5cae122cc4a8800