[INFO] updating cached repository studio-lucia/msl_script_tools [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/studio-lucia/msl_script_tools [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/studio-lucia/msl_script_tools" "work/ex/clippy-test-run/sources/stable/gh/studio-lucia/msl_script_tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/studio-lucia/msl_script_tools'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/studio-lucia/msl_script_tools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/msl_script_tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/msl_script_tools'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 184412ca7e29565123db479fbdbcf6d428311f53 [INFO] sha for GitHub repo studio-lucia/msl_script_tools: 184412ca7e29565123db479fbdbcf6d428311f53 [INFO] validating manifest of studio-lucia/msl_script_tools on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of studio-lucia/msl_script_tools on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing studio-lucia/msl_script_tools [INFO] finished frobbing studio-lucia/msl_script_tools [INFO] frobbed toml for studio-lucia/msl_script_tools written to work/ex/clippy-test-run/sources/stable/gh/studio-lucia/msl_script_tools/Cargo.toml [INFO] started frobbing studio-lucia/msl_script_tools [INFO] finished frobbing studio-lucia/msl_script_tools [INFO] frobbed toml for studio-lucia/msl_script_tools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/msl_script_tools/Cargo.toml [INFO] crate studio-lucia/msl_script_tools has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting studio-lucia/msl_script_tools against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/studio-lucia/msl_script_tools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b32ddbf592d116acaf6b2c130f15432e6865a514664af2c9557bb74b4daa8a7c [INFO] running `"docker" "start" "-a" "b32ddbf592d116acaf6b2c130f15432e6865a514664af2c9557bb74b4daa8a7c"` [INFO] [stderr] Checking either v1.1.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking encoding_rs v0.6.11 [INFO] [stderr] Checking textwrap v0.6.0 [INFO] [stderr] Checking itertools v0.6.1 [INFO] [stderr] Checking csv-core v0.1.2 [INFO] [stderr] Checking clap v2.25.1 [INFO] [stderr] Checking csv v1.0.0-beta.3 [INFO] [stderr] Checking fldtools v0.1.1 [INFO] [stderr] Checking msl_script_tools v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | unknown1: unknown1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `unknown1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | dialogue_header_offset: dialogue_header_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dialogue_header_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | unknown2: unknown2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `unknown2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | number_of_dialogue_entries: number_of_dialogue_entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_dialogue_entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | dialogue_offset_table_offset: dialogue_offset_table_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dialogue_offset_table_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | offsets: offsets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `offsets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | unknown1: unknown1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `unknown1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | dialogue_header_offset: dialogue_header_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dialogue_header_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | unknown2: unknown2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `unknown2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | number_of_dialogue_entries: number_of_dialogue_entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_dialogue_entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | dialogue_offset_table_offset: dialogue_offset_table_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dialogue_offset_table_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | offsets: offsets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `offsets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / return Ok(MapTable { [INFO] [stderr] 46 | | unknown1: unknown1, [INFO] [stderr] 47 | | dialogue_header_offset: dialogue_header_offset, [INFO] [stderr] 48 | | unknown2: unknown2, [INFO] [stderr] 49 | | number_of_dialogue_entries: number_of_dialogue_entries, [INFO] [stderr] 50 | | dialogue_offset_table_offset: dialogue_offset_table_offset, [INFO] [stderr] 51 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | Ok(MapTable { [INFO] [stderr] 46 | unknown1: unknown1, [INFO] [stderr] 47 | dialogue_header_offset: dialogue_header_offset, [INFO] [stderr] 48 | unknown2: unknown2, [INFO] [stderr] 49 | number_of_dialogue_entries: number_of_dialogue_entries, [INFO] [stderr] 50 | dialogue_offset_table_offset: dialogue_offset_table_offset, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / return Ok(DialogueOffsetTable { [INFO] [stderr] 72 | | offsets: offsets, [INFO] [stderr] 73 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | Ok(DialogueOffsetTable { [INFO] [stderr] 72 | offsets: offsets, [INFO] [stderr] 73 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return Ok(dialogue); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(dialogue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / return Ok(MapTable { [INFO] [stderr] 46 | | unknown1: unknown1, [INFO] [stderr] 47 | | dialogue_header_offset: dialogue_header_offset, [INFO] [stderr] 48 | | unknown2: unknown2, [INFO] [stderr] 49 | | number_of_dialogue_entries: number_of_dialogue_entries, [INFO] [stderr] 50 | | dialogue_offset_table_offset: dialogue_offset_table_offset, [INFO] [stderr] 51 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | Ok(MapTable { [INFO] [stderr] 46 | unknown1: unknown1, [INFO] [stderr] 47 | dialogue_header_offset: dialogue_header_offset, [INFO] [stderr] 48 | unknown2: unknown2, [INFO] [stderr] 49 | number_of_dialogue_entries: number_of_dialogue_entries, [INFO] [stderr] 50 | dialogue_offset_table_offset: dialogue_offset_table_offset, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / return Ok(DialogueOffsetTable { [INFO] [stderr] 72 | | offsets: offsets, [INFO] [stderr] 73 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | Ok(DialogueOffsetTable { [INFO] [stderr] 72 | offsets: offsets, [INFO] [stderr] 73 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return Ok(dialogue); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(dialogue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / match byte { [INFO] [stderr] 93 | | // Wait for player input replaced by two newlines [INFO] [stderr] 94 | | &0x08 => string.extend(&[10, 10]), [INFO] [stderr] 95 | | // Clear textbox, then keep printing; replaced by \c [INFO] [stderr] ... | [INFO] [stderr] 101 | | _ => string.push(*byte), [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | match *byte { [INFO] [stderr] 93 | // Wait for player input replaced by two newlines [INFO] [stderr] 94 | 0x08 => string.extend(&[10, 10]), [INFO] [stderr] 95 | // Clear textbox, then keep printing; replaced by \c [INFO] [stderr] 96 | 0x0C => string.extend(&[92, 99]), [INFO] [stderr] 97 | // Printing delay; replaced by \p [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / match byte { [INFO] [stderr] 93 | | // Wait for player input replaced by two newlines [INFO] [stderr] 94 | | &0x08 => string.extend(&[10, 10]), [INFO] [stderr] 95 | | // Clear textbox, then keep printing; replaced by \c [INFO] [stderr] ... | [INFO] [stderr] 101 | | _ => string.push(*byte), [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | match *byte { [INFO] [stderr] 93 | // Wait for player input replaced by two newlines [INFO] [stderr] 94 | 0x08 => string.extend(&[10, 10]), [INFO] [stderr] 95 | // Clear textbox, then keep printing; replaced by \c [INFO] [stderr] 96 | 0x0C => string.extend(&[92, 99]), [INFO] [stderr] 97 | // Printing delay; replaced by \p [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/msl_script_dump.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return Ok(dialogue); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(dialogue)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/msl_script_dump.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | fn process_file(input_file : &String) -> io::Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/msl_script_dump.rs:77:63 [INFO] [stderr] | [INFO] [stderr] 77 | let input_files = matches.values_of("input").unwrap().map(|path| String::from(path)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/msl_script_dump.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return Ok(dialogue); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(dialogue)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/msl_script_dump.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | fn process_file(input_file : &String) -> io::Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/msl_script_dump.rs:77:63 [INFO] [stderr] | [INFO] [stderr] 77 | let input_files = matches.values_of("input").unwrap().map(|path| String::from(path)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.74s [INFO] running `"docker" "inspect" "b32ddbf592d116acaf6b2c130f15432e6865a514664af2c9557bb74b4daa8a7c"` [INFO] running `"docker" "rm" "-f" "b32ddbf592d116acaf6b2c130f15432e6865a514664af2c9557bb74b4daa8a7c"` [INFO] [stdout] b32ddbf592d116acaf6b2c130f15432e6865a514664af2c9557bb74b4daa8a7c