[INFO] updating cached repository studio-lucia/fldtools [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/studio-lucia/fldtools [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/studio-lucia/fldtools" "work/ex/clippy-test-run/sources/stable/gh/studio-lucia/fldtools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/studio-lucia/fldtools'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/studio-lucia/fldtools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/fldtools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/fldtools'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c42f781ce5cc6a484267a82b2222dd83430c9a80 [INFO] sha for GitHub repo studio-lucia/fldtools: c42f781ce5cc6a484267a82b2222dd83430c9a80 [INFO] validating manifest of studio-lucia/fldtools on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of studio-lucia/fldtools on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing studio-lucia/fldtools [INFO] finished frobbing studio-lucia/fldtools [INFO] frobbed toml for studio-lucia/fldtools written to work/ex/clippy-test-run/sources/stable/gh/studio-lucia/fldtools/Cargo.toml [INFO] started frobbing studio-lucia/fldtools [INFO] finished frobbing studio-lucia/fldtools [INFO] frobbed toml for studio-lucia/fldtools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/fldtools/Cargo.toml [INFO] crate studio-lucia/fldtools has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting studio-lucia/fldtools against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/studio-lucia/fldtools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3df20f66515442e6b42a0e3dd4273dc0d5ee0452a2cd175b9017c7a1e79c0c3b [INFO] running `"docker" "start" "-a" "3df20f66515442e6b42a0e3dd4273dc0d5ee0452a2cd175b9017c7a1e79c0c3b"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking libc v0.2.26 [INFO] [stderr] Checking either v1.1.0 [INFO] [stderr] Checking itertools v0.6.1 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking textwrap v0.6.0 [INFO] [stderr] Checking clap v2.25.0 [INFO] [stderr] Checking fldtools v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | chunks: chunks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chunks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | chunks: chunks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chunks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | chunks: chunks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chunks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | chunks: chunks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chunks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / return Ok(Chunk { [INFO] [stderr] 43 | | start: data.read_u32::()?, [INFO] [stderr] 44 | | length: data.read_u32::()?, [INFO] [stderr] 45 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | Ok(Chunk { [INFO] [stderr] 43 | start: data.read_u32::()?, [INFO] [stderr] 44 | length: data.read_u32::()?, [INFO] [stderr] 45 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return Ok(writer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return a; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / return ChunkList { [INFO] [stderr] 85 | | chunks: chunks, [INFO] [stderr] 86 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | ChunkList { [INFO] [stderr] 85 | chunks: chunks, [INFO] [stderr] 86 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / return Ok(ChunkList { [INFO] [stderr] 100 | | chunks: chunks, [INFO] [stderr] 101 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 99 | Ok(ChunkList { [INFO] [stderr] 100 | chunks: chunks, [INFO] [stderr] 101 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | return Ok(serialized); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(serialized)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return self.chunks.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chunks.into_iter()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / return Ok(Chunk { [INFO] [stderr] 43 | | start: data.read_u32::()?, [INFO] [stderr] 44 | | length: data.read_u32::()?, [INFO] [stderr] 45 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | Ok(Chunk { [INFO] [stderr] 43 | start: data.read_u32::()?, [INFO] [stderr] 44 | length: data.read_u32::()?, [INFO] [stderr] 45 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return Ok(writer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return a; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / return ChunkList { [INFO] [stderr] 85 | | chunks: chunks, [INFO] [stderr] 86 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | ChunkList { [INFO] [stderr] 85 | chunks: chunks, [INFO] [stderr] 86 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / return Ok(ChunkList { [INFO] [stderr] 100 | | chunks: chunks, [INFO] [stderr] 101 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 99 | Ok(ChunkList { [INFO] [stderr] 100 | chunks: chunks, [INFO] [stderr] 101 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | return Ok(serialized); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(serialized)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return self.chunks.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chunks.into_iter()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/fldunpack.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(chunk_data.length); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(chunk_data.length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/fldunpack.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(chunk_data.length); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(chunk_data.length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/fldunpack.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | fn write_chunk(mut reader : &mut BufReader<&mut File>, mut target : &File, chunk_data : &Chunk) -> ::std::io::Result { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bin/fldunpack.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | reader.seek(SeekFrom::Start(chunk_data.start as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(chunk_data.start)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/fldunpack.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / let buf_size; [INFO] [stderr] 30 | | if bytes_to_read >= 2048 { [INFO] [stderr] 31 | | buf_size = SECTOR_LENGTH; [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | buf_size = bytes_to_read as usize; [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let buf_size = if bytes_to_read >= 2048 { SECTOR_LENGTH } else { bytes_to_read as usize };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/fldunpack.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | target.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_chunk` doesn't need a mutable reference [INFO] [stderr] --> src/bin/fldunpack.rs:105:44 [INFO] [stderr] | [INFO] [stderr] 105 | match write_chunk(&mut buf_reader, &mut output_file, &chunk) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fldtools`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/fldunpack.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | fn write_chunk(mut reader : &mut BufReader<&mut File>, mut target : &File, chunk_data : &Chunk) -> ::std::io::Result { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bin/fldunpack.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | reader.seek(SeekFrom::Start(chunk_data.start as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(chunk_data.start)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/fldunpack.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / let buf_size; [INFO] [stderr] 30 | | if bytes_to_read >= 2048 { [INFO] [stderr] 31 | | buf_size = SECTOR_LENGTH; [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | buf_size = bytes_to_read as usize; [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let buf_size = if bytes_to_read >= 2048 { SECTOR_LENGTH } else { bytes_to_read as usize };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/fldunpack.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | target.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_chunk` doesn't need a mutable reference [INFO] [stderr] --> src/bin/fldunpack.rs:105:44 [INFO] [stderr] | [INFO] [stderr] 105 | match write_chunk(&mut buf_reader, &mut output_file, &chunk) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fldtools`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/fldpack.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(bytes_written); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bytes_written)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/fldpack.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(bytes_written); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bytes_written)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/fldpack.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | fn write_file(filename : &String, writer : &mut BufWriter) -> ::std::io::Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/fldpack.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | writer.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/fldpack.rs:59:63 [INFO] [stderr] | [INFO] [stderr] 59 | let input_files = matches.values_of("input").unwrap().map(|path| String::from(path)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/fldpack.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | writer.write(&chunk_list.serialize().unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fldtools`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/fldpack.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | fn write_file(filename : &String, writer : &mut BufWriter) -> ::std::io::Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/fldpack.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | writer.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/fldpack.rs:59:63 [INFO] [stderr] | [INFO] [stderr] 59 | let input_files = matches.values_of("input").unwrap().map(|path| String::from(path)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/fldpack.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | writer.write(&chunk_list.serialize().unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fldtools`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3df20f66515442e6b42a0e3dd4273dc0d5ee0452a2cd175b9017c7a1e79c0c3b"` [INFO] running `"docker" "rm" "-f" "3df20f66515442e6b42a0e3dd4273dc0d5ee0452a2cd175b9017c7a1e79c0c3b"` [INFO] [stdout] 3df20f66515442e6b42a0e3dd4273dc0d5ee0452a2cd175b9017c7a1e79c0c3b