[INFO] updating cached repository sts10/crackme-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sts10/crackme-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sts10/crackme-rust" "work/ex/clippy-test-run/sources/stable/gh/sts10/crackme-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sts10/crackme-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sts10/crackme-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sts10/crackme-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sts10/crackme-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8359458fd049d7b6e786952e58000a73635dd39b [INFO] sha for GitHub repo sts10/crackme-rust: 8359458fd049d7b6e786952e58000a73635dd39b [INFO] validating manifest of sts10/crackme-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sts10/crackme-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sts10/crackme-rust [INFO] finished frobbing sts10/crackme-rust [INFO] frobbed toml for sts10/crackme-rust written to work/ex/clippy-test-run/sources/stable/gh/sts10/crackme-rust/Cargo.toml [INFO] started frobbing sts10/crackme-rust [INFO] finished frobbing sts10/crackme-rust [INFO] frobbed toml for sts10/crackme-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sts10/crackme-rust/Cargo.toml [INFO] crate sts10/crackme-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sts10/crackme-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sts10/crackme-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6eebc96a44762b285daf81f3e4dbc712ac547114dcd868d1b12562820c5a7a92 [INFO] running `"docker" "start" "-a" "6eebc96a44762b285daf81f3e4dbc712ac547114dcd868d1b12562820c5a7a92"` [INFO] [stderr] Compiling nodrop v0.1.12 [INFO] [stderr] Compiling memoffset v0.2.1 [INFO] [stderr] Compiling scopeguard v0.3.3 [INFO] [stderr] Checking untrusted v0.5.1 [INFO] [stderr] Compiling crossbeam-utils v0.2.2 [INFO] [stderr] Compiling num_cpus v1.8.0 [INFO] [stderr] Compiling arrayvec v0.4.7 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking crackme-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | let iterations = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | return "Nope".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Nope".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | return lower; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `lower` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | let iterations = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | return "Nope".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Nope".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | return lower; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `lower` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:126:23 [INFO] [stderr] | [INFO] [stderr] 126 | assert_eq!(derive(100000, salt, password), derived); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(derive(100000, salt, password), derived); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | assert_eq!(derive(100000, salt, password), derived); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:153:42 [INFO] [stderr] | [INFO] [stderr] 153 | assert_eq!(guess(incorrect_password, 100000, salt, derived), false); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:154:40 [INFO] [stderr] | [INFO] [stderr] 154 | assert_eq!(guess(correct_password, 100000, salt, derived), true); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:162:22 [INFO] [stderr] | [INFO] [stderr] 162 | let iterations = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:172:22 [INFO] [stderr] | [INFO] [stderr] 172 | let iterations = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.97s [INFO] running `"docker" "inspect" "6eebc96a44762b285daf81f3e4dbc712ac547114dcd868d1b12562820c5a7a92"` [INFO] running `"docker" "rm" "-f" "6eebc96a44762b285daf81f3e4dbc712ac547114dcd868d1b12562820c5a7a92"` [INFO] [stdout] 6eebc96a44762b285daf81f3e4dbc712ac547114dcd868d1b12562820c5a7a92