[INFO] updating cached repository sts10/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sts10/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sts10/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/sts10/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sts10/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sts10/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sts10/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sts10/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 749149d5dd3fec7f50af6c186c64fae199e3643b [INFO] sha for GitHub repo sts10/advent-of-code-2018: 749149d5dd3fec7f50af6c186c64fae199e3643b [INFO] validating manifest of sts10/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sts10/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sts10/advent-of-code-2018 [INFO] finished frobbing sts10/advent-of-code-2018 [INFO] frobbed toml for sts10/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/sts10/advent-of-code-2018/Cargo.toml [INFO] started frobbing sts10/advent-of-code-2018 [INFO] finished frobbing sts10/advent-of-code-2018 [INFO] frobbed toml for sts10/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sts10/advent-of-code-2018/Cargo.toml [INFO] crate sts10/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sts10/advent-of-code-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sts10/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c4aa9ca1e8c839d43af2386d245318460f77ccef7e76a41748e21df90e9322b [INFO] running `"docker" "start" "-a" "4c4aa9ca1e8c839d43af2386d245318460f77ccef7e76a41748e21df90e9322b"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking advent-of-code-2018-reorganized v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | date_time: date_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | dt: dt, [INFO] [stderr] | ^^^^^^ help: replace it with: `dt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | asleep: asleep, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `asleep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day03.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | date_time: date_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | dt: dt, [INFO] [stderr] | ^^^^^^ help: replace it with: `dt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | asleep: asleep, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `asleep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/bin/day01.rs:76:27 [INFO] [stderr] | [INFO] [stderr] 76 | assert_eq!(sum_vector(test_vector), (3 + -7 + 200 + 13 + -123)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | expected &[isize], found struct `std::vec::Vec` [INFO] [stderr] | help: consider borrowing here: `&test_vector` [INFO] [stderr] | [INFO] [stderr] = note: expected type `&[isize]` [INFO] [stderr] found type `std::vec::Vec` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0308`. [INFO] [stderr] error: Could not compile `advent-of-code-2018-reorganized`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `guards` [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | let mut guards: HashMap = HashMap::new(); [INFO] [stderr] | ^^^^^^ help: consider using `_guards` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let mut guards: HashMap = HashMap::new(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row_to_fill_in` is only used to index `whole_piece`. [INFO] [stderr] --> src/bin/day03.rs:22:35 [INFO] [stderr] | [INFO] [stderr] 22 | for row_to_fill_in in claim.row..(claim.row + claim.width) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 22 | for in whole_piece.iter_mut().skip(claim.row).take(claim.width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/day03.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | for ref claim in &claims_vec { [INFO] [stderr] | ^^^^^^^^^ ----------- help: try: `let claim = &&claims_vec;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row_to_fill_in` is only used to index `whole_piece`. [INFO] [stderr] --> src/bin/day03.rs:51:35 [INFO] [stderr] | [INFO] [stderr] 51 | for row_to_fill_in in claim.row..(claim.row + claim.width) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for in whole_piece.iter().skip(claim.row).take(claim.width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guards` [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | let mut guards: HashMap = HashMap::new(); [INFO] [stderr] | ^^^^^^ help: consider using `_guards` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let mut guards: HashMap = HashMap::new(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / loop { [INFO] [stderr] 46 | | match iter.next() { [INFO] [stderr] 47 | | Some(event) => { [INFO] [stderr] 48 | | // println!("event is {:?}, peek is {:?}", event, iter.peek()); [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(event) = iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / let guard_id: Option; [INFO] [stderr] 103 | | if white_space_split_vec[2] == "Guard" { [INFO] [stderr] 104 | | let mut guard_id_string = white_space_split_vec[3].to_string(); [INFO] [stderr] 105 | | guard_id_string.remove(0); [INFO] [stderr] ... | [INFO] [stderr] 112 | | guard_id = None; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 102 | let guard_id = if white_space_split_vec[2] == "Guard" { ..; match guard_id_string.parse::() { [INFO] [stderr] 103 | Ok(id) => Some(id), [INFO] [stderr] 104 | Err(_e) => None, [INFO] [stderr] 105 | } } else { None }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / let asleep: bool; [INFO] [stderr] 122 | | if white_space_split_vec[2] == "Guard" || white_space_split_vec[2] == "wakes" { [INFO] [stderr] 123 | | asleep = false; [INFO] [stderr] 124 | | } else { [INFO] [stderr] 125 | | asleep = true; [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let asleep = if white_space_split_vec[2] == "Guard" || white_space_split_vec[2] == "wakes" { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / loop { [INFO] [stderr] 46 | | match iter.next() { [INFO] [stderr] 47 | | Some(event) => { [INFO] [stderr] 48 | | // println!("event is {:?}, peek is {:?}", event, iter.peek()); [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(event) = iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / let guard_id: Option; [INFO] [stderr] 103 | | if white_space_split_vec[2] == "Guard" { [INFO] [stderr] 104 | | let mut guard_id_string = white_space_split_vec[3].to_string(); [INFO] [stderr] 105 | | guard_id_string.remove(0); [INFO] [stderr] ... | [INFO] [stderr] 112 | | guard_id = None; [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 102 | let guard_id = if white_space_split_vec[2] == "Guard" { ..; match guard_id_string.parse::() { [INFO] [stderr] 103 | Ok(id) => Some(id), [INFO] [stderr] 104 | Err(_e) => None, [INFO] [stderr] 105 | } } else { None }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/day04_bad_attempt.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / let asleep: bool; [INFO] [stderr] 122 | | if white_space_split_vec[2] == "Guard" || white_space_split_vec[2] == "wakes" { [INFO] [stderr] 123 | | asleep = false; [INFO] [stderr] 124 | | } else { [INFO] [stderr] 125 | | asleep = true; [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let asleep = if white_space_split_vec[2] == "Guard" || white_space_split_vec[2] == "wakes" { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "4c4aa9ca1e8c839d43af2386d245318460f77ccef7e76a41748e21df90e9322b"` [INFO] running `"docker" "rm" "-f" "4c4aa9ca1e8c839d43af2386d245318460f77ccef7e76a41748e21df90e9322b"` [INFO] [stdout] 4c4aa9ca1e8c839d43af2386d245318460f77ccef7e76a41748e21df90e9322b