[INFO] updating cached repository strymon-system/reconstruction [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/strymon-system/reconstruction [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/strymon-system/reconstruction" "work/ex/clippy-test-run/sources/stable/gh/strymon-system/reconstruction"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/strymon-system/reconstruction'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/strymon-system/reconstruction" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/strymon-system/reconstruction"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/strymon-system/reconstruction'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cf576a7eeced99fcfebcddd1995207374a11d9b3 [INFO] sha for GitHub repo strymon-system/reconstruction: cf576a7eeced99fcfebcddd1995207374a11d9b3 [INFO] validating manifest of strymon-system/reconstruction on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of strymon-system/reconstruction on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing strymon-system/reconstruction [INFO] finished frobbing strymon-system/reconstruction [INFO] frobbed toml for strymon-system/reconstruction written to work/ex/clippy-test-run/sources/stable/gh/strymon-system/reconstruction/Cargo.toml [INFO] started frobbing strymon-system/reconstruction [INFO] finished frobbing strymon-system/reconstruction [INFO] frobbed toml for strymon-system/reconstruction written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/strymon-system/reconstruction/Cargo.toml [INFO] crate strymon-system/reconstruction has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting strymon-system/reconstruction against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/strymon-system/reconstruction:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d628c16141c51230ca6af9cf444a209b02430f775dcdca551026d159301a7b78 [INFO] running `"docker" "start" "-a" "d628c16141c51230ca6af9cf444a209b02430f775dcdca551026d159301a7b78"` [INFO] [stderr] Checking abomonation v0.5.0 [INFO] [stderr] Compiling abomonation_derive v0.3.0 [INFO] [stderr] Checking timely_communication v0.5.0 [INFO] [stderr] Checking timely v0.5.0 [INFO] [stderr] Checking reconstruction v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/operators/stats.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | stage2 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/operators/stats.rs:208:22 [INFO] [stderr] | [INFO] [stderr] 208 | let stage2 = stage1.unary_notify( [INFO] [stderr] | ______________________^ [INFO] [stderr] 209 | | Exchange::new(move |_| 0), [INFO] [stderr] 210 | | "histogram2", [INFO] [stderr] 211 | | vec![], [INFO] [stderr] ... | [INFO] [stderr] 235 | | }, [INFO] [stderr] 236 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/operators/stats.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | stage2 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/operators/stats.rs:208:22 [INFO] [stderr] | [INFO] [stderr] 208 | let stage2 = stage1.unary_notify( [INFO] [stderr] | ______________________^ [INFO] [stderr] 209 | | Exchange::new(move |_| 0), [INFO] [stderr] 210 | | "histogram2", [INFO] [stderr] 211 | | vec![], [INFO] [stderr] ... | [INFO] [stderr] 235 | | }, [INFO] [stderr] 236 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/operators/stats.rs:66:47 [INFO] [stderr] | [INFO] [stderr] 66 | fn histogram(&self, discretizer: F) -> Stream)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/operators/stats.rs:80:47 [INFO] [stderr] | [INFO] [stderr] 80 | fn histogram(&self, discretizer: F) -> Stream)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/operators/stats.rs:151:54 [INFO] [stderr] | [INFO] [stderr] 151 | fn topk(&self, discretizer: F, top_k: u64) -> Stream)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/operators/stats.rs:165:53 [INFO] [stderr] | [INFO] [stderr] 165 | fn topk(&self, discretizer: F, topk: u64) -> Stream)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `recv` is only used to index `messages`. [INFO] [stderr] --> src/lib.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | for recv in send+1..messages.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 170 | for in messages.iter().skip(send+1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/operators/stats.rs:66:47 [INFO] [stderr] | [INFO] [stderr] 66 | fn histogram(&self, discretizer: F) -> Stream)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/operators/stats.rs:80:47 [INFO] [stderr] | [INFO] [stderr] 80 | fn histogram(&self, discretizer: F) -> Stream)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/operators/stats.rs:151:54 [INFO] [stderr] | [INFO] [stderr] 151 | fn topk(&self, discretizer: F, top_k: u64) -> Stream)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/operators/stats.rs:165:53 [INFO] [stderr] | [INFO] [stderr] 165 | fn topk(&self, discretizer: F, topk: u64) -> Stream)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `recv` is only used to index `messages`. [INFO] [stderr] --> src/lib.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | for recv in send+1..messages.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 170 | for in messages.iter().skip(send+1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:195:36 [INFO] [stderr] | [INFO] [stderr] 195 | assert_eq!(canonical_shape(&vec![SpanId(vec![0])]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[SpanId(vec![0])]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:197:36 [INFO] [stderr] | [INFO] [stderr] 197 | assert_eq!(canonical_shape(&vec![SpanId(vec![1])]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[SpanId(vec![1])]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:199:36 [INFO] [stderr] | [INFO] [stderr] 199 | assert_eq!(canonical_shape(&vec![SpanId(vec![0, 1])]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[SpanId(vec![0, 1])]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:201:36 [INFO] [stderr] | [INFO] [stderr] 201 | assert_eq!(canonical_shape(&vec![SpanId(vec![2, 1, 3]), SpanId(vec![3])]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[SpanId(vec![2, 1, 3]), SpanId(vec![3])]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/main.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.76s [INFO] running `"docker" "inspect" "d628c16141c51230ca6af9cf444a209b02430f775dcdca551026d159301a7b78"` [INFO] running `"docker" "rm" "-f" "d628c16141c51230ca6af9cf444a209b02430f775dcdca551026d159301a7b78"` [INFO] [stdout] d628c16141c51230ca6af9cf444a209b02430f775dcdca551026d159301a7b78