[INFO] updating cached repository streletss/game-of-snake [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/streletss/game-of-snake [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/streletss/game-of-snake" "work/ex/clippy-test-run/sources/stable/gh/streletss/game-of-snake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/streletss/game-of-snake'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/streletss/game-of-snake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/streletss/game-of-snake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/streletss/game-of-snake'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a726718a05408de8061a222c099c55d5f793ba35 [INFO] sha for GitHub repo streletss/game-of-snake: a726718a05408de8061a222c099c55d5f793ba35 [INFO] validating manifest of streletss/game-of-snake on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of streletss/game-of-snake on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing streletss/game-of-snake [INFO] finished frobbing streletss/game-of-snake [INFO] frobbed toml for streletss/game-of-snake written to work/ex/clippy-test-run/sources/stable/gh/streletss/game-of-snake/Cargo.toml [INFO] started frobbing streletss/game-of-snake [INFO] finished frobbing streletss/game-of-snake [INFO] frobbed toml for streletss/game-of-snake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/streletss/game-of-snake/Cargo.toml [INFO] crate streletss/game-of-snake has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting streletss/game-of-snake against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/streletss/game-of-snake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 75d80c72b2207553fae96822e8786b15c51ddcc0535884edde13d17aa322f403 [INFO] running `"docker" "start" "-a" "75d80c72b2207553fae96822e8786b15c51ddcc0535884edde13d17aa322f403"` [INFO] [stderr] Compiling proc-macro2 v0.4.21 [INFO] [stderr] Checking read_color v1.0.0 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling log v0.4.6 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Compiling x11-dl v2.18.3 [INFO] [stderr] Checking stb_truetype v0.2.4 [INFO] [stderr] Checking piston-viewport v0.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking smallvec v0.6.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking libloading v0.5.0 [INFO] [stderr] Checking ordered-float v0.5.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking piston2d-graphics v0.27.0 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Compiling wayland-scanner v0.20.12 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Compiling wayland-client v0.20.12 [INFO] [stderr] Compiling wayland-protocols v0.20.12 [INFO] [stderr] Compiling glutin v0.18.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling derivative v1.0.2 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking pistoncore-input v0.22.0 [INFO] [stderr] Checking pistoncore-window v0.33.0 [INFO] [stderr] Checking pistoncore-event_loop v0.38.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.49.0 [INFO] [stderr] Checking piston v0.38.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.53.0 [INFO] [stderr] Checking piston_window v0.83.0 [INFO] [stderr] Checking snake_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | g: &mut G2d, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/draw.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | g: &mut G2d, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:3 [INFO] [stderr] | [INFO] [stderr] 7 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | BLOCK_SIZE * (w as f64), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | BLOCK_SIZE * (h as f64), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn opposite(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:3 [INFO] [stderr] | [INFO] [stderr] 7 | (game_coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(game_coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | BLOCK_SIZE * (w as f64), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | BLOCK_SIZE * (h as f64), [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn opposite(&self) -> Direction { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the variable `ch` is used as a loop counter. Consider using `for (ch, item) in &self.body.enumerate()` or similar iterators [INFO] [stderr] --> src/snake.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | for block in &self.body { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 24s [INFO] running `"docker" "inspect" "75d80c72b2207553fae96822e8786b15c51ddcc0535884edde13d17aa322f403"` [INFO] running `"docker" "rm" "-f" "75d80c72b2207553fae96822e8786b15c51ddcc0535884edde13d17aa322f403"` [INFO] [stdout] 75d80c72b2207553fae96822e8786b15c51ddcc0535884edde13d17aa322f403