[INFO] updating cached repository strassl/blockchain [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/strassl/blockchain [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/strassl/blockchain" "work/ex/clippy-test-run/sources/stable/gh/strassl/blockchain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/strassl/blockchain'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/strassl/blockchain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/strassl/blockchain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/strassl/blockchain'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 488351e7bb5d038c1c0f486f64300ae1970eea53 [INFO] sha for GitHub repo strassl/blockchain: 488351e7bb5d038c1c0f486f64300ae1970eea53 [INFO] validating manifest of strassl/blockchain on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of strassl/blockchain on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing strassl/blockchain [INFO] finished frobbing strassl/blockchain [INFO] frobbed toml for strassl/blockchain written to work/ex/clippy-test-run/sources/stable/gh/strassl/blockchain/Cargo.toml [INFO] started frobbing strassl/blockchain [INFO] finished frobbing strassl/blockchain [INFO] frobbed toml for strassl/blockchain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/strassl/blockchain/Cargo.toml [INFO] crate strassl/blockchain has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting strassl/blockchain against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/strassl/blockchain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 26f18e2a62e34affea638d13e95c0d17b0ef83e0bcfae2de3e86b6eb9bee9680 [INFO] running `"docker" "start" "-a" "26f18e2a62e34affea638d13e95c0d17b0ef83e0bcfae2de3e86b6eb9bee9680"` [INFO] [stderr] Compiling gcc v0.3.49 [INFO] [stderr] Checking serde v1.0.8 [INFO] [stderr] Checking thread-id v3.1.0 [INFO] [stderr] Compiling serde_derive v1.0.8 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking blockchain v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/chain/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | write!(f, "Chain:\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/chain/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / write!(f, "\t[id={}, nonce={}, data={}, prev={}, hash={}]\n", block.id, block.nonce, [INFO] [stderr] 49 | | bytes_to_str(&block.data), bytes_to_str(&block.prev_hash), bytes_to_str(&hash))?; [INFO] [stderr] | |__________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/chain/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | write!(f, "Chain:\n")?; [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] --> src/chain/mod.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/mod.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/mod.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | prev_hash: prev_hash [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/chain/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / write!(f, "\t[id={}, nonce={}, data={}, prev={}, hash={}]\n", block.id, block.nonce, [INFO] [stderr] 49 | | bytes_to_str(&block.data), bytes_to_str(&block.prev_hash), bytes_to_str(&hash))?; [INFO] [stderr] | |__________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/mod.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/mod.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/mod.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | prev_hash: prev_hash [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: function is never used: `serialize` [INFO] [stderr] --> src/chain/serialization.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn serialize(chain: &Chain) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `deserialize` [INFO] [stderr] --> src/chain/serialization.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn deserialize(data: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chain/serialization.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn deserialize(data: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chain/serialization.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn deserialize(data: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/chain/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | write!(f, "Chain:\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/chain/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / write!(f, "\t[id={}, nonce={}, data={}, prev={}, hash={}]\n", block.id, block.nonce, [INFO] [stderr] 49 | | bytes_to_str(&block.data), bytes_to_str(&block.prev_hash), bytes_to_str(&hash))?; [INFO] [stderr] | |__________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/mod.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/mod.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/mod.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | prev_hash: prev_hash [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/chain/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | write!(f, "Chain:\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/chain/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / write!(f, "\t[id={}, nonce={}, data={}, prev={}, hash={}]\n", block.id, block.nonce, [INFO] [stderr] 49 | | bytes_to_str(&block.data), bytes_to_str(&block.prev_hash), bytes_to_str(&hash))?; [INFO] [stderr] | |__________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/mod.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/mod.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/mod.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | prev_hash: prev_hash [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `deserialize` [INFO] [stderr] --> src/main.rs:10:39 [INFO] [stderr] | [INFO] [stderr] 10 | use chain::serialization::{serialize, deserialize}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `deserialize` [INFO] [stderr] --> src/main.rs:10:39 [INFO] [stderr] | [INFO] [stderr] 10 | use chain::serialization::{serialize, deserialize}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `deserialize` [INFO] [stderr] --> src/chain/serialization.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn deserialize(data: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chain/serialization.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn deserialize(data: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chain/serialization.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn deserialize(data: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.00s [INFO] running `"docker" "inspect" "26f18e2a62e34affea638d13e95c0d17b0ef83e0bcfae2de3e86b6eb9bee9680"` [INFO] running `"docker" "rm" "-f" "26f18e2a62e34affea638d13e95c0d17b0ef83e0bcfae2de3e86b6eb9bee9680"` [INFO] [stdout] 26f18e2a62e34affea638d13e95c0d17b0ef83e0bcfae2de3e86b6eb9bee9680