[INFO] updating cached repository stormogulen/dehex [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stormogulen/dehex [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stormogulen/dehex" "work/ex/clippy-test-run/sources/stable/gh/stormogulen/dehex"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stormogulen/dehex'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stormogulen/dehex" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stormogulen/dehex"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stormogulen/dehex'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 97a00d7d88b381e11841ace0e0bebd84cfc14b40 [INFO] sha for GitHub repo stormogulen/dehex: 97a00d7d88b381e11841ace0e0bebd84cfc14b40 [INFO] validating manifest of stormogulen/dehex on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stormogulen/dehex on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stormogulen/dehex [INFO] finished frobbing stormogulen/dehex [INFO] frobbed toml for stormogulen/dehex written to work/ex/clippy-test-run/sources/stable/gh/stormogulen/dehex/Cargo.toml [INFO] started frobbing stormogulen/dehex [INFO] finished frobbing stormogulen/dehex [INFO] frobbed toml for stormogulen/dehex written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stormogulen/dehex/Cargo.toml [INFO] crate stormogulen/dehex has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stormogulen/dehex against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stormogulen/dehex:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 217cd396732903f6093ff2d983a4d4dc70dda18aec45395e19352817a96d5248 [INFO] running `"docker" "start" "-a" "217cd396732903f6093ff2d983a4d4dc70dda18aec45395e19352817a96d5248"` [INFO] [stderr] Compiling cc v1.0.9 [INFO] [stderr] Compiling khronos_api v2.1.0 [INFO] [stderr] Checking serde v1.0.33 [INFO] [stderr] Checking pretty-hex v0.1.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling x11-dl v2.17.3 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking inflate v0.3.4 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Checking crossbeam-epoch v0.3.0 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling syn v0.12.14 [INFO] [stderr] Compiling gl_generator v0.8.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Compiling glutin v0.12.2 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Compiling serde_derive_internals v0.21.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Compiling serde_derive v1.0.33 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.52.0 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.3 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking dehex v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | fn update(&mut self, _args: &UpdateArgs) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:89:24 [INFO] [stderr] | [INFO] [stderr] 89 | self.snake.d = match btn { [INFO] [stderr] | ________________________^ [INFO] [stderr] 90 | | &Button::Keyboard(Key::Up) if last_direction != Direction::DOWN => { [INFO] [stderr] 91 | | Direction::UP [INFO] [stderr] 92 | | } [INFO] [stderr] ... | [INFO] [stderr] 102 | | _ => last_direction, [INFO] [stderr] 103 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | self.snake.d = match *btn { [INFO] [stderr] 90 | Button::Keyboard(Key::Up) if last_direction != Direction::DOWN => { [INFO] [stderr] 91 | Direction::UP [INFO] [stderr] 92 | } [INFO] [stderr] 93 | Button::Keyboard(Key::Down) if last_direction != Direction::UP => { [INFO] [stderr] 94 | Direction::DOWN [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:136:45 [INFO] [stderr] | [INFO] [stderr] 136 | graphics::rectangle::square(p.0 as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:137:45 [INFO] [stderr] | [INFO] [stderr] 137 | p.1 as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:138:45 [INFO] [stderr] | [INFO] [stderr] 138 | self.width as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | / if front.0 == self.x && front.1 == self.y { [INFO] [stderr] 200 | | true [INFO] [stderr] 201 | | } else { [INFO] [stderr] 202 | | false [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `front.0 == self.x && front.1 == self.y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:41 [INFO] [stderr] | [INFO] [stderr] 215 | graphics::rectangle::square(x as f64, y as f64, width as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:51 [INFO] [stderr] | [INFO] [stderr] 215 | graphics::rectangle::square(x as f64, y as f64, width as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:61 [INFO] [stderr] | [INFO] [stderr] 215 | graphics::rectangle::square(x as f64, y as f64, width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | fn update(&mut self, _args: &UpdateArgs) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:89:24 [INFO] [stderr] | [INFO] [stderr] 89 | self.snake.d = match btn { [INFO] [stderr] | ________________________^ [INFO] [stderr] 90 | | &Button::Keyboard(Key::Up) if last_direction != Direction::DOWN => { [INFO] [stderr] 91 | | Direction::UP [INFO] [stderr] 92 | | } [INFO] [stderr] ... | [INFO] [stderr] 102 | | _ => last_direction, [INFO] [stderr] 103 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | self.snake.d = match *btn { [INFO] [stderr] 90 | Button::Keyboard(Key::Up) if last_direction != Direction::DOWN => { [INFO] [stderr] 91 | Direction::UP [INFO] [stderr] 92 | } [INFO] [stderr] 93 | Button::Keyboard(Key::Down) if last_direction != Direction::UP => { [INFO] [stderr] 94 | Direction::DOWN [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:136:45 [INFO] [stderr] | [INFO] [stderr] 136 | graphics::rectangle::square(p.0 as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:137:45 [INFO] [stderr] | [INFO] [stderr] 137 | p.1 as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:138:45 [INFO] [stderr] | [INFO] [stderr] 138 | self.width as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | / if front.0 == self.x && front.1 == self.y { [INFO] [stderr] 200 | | true [INFO] [stderr] 201 | | } else { [INFO] [stderr] 202 | | false [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `front.0 == self.x && front.1 == self.y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:41 [INFO] [stderr] | [INFO] [stderr] 215 | graphics::rectangle::square(x as f64, y as f64, width as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:51 [INFO] [stderr] | [INFO] [stderr] 215 | graphics::rectangle::square(x as f64, y as f64, width as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:215:61 [INFO] [stderr] | [INFO] [stderr] 215 | graphics::rectangle::square(x as f64, y as f64, width as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `"docker" "inspect" "217cd396732903f6093ff2d983a4d4dc70dda18aec45395e19352817a96d5248"` [INFO] running `"docker" "rm" "-f" "217cd396732903f6093ff2d983a4d4dc70dda18aec45395e19352817a96d5248"` [INFO] [stdout] 217cd396732903f6093ff2d983a4d4dc70dda18aec45395e19352817a96d5248