[INFO] updating cached repository stompchicken/lux [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stompchicken/lux [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stompchicken/lux" "work/ex/clippy-test-run/sources/stable/gh/stompchicken/lux"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stompchicken/lux'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stompchicken/lux" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stompchicken/lux"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stompchicken/lux'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 79158a0b3af335af15ddf9c6142dba5feb174ae7 [INFO] sha for GitHub repo stompchicken/lux: 79158a0b3af335af15ddf9c6142dba5feb174ae7 [INFO] validating manifest of stompchicken/lux on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stompchicken/lux on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stompchicken/lux [INFO] finished frobbing stompchicken/lux [INFO] frobbed toml for stompchicken/lux written to work/ex/clippy-test-run/sources/stable/gh/stompchicken/lux/Cargo.toml [INFO] started frobbing stompchicken/lux [INFO] finished frobbing stompchicken/lux [INFO] frobbed toml for stompchicken/lux written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stompchicken/lux/Cargo.toml [INFO] crate stompchicken/lux has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stompchicken/lux against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stompchicken/lux:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7df559df77eca6bb45fcb8c79874cac09e54d8bfe2bfaffd9139306689464c66 [INFO] running `"docker" "start" "-a" "7df559df77eca6bb45fcb8c79874cac09e54d8bfe2bfaffd9139306689464c66"` [INFO] [stderr] Checking solaire v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | Vector { x: x, y: y, z: z, w: 1.0 } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | Vector { x: x, y: y, z: z, w: 1.0 } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | Vector { x: x, y: y, z: z, w: 1.0 } [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matrix.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | Matrix { values: values} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | Colour { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | Colour { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:15:30 [INFO] [stderr] | [INFO] [stderr] 15 | Colour { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:63:15 [INFO] [stderr] | [INFO] [stderr] 63 | Ray { origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:65:15 [INFO] [stderr] | [INFO] [stderr] 65 | colour: colour [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | Pixel { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | Pixel { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | Pixel { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | Bitmap { width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | lower_left_corner: lower_left_corner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_left_corner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | horizontal: horizontal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | vertical: vertical [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | geometry: geometry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | material: material, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | Diffuse { albedo: albedo } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | Metal { colour: colour, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:57:33 [INFO] [stderr] | [INFO] [stderr] 57 | Metal { colour: colour, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fuzz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | DiffuseLight { colour: colour } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | RectXZ { x0: x0, x1: x1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `x0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | RectXZ { x0: x0, x1: x1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `x1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:17:34 [INFO] [stderr] | [INFO] [stderr] 17 | RectXZ { x0: x0, x1: x1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `z0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:17:42 [INFO] [stderr] | [INFO] [stderr] 17 | RectXZ { x0: x0, x1: x1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `z1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | RectXZ { x0: x0, x1: x1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | RectYZ { y0: y0, y1: y1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `y0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | RectYZ { y0: y0, y1: y1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `y1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:63:34 [INFO] [stderr] | [INFO] [stderr] 63 | RectYZ { y0: y0, y1: y1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `z0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | RectYZ { y0: y0, y1: y1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `z1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:63:50 [INFO] [stderr] | [INFO] [stderr] 63 | RectYZ { y0: y0, y1: y1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | RectXY { x0: x0, x1: x1, y0: y0, y1: y1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `x0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | RectXY { x0: x0, x1: x1, y0: y0, y1: y1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `x1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:109:34 [INFO] [stderr] | [INFO] [stderr] 109 | RectXY { x0: x0, x1: x1, y0: y0, y1: y1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `y0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:109:42 [INFO] [stderr] | [INFO] [stderr] 109 | RectXY { x0: x0, x1: x1, y0: y0, y1: y1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `y1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:109:50 [INFO] [stderr] | [INFO] [stderr] 109 | RectXY { x0: x0, x1: x1, y0: y0, y1: y1, k: k } [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/sphere.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | Sphere { center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/sphere.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geometry/sphere.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let d = b*b - a*c; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | Vector { x: x, y: y, z: z, w: 1.0 } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | Vector { x: x, y: y, z: z, w: 1.0 } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vector.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | Vector { x: x, y: y, z: z, w: 1.0 } [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matrix.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | Matrix { values: values} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | Colour { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | Colour { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:15:30 [INFO] [stderr] | [INFO] [stderr] 15 | Colour { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:63:15 [INFO] [stderr] | [INFO] [stderr] 63 | Ray { origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:65:15 [INFO] [stderr] | [INFO] [stderr] 65 | colour: colour [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | Pixel { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | Pixel { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | Pixel { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | Bitmap { width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | lower_left_corner: lower_left_corner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_left_corner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | horizontal: horizontal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | vertical: vertical [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | geometry: geometry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | material: material, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | Diffuse { albedo: albedo } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | Metal { colour: colour, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:57:33 [INFO] [stderr] | [INFO] [stderr] 57 | Metal { colour: colour, fuzz: fuzz } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fuzz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | DiffuseLight { colour: colour } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | RectXZ { x0: x0, x1: x1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `x0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | RectXZ { x0: x0, x1: x1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `x1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:17:34 [INFO] [stderr] | [INFO] [stderr] 17 | RectXZ { x0: x0, x1: x1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `z0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:17:42 [INFO] [stderr] | [INFO] [stderr] 17 | RectXZ { x0: x0, x1: x1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `z1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | RectXZ { x0: x0, x1: x1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | RectYZ { y0: y0, y1: y1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `y0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | RectYZ { y0: y0, y1: y1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `y1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:63:34 [INFO] [stderr] | [INFO] [stderr] 63 | RectYZ { y0: y0, y1: y1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `z0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | RectYZ { y0: y0, y1: y1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `z1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:63:50 [INFO] [stderr] | [INFO] [stderr] 63 | RectYZ { y0: y0, y1: y1, z0: z0, z1: z1, k: k } [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | RectXY { x0: x0, x1: x1, y0: y0, y1: y1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `x0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | RectXY { x0: x0, x1: x1, y0: y0, y1: y1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `x1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:109:34 [INFO] [stderr] | [INFO] [stderr] 109 | RectXY { x0: x0, x1: x1, y0: y0, y1: y1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `y0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:109:42 [INFO] [stderr] | [INFO] [stderr] 109 | RectXY { x0: x0, x1: x1, y0: y0, y1: y1, k: k } [INFO] [stderr] | ^^^^^^ help: replace it with: `y1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/cuboid.rs:109:50 [INFO] [stderr] | [INFO] [stderr] 109 | RectXY { x0: x0, x1: x1, y0: y0, y1: y1, k: k } [INFO] [stderr] | ^^^^ help: replace it with: `k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/sphere.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | Sphere { center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry/sphere.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geometry/sphere.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let d = b*b - a*c; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return Rng { state: x1, inc: x2 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rng { state: x1, inc: x2 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return Rng { state: x1, inc: x2 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rng { state: x1, inc: x2 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return self.next_f32(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.next_f32()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | let constant1: u64 = 6364136223846793005; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | const UPPER_MASK: u32 = 0x3F800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:44:33 [INFO] [stderr] | [INFO] [stderr] 44 | const LOWER_MASK: u32 = 0x7FFFFF; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x007F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return (v1.x * v2.x) + (v1.y * v2.y) + (v1.z * v2.z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(v1.x * v2.x) + (v1.y * v2.y) + (v1.z * v2.z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return (self.x * self.x) + (self.y * self.y) + (self.z * self.z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x * self.x) + (self.y * self.y) + (self.z * self.z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return (self.squared_length()).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.squared_length()).sqrt()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / return (lhs.x - rhs.x).abs() < eps [INFO] [stderr] 64 | | && (lhs.y - rhs.y).abs() < eps [INFO] [stderr] 65 | | && (lhs.z - rhs.z).abs() < eps [INFO] [stderr] 66 | | && (lhs.w - rhs.w).abs() < eps; [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | (lhs.x - rhs.x).abs() < eps [INFO] [stderr] 64 | && (lhs.y - rhs.y).abs() < eps [INFO] [stderr] 65 | && (lhs.z - rhs.z).abs() < eps [INFO] [stderr] 66 | && (lhs.w - rhs.w).abs() < eps [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / return Vector { [INFO] [stderr] 72 | | x: self.x / length, [INFO] [stderr] 73 | | y: self.y / length, [INFO] [stderr] 74 | | z: self.z / length, [INFO] [stderr] 75 | | w: 1.0 [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | Vector { [INFO] [stderr] 72 | x: self.x / length, [INFO] [stderr] 73 | y: self.y / length, [INFO] [stderr] 74 | z: self.z / length, [INFO] [stderr] 75 | w: 1.0 [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / return Vector { [INFO] [stderr] 81 | | x: self.x, [INFO] [stderr] 82 | | y: theta.cos() * self.y - theta.sin() * self.z, [INFO] [stderr] 83 | | z: theta.sin() * self.y + theta.cos() * self.z, [INFO] [stderr] 84 | | w: 1.0 [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 80 | Vector { [INFO] [stderr] 81 | x: self.x, [INFO] [stderr] 82 | y: theta.cos() * self.y - theta.sin() * self.z, [INFO] [stderr] 83 | z: theta.sin() * self.y + theta.cos() * self.z, [INFO] [stderr] 84 | w: 1.0 [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / return Vector { [INFO] [stderr] 90 | | x: theta.cos() * self.x + theta.sin() * self.z, [INFO] [stderr] 91 | | y: self.y, [INFO] [stderr] 92 | | z: theta.cos() * self.z - theta.sin() * self.x, [INFO] [stderr] 93 | | w: 1.0 [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | Vector { [INFO] [stderr] 90 | x: theta.cos() * self.x + theta.sin() * self.z, [INFO] [stderr] 91 | y: self.y, [INFO] [stderr] 92 | z: theta.cos() * self.z - theta.sin() * self.x, [INFO] [stderr] 93 | w: 1.0 [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / return Vector { [INFO] [stderr] 99 | | x: theta.cos() * self.x - theta.sin() * self.y, [INFO] [stderr] 100 | | y: theta.sin() * self.x + theta.cos() * self.y, [INFO] [stderr] 101 | | z: self.z, [INFO] [stderr] 102 | | w: 1.0 [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 98 | Vector { [INFO] [stderr] 99 | x: theta.cos() * self.x - theta.sin() * self.y, [INFO] [stderr] 100 | y: theta.sin() * self.x + theta.cos() * self.y, [INFO] [stderr] 101 | z: self.z, [INFO] [stderr] 102 | w: 1.0 [INFO] [stderr] 103 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:144:41 [INFO] [stderr] | [INFO] [stderr] 144 | fn index(&self, i: usize) -> &f32 { return &self.values[i]; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.values[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return self.next_f32(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.next_f32()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:30:30 [INFO] [stderr] | [INFO] [stderr] 30 | let constant1: u64 = 6364136223846793005; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/random.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | const UPPER_MASK: u32 = 0x3F800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:44:33 [INFO] [stderr] | [INFO] [stderr] 44 | const LOWER_MASK: u32 = 0x7FFFFF; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x007F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return (v1.x * v2.x) + (v1.y * v2.y) + (v1.z * v2.z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(v1.x * v2.x) + (v1.y * v2.y) + (v1.z * v2.z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return (self.x * self.x) + (self.y * self.y) + (self.z * self.z); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x * self.x) + (self.y * self.y) + (self.z * self.z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return (self.squared_length()).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.squared_length()).sqrt()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / return (lhs.x - rhs.x).abs() < eps [INFO] [stderr] 64 | | && (lhs.y - rhs.y).abs() < eps [INFO] [stderr] 65 | | && (lhs.z - rhs.z).abs() < eps [INFO] [stderr] 66 | | && (lhs.w - rhs.w).abs() < eps; [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | (lhs.x - rhs.x).abs() < eps [INFO] [stderr] 64 | && (lhs.y - rhs.y).abs() < eps [INFO] [stderr] 65 | && (lhs.z - rhs.z).abs() < eps [INFO] [stderr] 66 | && (lhs.w - rhs.w).abs() < eps [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / return Vector { [INFO] [stderr] 72 | | x: self.x / length, [INFO] [stderr] 73 | | y: self.y / length, [INFO] [stderr] 74 | | z: self.z / length, [INFO] [stderr] 75 | | w: 1.0 [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | Vector { [INFO] [stderr] 72 | x: self.x / length, [INFO] [stderr] 73 | y: self.y / length, [INFO] [stderr] 74 | z: self.z / length, [INFO] [stderr] 75 | w: 1.0 [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / return Vector { [INFO] [stderr] 81 | | x: self.x, [INFO] [stderr] 82 | | y: theta.cos() * self.y - theta.sin() * self.z, [INFO] [stderr] 83 | | z: theta.sin() * self.y + theta.cos() * self.z, [INFO] [stderr] 84 | | w: 1.0 [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 80 | Vector { [INFO] [stderr] 81 | x: self.x, [INFO] [stderr] 82 | y: theta.cos() * self.y - theta.sin() * self.z, [INFO] [stderr] 83 | z: theta.sin() * self.y + theta.cos() * self.z, [INFO] [stderr] 84 | w: 1.0 [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / return Vector { [INFO] [stderr] 90 | | x: theta.cos() * self.x + theta.sin() * self.z, [INFO] [stderr] 91 | | y: self.y, [INFO] [stderr] 92 | | z: theta.cos() * self.z - theta.sin() * self.x, [INFO] [stderr] 93 | | w: 1.0 [INFO] [stderr] 94 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | Vector { [INFO] [stderr] 90 | x: theta.cos() * self.x + theta.sin() * self.z, [INFO] [stderr] 91 | y: self.y, [INFO] [stderr] 92 | z: theta.cos() * self.z - theta.sin() * self.x, [INFO] [stderr] 93 | w: 1.0 [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vector.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / return Vector { [INFO] [stderr] 99 | | x: theta.cos() * self.x - theta.sin() * self.y, [INFO] [stderr] 100 | | y: theta.sin() * self.x + theta.cos() * self.y, [INFO] [stderr] 101 | | z: self.z, [INFO] [stderr] 102 | | w: 1.0 [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 98 | Vector { [INFO] [stderr] 99 | x: theta.cos() * self.x - theta.sin() * self.y, [INFO] [stderr] 100 | y: theta.sin() * self.x + theta.cos() * self.y, [INFO] [stderr] 101 | z: self.z, [INFO] [stderr] 102 | w: 1.0 [INFO] [stderr] 103 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix.rs:144:41 [INFO] [stderr] | [INFO] [stderr] 144 | fn index(&self, i: usize) -> &f32 { return &self.values[i]; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.values[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return self.origin + (t * self.direction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.origin + (t * self.direction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | return self.material.hit(&r, &rot_hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.material.hit(&r, &rot_hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return h; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return self.origin + (t * self.direction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.origin + (t * self.direction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | return self.material.hit(&r, &rot_hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.material.hit(&r, &rot_hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return h; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return HitResult::Emitted(hit.time, Colour::new(0.5 * (c.x + 1.0), [INFO] [stderr] 22 | | 0.5 * (c.y + 1.0), [INFO] [stderr] 23 | | 0.5 * (c.z + 1.0))); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | HitResult::Emitted(hit.time, Colour::new(0.5 * (c.x + 1.0), [INFO] [stderr] 22 | 0.5 * (c.y + 1.0), [INFO] [stderr] 23 | 0.5 * (c.z + 1.0))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return HitResult::Reflected(hit.time, ray); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HitResult::Reflected(hit.time, ray)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | return HitResult::Reflected(hit.time, scattered); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HitResult::Reflected(hit.time, scattered)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | return HitResult::None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HitResult::None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return v - (Vector::dot(v,n) * n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v - (Vector::dot(v,n) * n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stats.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return self.hit_emitter + self.hit_maxdepth + self.hit_nothing; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.hit_emitter + self.hit_maxdepth + self.hit_nothing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/cuboid.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/cuboid.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return HitResult::Emitted(hit.time, Colour::new(0.5 * (c.x + 1.0), [INFO] [stderr] 22 | | 0.5 * (c.y + 1.0), [INFO] [stderr] 23 | | 0.5 * (c.z + 1.0))); [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | HitResult::Emitted(hit.time, Colour::new(0.5 * (c.x + 1.0), [INFO] [stderr] 22 | 0.5 * (c.y + 1.0), [INFO] [stderr] 23 | 0.5 * (c.z + 1.0))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/cuboid.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return HitResult::Reflected(hit.time, ray); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HitResult::Reflected(hit.time, ray)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | return HitResult::Reflected(hit.time, scattered); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HitResult::Reflected(hit.time, scattered)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | return HitResult::None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HitResult::None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/cuboid.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return p; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/cuboid.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return v - (Vector::dot(v,n) * n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v - (Vector::dot(v,n) * n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/sphere.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/sphere.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/sphere.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/stats.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return self.hit_emitter + self.hit_maxdepth + self.hit_nothing; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.hit_emitter + self.hit_maxdepth + self.hit_nothing` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/sphere.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/cuboid.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/cuboid.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/cuboid.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/cuboid.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/cuboid.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/sphere.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/sphere.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | return Some(hit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/sphere.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry/sphere.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/random.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(d) => Rng::new(d.as_secs(), d.subsec_nanos() as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(d.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/random.rs:46:36 [INFO] [stderr] | [INFO] [stderr] 46 | let result: f32 = unsafe { mem::transmute(tmp) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(tmp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | file.write("P3\n".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | file.write(format!("{} {}\n", self.width, self.height).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | file.write(format!("{}\n", max_value).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | file.write(rgb.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | file.write("\n".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `world::World` [INFO] [stderr] --> src/world.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> World { [INFO] [stderr] 63 | | World { [INFO] [stderr] 64 | | objects: Vec::new(), [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `material::NormalSurface` [INFO] [stderr] --> src/material.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> NormalSurface { [INFO] [stderr] 12 | | NormalSurface {} [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / match self.front.test_collision(r, t_min, t_max) { [INFO] [stderr] 171 | | Some(h) => { hit = h; }, [INFO] [stderr] 172 | | None => {}, [INFO] [stderr] 173 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.front.test_collision(r, t_min, t_max) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / match self.back.test_collision(r, t_min, hit.time) { [INFO] [stderr] 175 | | Some(h) => { hit = h; }, [INFO] [stderr] 176 | | None => {}, [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.back.test_collision(r, t_min, hit.time) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / match self.left.test_collision(r, t_min, hit.time) { [INFO] [stderr] 179 | | Some(h) => { hit = h; }, [INFO] [stderr] 180 | | None => {}, [INFO] [stderr] 181 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.left.test_collision(r, t_min, hit.time) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / match self.right.test_collision(r, t_min, hit.time) { [INFO] [stderr] 183 | | Some(h) => { hit = h; }, [INFO] [stderr] 184 | | None => {}, [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.right.test_collision(r, t_min, hit.time) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | / match self.top.test_collision(r, t_min, hit.time) { [INFO] [stderr] 187 | | Some(h) => { hit = h; }, [INFO] [stderr] 188 | | None => {}, [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.top.test_collision(r, t_min, hit.time) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | / match self.bottom.test_collision(r, t_min, hit.time) { [INFO] [stderr] 191 | | Some(h) => { hit = h; }, [INFO] [stderr] 192 | | None => {}, [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.bottom.test_collision(r, t_min, hit.time) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geometry/cuboid.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | if hit.time == t_max { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(hit.time - t_max).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geometry/cuboid.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | if hit.time == t_max { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/random.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(d) => Rng::new(d.as_secs(), d.subsec_nanos() as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(d.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Could not compile `solaire`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/random.rs:46:36 [INFO] [stderr] | [INFO] [stderr] 46 | let result: f32 = unsafe { mem::transmute(tmp) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(tmp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | file.write("P3\n".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | file.write(format!("{} {}\n", self.width, self.height).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | file.write(format!("{}\n", max_value).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | file.write(rgb.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/image.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | file.write("\n".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `world::World` [INFO] [stderr] --> src/world.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new() -> World { [INFO] [stderr] 63 | | World { [INFO] [stderr] 64 | | objects: Vec::new(), [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `material::NormalSurface` [INFO] [stderr] --> src/material.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> NormalSurface { [INFO] [stderr] 12 | | NormalSurface {} [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | / match self.front.test_collision(r, t_min, t_max) { [INFO] [stderr] 171 | | Some(h) => { hit = h; }, [INFO] [stderr] 172 | | None => {}, [INFO] [stderr] 173 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.front.test_collision(r, t_min, t_max) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / match self.back.test_collision(r, t_min, hit.time) { [INFO] [stderr] 175 | | Some(h) => { hit = h; }, [INFO] [stderr] 176 | | None => {}, [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.back.test_collision(r, t_min, hit.time) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / match self.left.test_collision(r, t_min, hit.time) { [INFO] [stderr] 179 | | Some(h) => { hit = h; }, [INFO] [stderr] 180 | | None => {}, [INFO] [stderr] 181 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.left.test_collision(r, t_min, hit.time) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / match self.right.test_collision(r, t_min, hit.time) { [INFO] [stderr] 183 | | Some(h) => { hit = h; }, [INFO] [stderr] 184 | | None => {}, [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.right.test_collision(r, t_min, hit.time) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | / match self.top.test_collision(r, t_min, hit.time) { [INFO] [stderr] 187 | | Some(h) => { hit = h; }, [INFO] [stderr] 188 | | None => {}, [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.top.test_collision(r, t_min, hit.time) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geometry/cuboid.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | / match self.bottom.test_collision(r, t_min, hit.time) { [INFO] [stderr] 191 | | Some(h) => { hit = h; }, [INFO] [stderr] 192 | | None => {}, [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(h) = self.bottom.test_collision(r, t_min, hit.time) { hit = h; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geometry/cuboid.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | if hit.time == t_max { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(hit.time - t_max).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geometry/cuboid.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | if hit.time == t_max { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `solaire`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7df559df77eca6bb45fcb8c79874cac09e54d8bfe2bfaffd9139306689464c66"` [INFO] running `"docker" "rm" "-f" "7df559df77eca6bb45fcb8c79874cac09e54d8bfe2bfaffd9139306689464c66"` [INFO] [stdout] 7df559df77eca6bb45fcb8c79874cac09e54d8bfe2bfaffd9139306689464c66