[INFO] updating cached repository stisol/rustsweeper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stisol/rustsweeper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stisol/rustsweeper" "work/ex/clippy-test-run/sources/stable/gh/stisol/rustsweeper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stisol/rustsweeper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stisol/rustsweeper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stisol/rustsweeper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stisol/rustsweeper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f2d65d16ff094b636ccd815dd6448a5438f00057 [INFO] sha for GitHub repo stisol/rustsweeper: f2d65d16ff094b636ccd815dd6448a5438f00057 [INFO] validating manifest of stisol/rustsweeper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stisol/rustsweeper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stisol/rustsweeper [INFO] finished frobbing stisol/rustsweeper [INFO] frobbed toml for stisol/rustsweeper written to work/ex/clippy-test-run/sources/stable/gh/stisol/rustsweeper/Cargo.toml [INFO] started frobbing stisol/rustsweeper [INFO] finished frobbing stisol/rustsweeper [INFO] frobbed toml for stisol/rustsweeper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stisol/rustsweeper/Cargo.toml [INFO] crate stisol/rustsweeper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stisol/rustsweeper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stisol/rustsweeper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a2c1710c4f61ec6d879b40341edd26f83edf5aeb482dfa6d5bcea9bdd79ba346 [INFO] running `"docker" "start" "-a" "a2c1710c4f61ec6d879b40341edd26f83edf5aeb482dfa6d5bcea9bdd79ba346"` [INFO] [stderr] Compiling libc v0.2.28 [INFO] [stderr] Compiling num-traits v0.1.40 [INFO] [stderr] Compiling serde v0.9.15 [INFO] [stderr] Compiling khronos_api v1.0.1 [INFO] [stderr] Compiling log v0.3.8 [INFO] [stderr] Checking shader_version v0.2.2 [INFO] [stderr] Checking inflate v0.2.0 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Compiling xml-rs v0.6.1 [INFO] [stderr] Compiling x11-dl v2.14.0 [INFO] [stderr] Checking vecmath v0.3.0 [INFO] [stderr] Checking deflate v0.7.14 [INFO] [stderr] Checking stb_truetype v0.2.1 [INFO] [stderr] Compiling wayland-scanner v0.9.9 [INFO] [stderr] Checking tempfile v2.1.6 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking pistoncore-input v0.18.0 [INFO] [stderr] Checking arrayvec v0.3.23 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking piston2d-graphics v0.21.1 [INFO] [stderr] Compiling wayland-client v0.9.9 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking pistoncore-window v0.27.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking pistoncore-event_loop v0.32.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking piston v0.32.0 [INFO] [stderr] Compiling gl v0.6.3 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.9 [INFO] [stderr] Checking piston2d-opengl_graphics v0.45.0 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.6.1 [INFO] [stderr] Checking winit v0.7.5 [INFO] [stderr] Checking pistoncore-glutin_window v0.38.0 [INFO] [stderr] Checking rustsweeper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_controller.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | gameboard: gameboard, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gameboard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_view.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_view.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | controller: controller, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `controller` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mainmenu.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_controller.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | gameboard: gameboard, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gameboard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_view.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_view.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | controller: controller, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `controller` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mainmenu.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mainmenu.rs:63:32 [INFO] [stderr] | [INFO] [stderr] 63 | windowheight / 10.0 * (index) as f64 + 5.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from((index))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:64:41 [INFO] [stderr] | [INFO] [stderr] 64 | state = mainmenu.event((window.size().width as f64, window.size().height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:64:69 [INFO] [stderr] | [INFO] [stderr] 64 | state = mainmenu.event((window.size().width as f64, window.size().height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:75:29 [INFO] [stderr] | [INFO] [stderr] 75 | .event((window.size().width as f64, window.size().height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:75:57 [INFO] [stderr] | [INFO] [stderr] 75 | .event((window.size().width as f64, window.size().height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/mainmenu.rs:63:32 [INFO] [stderr] | [INFO] [stderr] 63 | windowheight / 10.0 * (index) as f64 + 5.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from((index))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:64:41 [INFO] [stderr] | [INFO] [stderr] 64 | state = mainmenu.event((window.size().width as f64, window.size().height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:64:69 [INFO] [stderr] | [INFO] [stderr] 64 | state = mainmenu.event((window.size().width as f64, window.size().height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:75:29 [INFO] [stderr] | [INFO] [stderr] 75 | .event((window.size().width as f64, window.size().height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:75:57 [INFO] [stderr] | [INFO] [stderr] 75 | .event((window.size().width as f64, window.size().height as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 13s [INFO] running `"docker" "inspect" "a2c1710c4f61ec6d879b40341edd26f83edf5aeb482dfa6d5bcea9bdd79ba346"` [INFO] running `"docker" "rm" "-f" "a2c1710c4f61ec6d879b40341edd26f83edf5aeb482dfa6d5bcea9bdd79ba346"` [INFO] [stdout] a2c1710c4f61ec6d879b40341edd26f83edf5aeb482dfa6d5bcea9bdd79ba346