[INFO] updating cached repository stisol/Horace
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/stisol/Horace
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/stisol/Horace" "work/ex/clippy-test-run/sources/stable/gh/stisol/Horace"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stisol/Horace'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/stisol/Horace" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stisol/Horace"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stisol/Horace'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0fb2d932166c552abd11cac7f1958cf6b8ce781c
[INFO] sha for GitHub repo stisol/Horace: 0fb2d932166c552abd11cac7f1958cf6b8ce781c
[INFO] validating manifest of stisol/Horace on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of stisol/Horace on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing stisol/Horace
[INFO] finished frobbing stisol/Horace
[INFO] frobbed toml for stisol/Horace written to work/ex/clippy-test-run/sources/stable/gh/stisol/Horace/Cargo.toml
[INFO] started frobbing stisol/Horace
[INFO] finished frobbing stisol/Horace
[INFO] frobbed toml for stisol/Horace written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stisol/Horace/Cargo.toml
[INFO] crate stisol/Horace has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting stisol/Horace against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stisol/Horace:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4bda8a7329cb5bb1127f011de2f6042614e93bdb56949532be3011a1c2fe5fa4
[INFO] running `"docker" "start" "-a" "4bda8a7329cb5bb1127f011de2f6042614e93bdb56949532be3011a1c2fe5fa4"`
[INFO] [stderr]     Checking fallible-iterator v0.1.4
[INFO] [stderr]     Checking md5 v0.3.7
[INFO] [stderr]     Checking serde v1.0.38
[INFO] [stderr]    Compiling openssl-sys v0.9.28
[INFO] [stderr]    Compiling miniz-sys v0.1.10
[INFO] [stderr]     Checking memchr v1.0.2
[INFO] [stderr]     Checking socket2 v0.3.4
[INFO] [stderr]     Checking num-integer v0.1.36
[INFO] [stderr]     Checking regex-syntax v0.5.5
[INFO] [stderr]     Checking rand v0.5.0
[INFO] [stderr]     Checking tempdir v0.3.7
[INFO] [stderr]     Checking threadpool v1.7.1
[INFO] [stderr]     Checking stringprep v0.1.2
[INFO] [stderr]     Checking r2d2 v0.8.2
[INFO] [stderr]     Checking mime v0.2.6
[INFO] [stderr]     Checking digest v0.7.2
[INFO] [stderr]     Checking crypto-mac v0.5.2
[INFO] [stderr]    Compiling serde_derive_internals v0.23.1
[INFO] [stderr]    Compiling mime_guess v1.8.4
[INFO] [stderr]    Compiling openssl v0.9.24
[INFO] [stderr]     Checking hmac v0.5.0
[INFO] [stderr]     Checking sha2 v0.7.0
[INFO] [stderr]     Checking hyper v0.10.13
[INFO] [stderr]     Checking flate2 v1.0.1
[INFO] [stderr]     Checking postgres-protocol v0.3.2
[INFO] [stderr]    Compiling serde_derive v1.0.38
[INFO] [stderr]     Checking regex v0.2.10
[INFO] [stderr]     Checking multipart v0.13.6
[INFO] [stderr]     Checking env_logger v0.5.7
[INFO] [stderr]     Checking native-tls v0.1.5
[INFO] [stderr]     Checking evzht9h3nznqzwl v0.0.3
[INFO] [stderr]     Checking hyper-native-tls v0.2.4
[INFO] [stderr]     Checking chrono v0.4.2
[INFO] [stderr]     Checking serde_json v1.0.14
[INFO] [stderr]     Checking postgres-shared v0.4.1
[INFO] [stderr]     Checking serenity v0.5.2
[INFO] [stderr]     Checking postgres v0.15.2
[INFO] [stderr]     Checking r2d2_postgres v0.14.0
[INFO] [stderr]     Checking horace v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/connectionpool.rs:96:17
[INFO] [stderr]    |
[INFO] [stderr] 96 |                 messages: messages,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `messages`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/connectionpool.rs:96:17
[INFO] [stderr]    |
[INFO] [stderr] 96 |                 messages: messages,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `messages`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/util.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     return digits;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `digits`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/util.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     return digits;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `digits`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/commands/admin.rs:10:10
[INFO] [stderr]    |
[INFO] [stderr] 10 |         .ok_or(CommandError::Generic("Could not get channel.".to_owned()))?;
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::Generic("Could not get channel.".to_owned()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/commands/admin.rs:12:10
[INFO] [stderr]    |
[INFO] [stderr] 12 |         .ok_or(CommandError::Generic("Could not get guild channel.".to_owned()))?;
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::Generic("Could not get guild channel.".to_owned()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands/roles.rs:15:8
[INFO] [stderr]    |
[INFO] [stderr] 15 |     if roles.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `roles.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/commands/roles.rs:72:10
[INFO] [stderr]    |
[INFO] [stderr] 72 |         .ok_or(format!("Could not get member from user {}", msg.author.id))?;
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Could not get member from user {}", msg.author.id))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/connectionpool.rs:107:18
[INFO] [stderr]     |
[INFO] [stderr] 107 |         user_id: &UserId,
[INFO] [stderr]     |                  ^^^^^^^ help: consider passing by value instead: `UserId`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/util.rs:19:54
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub fn print_or_log_error(message: &str, channel_id: &ChannelId) {
[INFO] [stderr]    |                                                      ^^^^^^^^^^ help: consider passing by value instead: `ChannelId`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/commands/admin.rs:10:10
[INFO] [stderr]    |
[INFO] [stderr] 10 |         .ok_or(CommandError::Generic("Could not get channel.".to_owned()))?;
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::Generic("Could not get channel.".to_owned()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/commands/admin.rs:12:10
[INFO] [stderr]    |
[INFO] [stderr] 12 |         .ok_or(CommandError::Generic("Could not get guild channel.".to_owned()))?;
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::Generic("Could not get guild channel.".to_owned()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/commands/roles.rs:15:8
[INFO] [stderr]    |
[INFO] [stderr] 15 |     if roles.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `roles.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/commands/roles.rs:72:10
[INFO] [stderr]    |
[INFO] [stderr] 72 |         .ok_or(format!("Could not get member from user {}", msg.author.id))?;
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Could not get member from user {}", msg.author.id))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/connectionpool.rs:107:18
[INFO] [stderr]     |
[INFO] [stderr] 107 |         user_id: &UserId,
[INFO] [stderr]     |                  ^^^^^^^ help: consider passing by value instead: `UserId`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/util.rs:19:54
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub fn print_or_log_error(message: &str, channel_id: &ChannelId) {
[INFO] [stderr]    |                                                      ^^^^^^^^^^ help: consider passing by value instead: `ChannelId`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 10s
[INFO] running `"docker" "inspect" "4bda8a7329cb5bb1127f011de2f6042614e93bdb56949532be3011a1c2fe5fa4"`
[INFO] running `"docker" "rm" "-f" "4bda8a7329cb5bb1127f011de2f6042614e93bdb56949532be3011a1c2fe5fa4"`
[INFO] [stdout] 4bda8a7329cb5bb1127f011de2f6042614e93bdb56949532be3011a1c2fe5fa4