[INFO] updating cached repository sticnarf/tcping-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sticnarf/tcping-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sticnarf/tcping-rs" "work/ex/clippy-test-run/sources/stable/gh/sticnarf/tcping-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sticnarf/tcping-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sticnarf/tcping-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sticnarf/tcping-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sticnarf/tcping-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cc71869b09a6f11bbd89f8e6d7058db6a793b5af [INFO] sha for GitHub repo sticnarf/tcping-rs: cc71869b09a6f11bbd89f8e6d7058db6a793b5af [INFO] validating manifest of sticnarf/tcping-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sticnarf/tcping-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sticnarf/tcping-rs [INFO] finished frobbing sticnarf/tcping-rs [INFO] frobbed toml for sticnarf/tcping-rs written to work/ex/clippy-test-run/sources/stable/gh/sticnarf/tcping-rs/Cargo.toml [INFO] started frobbing sticnarf/tcping-rs [INFO] finished frobbing sticnarf/tcping-rs [INFO] frobbed toml for sticnarf/tcping-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sticnarf/tcping-rs/Cargo.toml [INFO] crate sticnarf/tcping-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sticnarf/tcping-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sticnarf/tcping-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6d9034ce36c52992046bcd2da80b74ac7d094244b684e0414e49d7d1242dbdb [INFO] running `"docker" "start" "-a" "a6d9034ce36c52992046bcd2da80b74ac7d094244b684e0414e49d7d1242dbdb"` [INFO] [stderr] Checking tcping v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Read`, `Write` [INFO] [stderr] --> src/main.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Read`, `Write` [INFO] [stderr] --> src/main.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(mut addrs) => addrs.filter(|addr| addr.is_ipv4()).next().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|addr| addr.is_ipv4()).next()` with `find(|addr| addr.is_ipv4())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | .map(|t| Duration::from_millis(t)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Duration::from_millis` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(mut addrs) => addrs.filter(|addr| addr.is_ipv4()).next().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|addr| addr.is_ipv4()).next()` with `find(|addr| addr.is_ipv4())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | .map(|t| Duration::from_millis(t)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Duration::from_millis` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.21s [INFO] running `"docker" "inspect" "a6d9034ce36c52992046bcd2da80b74ac7d094244b684e0414e49d7d1242dbdb"` [INFO] running `"docker" "rm" "-f" "a6d9034ce36c52992046bcd2da80b74ac7d094244b684e0414e49d7d1242dbdb"` [INFO] [stdout] a6d9034ce36c52992046bcd2da80b74ac7d094244b684e0414e49d7d1242dbdb