[INFO] updating cached repository stevenliatti/tag_manager [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stevenliatti/tag_manager [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stevenliatti/tag_manager" "work/ex/clippy-test-run/sources/stable/gh/stevenliatti/tag_manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevenliatti/tag_manager'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stevenliatti/tag_manager" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevenliatti/tag_manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevenliatti/tag_manager'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 10a14e4dbae17c9f45949ec6f66689634868fd46 [INFO] sha for GitHub repo stevenliatti/tag_manager: 10a14e4dbae17c9f45949ec6f66689634868fd46 [INFO] validating manifest of stevenliatti/tag_manager on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stevenliatti/tag_manager on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stevenliatti/tag_manager [INFO] finished frobbing stevenliatti/tag_manager [INFO] frobbed toml for stevenliatti/tag_manager written to work/ex/clippy-test-run/sources/stable/gh/stevenliatti/tag_manager/Cargo.toml [INFO] started frobbing stevenliatti/tag_manager [INFO] finished frobbing stevenliatti/tag_manager [INFO] frobbed toml for stevenliatti/tag_manager written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevenliatti/tag_manager/Cargo.toml [INFO] crate stevenliatti/tag_manager has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stevenliatti/tag_manager against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stevenliatti/tag_manager:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ebaabbaa0bd21164ef9391ed8332e57e2388c0148277a6ee825bd297f36a113 [INFO] running `"docker" "start" "-a" "2ebaabbaa0bd21164ef9391ed8332e57e2388c0148277a6ee825bd297f36a113"` [INFO] [stderr] Checking xattr v0.2.1 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking tag_manager v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | const SEPARATOR : u8 = ',' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b',' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn set_tags(file: &str, new_tags: &HashSet, recursive: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 32 | pub fn set_tags(file: &str, new_tags: &HashSet, recursive: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:55:43 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn del_tags(file: &str, tags_to_del: &HashSet, recursive: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 55 | pub fn del_tags(file: &str, tags_to_del: &HashSet, recursive: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(res) => match res { [INFO] [stderr] | ____________________^ [INFO] [stderr] 59 | | Some(mut tags) => { [INFO] [stderr] 60 | | // Delete only the given tags [INFO] [stderr] 61 | | for tag in tags_to_del { [INFO] [stderr] ... | [INFO] [stderr] 73 | | }, _ => () [INFO] [stderr] 74 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | Ok(res) => if let Some(mut tags) = res { [INFO] [stderr] 59 | // Delete only the given tags [INFO] [stderr] 60 | for tag in tags_to_del { [INFO] [stderr] 61 | tags.retain(|ref e| e != &tag); [INFO] [stderr] 62 | } [INFO] [stderr] 63 | // To avoid to let an empty array of tags [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(res) => match res { [INFO] [stderr] | ____________________^ [INFO] [stderr] 89 | | Some(mut tags) => { [INFO] [stderr] 90 | | if tags.remove(&old) { [INFO] [stderr] 91 | | tags.insert(new.clone()); [INFO] [stderr] ... | [INFO] [stderr] 96 | | None => () [INFO] [stderr] 97 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | Ok(res) => if let Some(mut tags) = res { [INFO] [stderr] 89 | if tags.remove(&old) { [INFO] [stderr] 90 | tags.insert(new.clone()); [INFO] [stderr] 91 | xattr::set(file, ATTR_NAME, &hash_set_to_vec_u8(&tags)) [INFO] [stderr] 92 | .expect("Error when setting tag(s)"); [INFO] [stderr] 93 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | const SEPARATOR : u8 = ',' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b',' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn set_tags(file: &str, new_tags: &HashSet, recursive: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 32 | pub fn set_tags(file: &str, new_tags: &HashSet, recursive: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/lib.rs:55:43 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn del_tags(file: &str, tags_to_del: &HashSet, recursive: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 55 | pub fn del_tags(file: &str, tags_to_del: &HashSet, recursive: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(res) => match res { [INFO] [stderr] | ____________________^ [INFO] [stderr] 59 | | Some(mut tags) => { [INFO] [stderr] 60 | | // Delete only the given tags [INFO] [stderr] 61 | | for tag in tags_to_del { [INFO] [stderr] ... | [INFO] [stderr] 73 | | }, _ => () [INFO] [stderr] 74 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | Ok(res) => if let Some(mut tags) = res { [INFO] [stderr] 59 | // Delete only the given tags [INFO] [stderr] 60 | for tag in tags_to_del { [INFO] [stderr] 61 | tags.retain(|ref e| e != &tag); [INFO] [stderr] 62 | } [INFO] [stderr] 63 | // To avoid to let an empty array of tags [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(res) => match res { [INFO] [stderr] | ____________________^ [INFO] [stderr] 89 | | Some(mut tags) => { [INFO] [stderr] 90 | | if tags.remove(&old) { [INFO] [stderr] 91 | | tags.insert(new.clone()); [INFO] [stderr] ... | [INFO] [stderr] 96 | | None => () [INFO] [stderr] 97 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | Ok(res) => if let Some(mut tags) = res { [INFO] [stderr] 89 | if tags.remove(&old) { [INFO] [stderr] 90 | tags.insert(new.clone()); [INFO] [stderr] 91 | xattr::set(file, ATTR_NAME, &hash_set_to_vec_u8(&tags)) [INFO] [stderr] 92 | .expect("Error when setting tag(s)"); [INFO] [stderr] 93 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.11s [INFO] running `"docker" "inspect" "2ebaabbaa0bd21164ef9391ed8332e57e2388c0148277a6ee825bd297f36a113"` [INFO] running `"docker" "rm" "-f" "2ebaabbaa0bd21164ef9391ed8332e57e2388c0148277a6ee825bd297f36a113"` [INFO] [stdout] 2ebaabbaa0bd21164ef9391ed8332e57e2388c0148277a6ee825bd297f36a113