[INFO] updating cached repository steveklabnik/not-the-rust-blog [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/steveklabnik/not-the-rust-blog [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/steveklabnik/not-the-rust-blog" "work/ex/clippy-test-run/sources/stable/gh/steveklabnik/not-the-rust-blog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/steveklabnik/not-the-rust-blog'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/steveklabnik/not-the-rust-blog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steveklabnik/not-the-rust-blog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steveklabnik/not-the-rust-blog'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2cd04cc291ec294d5a54f33677e4dae32b82f692 [INFO] sha for GitHub repo steveklabnik/not-the-rust-blog: 2cd04cc291ec294d5a54f33677e4dae32b82f692 [INFO] validating manifest of steveklabnik/not-the-rust-blog on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of steveklabnik/not-the-rust-blog on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing steveklabnik/not-the-rust-blog [INFO] finished frobbing steveklabnik/not-the-rust-blog [INFO] frobbed toml for steveklabnik/not-the-rust-blog written to work/ex/clippy-test-run/sources/stable/gh/steveklabnik/not-the-rust-blog/Cargo.toml [INFO] started frobbing steveklabnik/not-the-rust-blog [INFO] finished frobbing steveklabnik/not-the-rust-blog [INFO] frobbed toml for steveklabnik/not-the-rust-blog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steveklabnik/not-the-rust-blog/Cargo.toml [INFO] crate steveklabnik/not-the-rust-blog has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting steveklabnik/not-the-rust-blog against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/steveklabnik/not-the-rust-blog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e436268a2cb468c0d1cb7362eb4c5b143f213ad18c21250f29c2bf50b8e408c1 [INFO] running `"docker" "start" "-a" "e436268a2cb468c0d1cb7362eb4c5b143f213ad18c21250f29c2bf50b8e408c1"` [INFO] [stderr] Checking entities v1.0.1 [INFO] [stderr] Checking typed-arena v1.4.1 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking fs_extra v1.1.0 [INFO] [stderr] Compiling sass-sys v0.4.7 [INFO] [stderr] Checking serde_yaml v0.8.8 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking comrak v0.4.0 [INFO] [stderr] Checking sass-rs v0.2.1 [INFO] [stderr] Checking blog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:72:48 [INFO] [stderr] | [INFO] [stderr] 72 | let mut split = filename.splitn(4, "-"); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | .expect(&format!("couldn't compile sass: {}", &scss_file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't compile sass: {}", &scss_file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:146:37 [INFO] [stderr] | [INFO] [stderr] 146 | File::create(&css_file).expect(&format!("couldn't make css file: {}", &css_file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't make css file: {}", &css_file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:148:14 [INFO] [stderr] | [INFO] [stderr] 148 | .expect(&format!("couldn't write css file: {}", &css_file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't write css file: {}", &css_file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:72:48 [INFO] [stderr] | [INFO] [stderr] 72 | let mut split = filename.splitn(4, "-"); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | .expect(&format!("couldn't compile sass: {}", &scss_file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't compile sass: {}", &scss_file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:146:37 [INFO] [stderr] | [INFO] [stderr] 146 | File::create(&css_file).expect(&format!("couldn't make css file: {}", &css_file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't make css file: {}", &css_file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:148:14 [INFO] [stderr] | [INFO] [stderr] 148 | .expect(&format!("couldn't write css file: {}", &css_file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't write css file: {}", &css_file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 18s [INFO] running `"docker" "inspect" "e436268a2cb468c0d1cb7362eb4c5b143f213ad18c21250f29c2bf50b8e408c1"` [INFO] running `"docker" "rm" "-f" "e436268a2cb468c0d1cb7362eb4c5b143f213ad18c21250f29c2bf50b8e408c1"` [INFO] [stdout] e436268a2cb468c0d1cb7362eb4c5b143f213ad18c21250f29c2bf50b8e408c1