[INFO] updating cached repository stevedonovan/findr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stevedonovan/findr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stevedonovan/findr" "work/ex/clippy-test-run/sources/stable/gh/stevedonovan/findr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevedonovan/findr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stevedonovan/findr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevedonovan/findr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevedonovan/findr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6a4c0cce6a3a1bb5ec06be35dd9ac46b5a25bf2c [INFO] sha for GitHub repo stevedonovan/findr: 6a4c0cce6a3a1bb5ec06be35dd9ac46b5a25bf2c [INFO] validating manifest of stevedonovan/findr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stevedonovan/findr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stevedonovan/findr [INFO] finished frobbing stevedonovan/findr [INFO] frobbed toml for stevedonovan/findr written to work/ex/clippy-test-run/sources/stable/gh/stevedonovan/findr/Cargo.toml [INFO] started frobbing stevedonovan/findr [INFO] finished frobbing stevedonovan/findr [INFO] frobbed toml for stevedonovan/findr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevedonovan/findr/Cargo.toml [INFO] crate stevedonovan/findr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stevedonovan/findr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stevedonovan/findr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a60b29e23f6f23c15a5c36596410a71de7b20d6d380a0c5a8263dda0f1465cd [INFO] running `"docker" "start" "-a" "7a60b29e23f6f23c15a5c36596410a71de7b20d6d380a0c5a8263dda0f1465cd"` [INFO] [stderr] Checking same-file v1.0.2 [INFO] [stderr] Checking scanlex v0.1.2 [INFO] [stderr] Checking lapp v0.3.1 [INFO] [stderr] Checking rhai v0.8.2 [INFO] [stderr] Checking regex-syntax v0.5.5 [INFO] [stderr] Checking chrono v0.4.1 [INFO] [stderr] Checking walkdir v2.1.4 [INFO] [stderr] Checking chrono-english v0.1.2 [INFO] [stderr] Checking regex v0.2.10 [INFO] [stderr] Checking globset v0.4.0 [INFO] [stderr] Checking ignore v0.4.2 [INFO] [stderr] Checking findr v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | entry: entry, metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:135:27 [INFO] [stderr] | [INFO] [stderr] 135 | entry: entry, metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | globs: globs [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `globs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:329:33 [INFO] [stderr] | [INFO] [stderr] 329 | write!(out,"{}\n", path.display())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | entry: entry, metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:135:27 [INFO] [stderr] | [INFO] [stderr] 135 | entry: entry, metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | globs: globs [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `globs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:329:33 [INFO] [stderr] | [INFO] [stderr] 329 | write!(out,"{}\n", path.display())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/preprocess.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | return "".into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"".into()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | / if filter == "true" || filter == "none" || filter == "dir" || filter == "run" { [INFO] [stderr] 259 | | if ! (base.exists() && base.is_dir()) { [INFO] [stderr] 260 | | let glob = base.to_str().expect("can't get path as string").to_string(); [INFO] [stderr] 261 | | command = run.clone(); [INFO] [stderr] ... | [INFO] [stderr] 265 | | } [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 258 | if (filter == "true" || filter == "none" || filter == "dir" || filter == "run") && ! (base.exists() && base.is_dir()) { [INFO] [stderr] 259 | let glob = base.to_str().expect("can't get path as string").to_string(); [INFO] [stderr] 260 | command = run.clone(); [INFO] [stderr] 261 | run = filter.clone(); [INFO] [stderr] 262 | filter = preprocess::preprocess_quick_filter(&glob, args.get_bool("case-insensitive")); [INFO] [stderr] 263 | base = PathBuf::from("."); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/preprocess.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | return "".into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"".into()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | / if filter == "true" || filter == "none" || filter == "dir" || filter == "run" { [INFO] [stderr] 259 | | if ! (base.exists() && base.is_dir()) { [INFO] [stderr] 260 | | let glob = base.to_str().expect("can't get path as string").to_string(); [INFO] [stderr] 261 | | command = run.clone(); [INFO] [stderr] ... | [INFO] [stderr] 265 | | } [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 258 | if (filter == "true" || filter == "none" || filter == "dir" || filter == "run") && ! (base.exists() && base.is_dir()) { [INFO] [stderr] 259 | let glob = base.to_str().expect("can't get path as string").to_string(); [INFO] [stderr] 260 | command = run.clone(); [INFO] [stderr] 261 | run = filter.clone(); [INFO] [stderr] 262 | filter = preprocess::preprocess_quick_filter(&glob, args.get_bool("case-insensitive")); [INFO] [stderr] 263 | base = PathBuf::from("."); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if rest.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command.rs:31:8 [INFO] [stderr] | [INFO] [stderr] 31 | if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/command.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | command = command + " %(path.path)"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command += " %(path.path)"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/preprocess.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | if patterns.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!patterns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/preprocess.rs:174:8 [INFO] [stderr] | [INFO] [stderr] 174 | if rest.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | (m.mode() & 0o777) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(m.mode() & 0o777)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:145:16 [INFO] [stderr] | [INFO] [stderr] 145 | fn is_file(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:149:15 [INFO] [stderr] | [INFO] [stderr] 149 | fn is_dir(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | fn is_exec(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | fn is_write(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:184:36 [INFO] [stderr] | [INFO] [stderr] 184 | self.entry.path().parent().unwrap_or(Path::new(".")).display().to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | let ref pattern = self.globs[idx as usize].0; [INFO] [stderr] | ----^^^^^^^^^^^------------------------------ help: try: `let pattern = &self.globs[idx as usize].0;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | let ref options = match self.globs[idx as usize].1 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 190 | let options = &(match self.globs[idx as usize].1 { [INFO] [stderr] 191 | GlobIgnoreCase::CaseSensitive => MatchOptions::new(), [INFO] [stderr] 192 | GlobIgnoreCase::CaseInsensitive => MatchOptions::default(), [INFO] [stderr] 193 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:317:36 [INFO] [stderr] | [INFO] [stderr] 317 | if let Some(_) = command { [INFO] [stderr] | _____________________________- ^^^^^^^ [INFO] [stderr] 318 | | let s = engine.call_fn::<_,_,String>("cmd",(&mut path_obj,&mut date_obj))?; [INFO] [stderr] 319 | | if run == "dir" { [INFO] [stderr] 320 | | if let Some(parent) = path.parent() { [INFO] [stderr] ... | [INFO] [stderr] 329 | | write!(out,"{}\n", path.display())?; [INFO] [stderr] 330 | | } [INFO] [stderr] | |_____________________________- help: try this: `if command.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if rest.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command.rs:31:8 [INFO] [stderr] | [INFO] [stderr] 31 | if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/command.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | command = command + " %(path.path)"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command += " %(path.path)"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/preprocess.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | if patterns.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!patterns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/preprocess.rs:174:8 [INFO] [stderr] | [INFO] [stderr] 174 | if rest.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | (m.mode() & 0o777) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(m.mode() & 0o777)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:145:16 [INFO] [stderr] | [INFO] [stderr] 145 | fn is_file(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:149:15 [INFO] [stderr] | [INFO] [stderr] 149 | fn is_dir(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | fn is_exec(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | fn is_write(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:184:36 [INFO] [stderr] | [INFO] [stderr] 184 | self.entry.path().parent().unwrap_or(Path::new(".")).display().to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | let ref pattern = self.globs[idx as usize].0; [INFO] [stderr] | ----^^^^^^^^^^^------------------------------ help: try: `let pattern = &self.globs[idx as usize].0;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | let ref options = match self.globs[idx as usize].1 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 190 | let options = &(match self.globs[idx as usize].1 { [INFO] [stderr] 191 | GlobIgnoreCase::CaseSensitive => MatchOptions::new(), [INFO] [stderr] 192 | GlobIgnoreCase::CaseInsensitive => MatchOptions::default(), [INFO] [stderr] 193 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:317:36 [INFO] [stderr] | [INFO] [stderr] 317 | if let Some(_) = command { [INFO] [stderr] | _____________________________- ^^^^^^^ [INFO] [stderr] 318 | | let s = engine.call_fn::<_,_,String>("cmd",(&mut path_obj,&mut date_obj))?; [INFO] [stderr] 319 | | if run == "dir" { [INFO] [stderr] 320 | | if let Some(parent) = path.parent() { [INFO] [stderr] ... | [INFO] [stderr] 329 | | write!(out,"{}\n", path.display())?; [INFO] [stderr] 330 | | } [INFO] [stderr] | |_____________________________- help: try this: `if command.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.34s [INFO] running `"docker" "inspect" "7a60b29e23f6f23c15a5c36596410a71de7b20d6d380a0c5a8263dda0f1465cd"` [INFO] running `"docker" "rm" "-f" "7a60b29e23f6f23c15a5c36596410a71de7b20d6d380a0c5a8263dda0f1465cd"` [INFO] [stdout] 7a60b29e23f6f23c15a5c36596410a71de7b20d6d380a0c5a8263dda0f1465cd