[INFO] updating cached repository stevedonovan/cargo-docgen
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/stevedonovan/cargo-docgen
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/stevedonovan/cargo-docgen" "work/ex/clippy-test-run/sources/stable/gh/stevedonovan/cargo-docgen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevedonovan/cargo-docgen'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/stevedonovan/cargo-docgen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevedonovan/cargo-docgen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevedonovan/cargo-docgen'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3598d7173046cb4f4eabd780361d7acdd9126daf
[INFO] sha for GitHub repo stevedonovan/cargo-docgen: 3598d7173046cb4f4eabd780361d7acdd9126daf
[INFO] validating manifest of stevedonovan/cargo-docgen on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of stevedonovan/cargo-docgen on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing stevedonovan/cargo-docgen
[INFO] finished frobbing stevedonovan/cargo-docgen
[INFO] frobbed toml for stevedonovan/cargo-docgen written to work/ex/clippy-test-run/sources/stable/gh/stevedonovan/cargo-docgen/Cargo.toml
[INFO] started frobbing stevedonovan/cargo-docgen
[INFO] finished frobbing stevedonovan/cargo-docgen
[INFO] frobbed toml for stevedonovan/cargo-docgen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevedonovan/cargo-docgen/Cargo.toml
[INFO] crate stevedonovan/cargo-docgen has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting stevedonovan/cargo-docgen against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stevedonovan/cargo-docgen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 75270042ca5939c89f873dc4fc221094fd76e6d3fec871b9ca29236145148a5a
[INFO] running `"docker" "start" "-a" "75270042ca5939c89f873dc4fc221094fd76e6d3fec871b9ca29236145148a5a"`
[INFO] [stderr]     Checking easy-shortcuts v0.2.0
[INFO] [stderr]     Checking lapp v0.3.0
[INFO] [stderr]     Checking cargo-docgen v0.1.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/example.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             config: config,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/example.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |             before: before,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `before`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/example.rs:76:13
[INFO] [stderr]    |
[INFO] [stderr] 76 |             after: after,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `after`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:37:21
[INFO] [stderr]    |
[INFO] [stderr] 37 |         Ok(RustFile{path: path})
[INFO] [stderr]    |                     ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:99:13
[INFO] [stderr]    |
[INFO] [stderr] 99 |             crate_name: crate_name,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crate_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             examples: examples,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `examples`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             args: args,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/example.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             config: config,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/example.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |             before: before,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `before`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/example.rs:76:13
[INFO] [stderr]    |
[INFO] [stderr] 76 |             after: after,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `after`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:37:21
[INFO] [stderr]    |
[INFO] [stderr] 37 |         Ok(RustFile{path: path})
[INFO] [stderr]    |                     ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/config.rs:99:13
[INFO] [stderr]    |
[INFO] [stderr] 99 |             crate_name: crate_name,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crate_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             examples: examples,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `examples`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             args: args,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/example.rs:36:32
[INFO] [stderr]    |
[INFO] [stderr] 36 |         while let Some(line) = iter.next() {
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: try: `for line in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/example.rs:73:19
[INFO] [stderr]    |
[INFO] [stderr] 73 |             code: code.into(),
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: consider removing `.into()`: `code`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/example.rs:102:12
[INFO] [stderr]     |
[INFO] [stderr] 102 |         if self.example.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.example.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/config.rs:143:17
[INFO] [stderr]     |
[INFO] [stderr] 143 |                 crate_name.replace('-',"_").into(), // to make Rust happy...
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `crate_name.replace('-',"_")`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:155:40
[INFO] [stderr]     |
[INFO] [stderr] 155 |     let (num,postfix) = if s.ends_with("t") {
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `'t'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:29:16
[INFO] [stderr]    |
[INFO] [stderr] 29 |             if stdout.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stdout.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:73:20
[INFO] [stderr]    |
[INFO] [stderr] 73 |                 if stdout.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stdout.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/example.rs:36:32
[INFO] [stderr]    |
[INFO] [stderr] 36 |         while let Some(line) = iter.next() {
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: try: `for line in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/example.rs:73:19
[INFO] [stderr]    |
[INFO] [stderr] 73 |             code: code.into(),
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: consider removing `.into()`: `code`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/example.rs:102:12
[INFO] [stderr]     |
[INFO] [stderr] 102 |         if self.example.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.example.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/config.rs:143:17
[INFO] [stderr]     |
[INFO] [stderr] 143 |                 crate_name.replace('-',"_").into(), // to make Rust happy...
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `crate_name.replace('-',"_")`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:155:40
[INFO] [stderr]     |
[INFO] [stderr] 155 |     let (num,postfix) = if s.ends_with("t") {
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `'t'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:29:16
[INFO] [stderr]    |
[INFO] [stderr] 29 |             if stdout.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stdout.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:73:20
[INFO] [stderr]    |
[INFO] [stderr] 73 |                 if stdout.len() > 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stdout.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.54s
[INFO] running `"docker" "inspect" "75270042ca5939c89f873dc4fc221094fd76e6d3fec871b9ca29236145148a5a"`
[INFO] running `"docker" "rm" "-f" "75270042ca5939c89f873dc4fc221094fd76e6d3fec871b9ca29236145148a5a"`
[INFO] [stdout] 75270042ca5939c89f873dc4fc221094fd76e6d3fec871b9ca29236145148a5a