[INFO] updating cached repository stevebob/wfc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stevebob/wfc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/wfc" "work/ex/clippy-test-run/sources/stable/gh/stevebob/wfc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevebob/wfc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/wfc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/wfc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/wfc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 77216744047e863632f4794839e50ca712968cfe [INFO] sha for GitHub repo stevebob/wfc: 77216744047e863632f4794839e50ca712968cfe [INFO] validating manifest of stevebob/wfc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stevebob/wfc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stevebob/wfc [INFO] finished frobbing stevebob/wfc [INFO] frobbed toml for stevebob/wfc written to work/ex/clippy-test-run/sources/stable/gh/stevebob/wfc/Cargo.toml [INFO] started frobbing stevebob/wfc [INFO] finished frobbing stevebob/wfc [INFO] frobbed toml for stevebob/wfc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/wfc/Cargo.toml [INFO] crate stevebob/wfc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stevebob/wfc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stevebob/wfc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f80724ff150aa27c3f7e47fb6afde72cde8df0185d6fa10f967ed5bee9ee05b [INFO] running `"docker" "start" "-a" "7f80724ff150aa27c3f7e47fb6afde72cde8df0185d6fa10f967ed5bee9ee05b"` [INFO] [stderr] Compiling proc-macro2 v0.4.21 [INFO] [stderr] Compiling num-rational v0.2.1 [INFO] [stderr] Checking coord_2d v0.2.0 [INFO] [stderr] Checking hashbrown v0.1.6 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking direction v0.17.2 [INFO] [stderr] Checking grid_2d v0.11.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking wfc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/context.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | return Ordering::Greater; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/context.rs:474:13 [INFO] [stderr] | [INFO] [stderr] 474 | / if pattern_id as PatternId != chosen_pattern_id { [INFO] [stderr] 475 | | if *is_possible { [INFO] [stderr] 476 | | *is_possible = false; [INFO] [stderr] 477 | | wave_cell [INFO] [stderr] ... | [INFO] [stderr] 481 | | } [INFO] [stderr] 482 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 474 | if pattern_id as PatternId != chosen_pattern_id && *is_possible { [INFO] [stderr] 475 | *is_possible = false; [INFO] [stderr] 476 | wave_cell [INFO] [stderr] 477 | .metadata [INFO] [stderr] 478 | .remove_possible_pattern(pattern_stats); [INFO] [stderr] 479 | propagator.add(coord, pattern_id as PatternId); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/context.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | return Ordering::Greater; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/context.rs:474:13 [INFO] [stderr] | [INFO] [stderr] 474 | / if pattern_id as PatternId != chosen_pattern_id { [INFO] [stderr] 475 | | if *is_possible { [INFO] [stderr] 476 | | *is_possible = false; [INFO] [stderr] 477 | | wave_cell [INFO] [stderr] ... | [INFO] [stderr] 481 | | } [INFO] [stderr] 482 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 474 | if pattern_id as PatternId != chosen_pattern_id && *is_possible { [INFO] [stderr] 475 | *is_possible = false; [INFO] [stderr] 476 | wave_cell [INFO] [stderr] 477 | .metadata [INFO] [stderr] 478 | .remove_possible_pattern(pattern_stats); [INFO] [stderr] 479 | propagator.add(coord, pattern_id as PatternId); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `WrapX` [INFO] [stderr] --> src/context.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub struct WrapX; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `WrapY` [INFO] [stderr] --> src/context.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub struct WrapY; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `WrapXY` [INFO] [stderr] --> src/context.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub struct WrapXY; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_pattern` [INFO] [stderr] --> src/context.rs:441:5 [INFO] [stderr] | [INFO] [stderr] 441 | / fn set_pattern( [INFO] [stderr] 442 | | &mut self, [INFO] [stderr] 443 | | coord: Coord, [INFO] [stderr] 444 | | pattern_id: PatternId, [INFO] [stderr] ... | [INFO] [stderr] 459 | | } [INFO] [stderr] 460 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `output_wrap` [INFO] [stderr] --> src/context.rs:603:5 [INFO] [stderr] | [INFO] [stderr] 603 | output_wrap: W, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_pattern` [INFO] [stderr] --> src/context.rs:610:5 [INFO] [stderr] | [INFO] [stderr] 610 | pub fn set_pattern(&mut self, coord: Coord, pattern_id: PatternId) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fixed_rng` [INFO] [stderr] --> src/main.rs:207:1 [INFO] [stderr] | [INFO] [stderr] 207 | fn fixed_rng() -> XorShiftRng { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_pattern` [INFO] [stderr] --> src/context.rs:441:5 [INFO] [stderr] | [INFO] [stderr] 441 | / fn set_pattern( [INFO] [stderr] 442 | | &mut self, [INFO] [stderr] 443 | | coord: Coord, [INFO] [stderr] 444 | | pattern_id: PatternId, [INFO] [stderr] ... | [INFO] [stderr] 459 | | } [INFO] [stderr] 460 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `output_wrap` [INFO] [stderr] --> src/context.rs:603:5 [INFO] [stderr] | [INFO] [stderr] 603 | output_wrap: W, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_pattern` [INFO] [stderr] --> src/context.rs:610:5 [INFO] [stderr] | [INFO] [stderr] 610 | pub fn set_pattern(&mut self, coord: Coord, pattern_id: PatternId) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fixed_rng` [INFO] [stderr] --> src/main.rs:207:1 [INFO] [stderr] | [INFO] [stderr] 207 | fn fixed_rng() -> XorShiftRng { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.30s [INFO] running `"docker" "inspect" "7f80724ff150aa27c3f7e47fb6afde72cde8df0185d6fa10f967ed5bee9ee05b"` [INFO] running `"docker" "rm" "-f" "7f80724ff150aa27c3f7e47fb6afde72cde8df0185d6fa10f967ed5bee9ee05b"` [INFO] [stdout] 7f80724ff150aa27c3f7e47fb6afde72cde8df0185d6fa10f967ed5bee9ee05b