[INFO] updating cached repository stevebob/walls-experiment [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stevebob/walls-experiment [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/walls-experiment" "work/ex/clippy-test-run/sources/stable/gh/stevebob/walls-experiment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevebob/walls-experiment'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/walls-experiment" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/walls-experiment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/walls-experiment'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec804cd8c026fa346a60cb11cab3e3db9f9c6d2c [INFO] sha for GitHub repo stevebob/walls-experiment: ec804cd8c026fa346a60cb11cab3e3db9f9c6d2c [INFO] validating manifest of stevebob/walls-experiment on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stevebob/walls-experiment on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stevebob/walls-experiment [INFO] finished frobbing stevebob/walls-experiment [INFO] frobbed toml for stevebob/walls-experiment written to work/ex/clippy-test-run/sources/stable/gh/stevebob/walls-experiment/Cargo.toml [INFO] started frobbing stevebob/walls-experiment [INFO] finished frobbing stevebob/walls-experiment [INFO] frobbed toml for stevebob/walls-experiment written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/walls-experiment/Cargo.toml [INFO] crate stevebob/walls-experiment has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stevebob/walls-experiment against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stevebob/walls-experiment:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1edbefdf20a5bfbc78dcc9f79afe6f9f588f99d91b58063ddb15985d1c0fea35 [INFO] running `"docker" "start" "-a" "1edbefdf20a5bfbc78dcc9f79afe6f9f588f99d91b58063ddb15985d1c0fea35"` [INFO] [stderr] Compiling cgmath v0.16.1 [INFO] [stderr] Checking grid_2d v0.9.1 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking x11-dl v2.18.3 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Compiling derivative v1.0.1 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking direction v0.16.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking wayland-client v0.20.12 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking wayland-protocols v0.20.12 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking glutin v0.18.0 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_glutin v0.26.0 [INFO] [stderr] Checking walls-experiment v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/main.rs:266:18 [INFO] [stderr] | [INFO] [stderr] 266 | indices: indices.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/main.rs:321:18 [INFO] [stderr] | [INFO] [stderr] 321 | indices: indices.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:547:16 [INFO] [stderr] | [INFO] [stderr] 547 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:646:41 [INFO] [stderr] | [INFO] [stderr] 646 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 647 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 648 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 649 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 703 | | _ => (), [INFO] [stderr] 704 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 646 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 647 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 648 | running = false; [INFO] [stderr] 649 | } [INFO] [stderr] 650 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 651 | if let Some(virtual_keycode) = input.virtual_keycode { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/main.rs:266:18 [INFO] [stderr] | [INFO] [stderr] 266 | indices: indices.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/main.rs:321:18 [INFO] [stderr] | [INFO] [stderr] 321 | indices: indices.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:547:16 [INFO] [stderr] | [INFO] [stderr] 547 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:646:41 [INFO] [stderr] | [INFO] [stderr] 646 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 647 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 648 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 649 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 703 | | _ => (), [INFO] [stderr] 704 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 646 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 647 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 648 | running = false; [INFO] [stderr] 649 | } [INFO] [stderr] 650 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 651 | if let Some(virtual_keycode) = input.virtual_keycode { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 17s [INFO] running `"docker" "inspect" "1edbefdf20a5bfbc78dcc9f79afe6f9f588f99d91b58063ddb15985d1c0fea35"` [INFO] running `"docker" "rm" "-f" "1edbefdf20a5bfbc78dcc9f79afe6f9f588f99d91b58063ddb15985d1c0fea35"` [INFO] [stdout] 1edbefdf20a5bfbc78dcc9f79afe6f9f588f99d91b58063ddb15985d1c0fea35