[INFO] updating cached repository stevebob/realtime-game-experiment [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stevebob/realtime-game-experiment [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/realtime-game-experiment" "work/ex/clippy-test-run/sources/stable/gh/stevebob/realtime-game-experiment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevebob/realtime-game-experiment'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/realtime-game-experiment" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/realtime-game-experiment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/realtime-game-experiment'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 22e7e58ff6dce1c67762c072312f5ab621e8cd2c [INFO] sha for GitHub repo stevebob/realtime-game-experiment: 22e7e58ff6dce1c67762c072312f5ab621e8cd2c [INFO] validating manifest of stevebob/realtime-game-experiment on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stevebob/realtime-game-experiment on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stevebob/realtime-game-experiment [INFO] finished frobbing stevebob/realtime-game-experiment [INFO] frobbed toml for stevebob/realtime-game-experiment written to work/ex/clippy-test-run/sources/stable/gh/stevebob/realtime-game-experiment/Cargo.toml [INFO] started frobbing stevebob/realtime-game-experiment [INFO] finished frobbing stevebob/realtime-game-experiment [INFO] frobbed toml for stevebob/realtime-game-experiment written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/realtime-game-experiment/Cargo.toml [INFO] crate stevebob/realtime-game-experiment has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stevebob/realtime-game-experiment against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stevebob/realtime-game-experiment:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 762d23f03c56ea1f52bb73a0a891d746761ef9857355aebe22b67374579b3d62 [INFO] running `"docker" "start" "-a" "762d23f03c56ea1f52bb73a0a891d746761ef9857355aebe22b67374579b3d62"` [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling x11-dl v2.17.5 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking uuid v0.6.3 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Checking tempfile v3.0.2 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Checking libudev-sys v0.1.4 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.15.0 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking gilrs v0.6.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.13.1 [INFO] [stderr] Checking gfx_device_gl v0.15.2 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_glutin v0.23.0 [INFO] [stderr] Checking realtime-game-experiment v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: struct is never constructed: `AabbSplitFour` [INFO] [stderr] --> src/aabb.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub struct AabbSplitFour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/aabb.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new(top_left_coord: Vector2, size: Vector2) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_centre_and_half_size` [INFO] [stderr] --> src/aabb.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn from_centre_and_half_size( [INFO] [stderr] 24 | | centre: Vector2, [INFO] [stderr] 25 | | half_size: Vector2, [INFO] [stderr] 26 | | ) -> Self { [INFO] [stderr] ... | [INFO] [stderr] 29 | | Self::new(top_left_coord, size) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_intersecting` [INFO] [stderr] --> src/aabb.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn is_intersecting(&self, other: &Aabb) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `centre` [INFO] [stderr] --> src/aabb.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn centre(&self) -> Vector2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `split_four` [INFO] [stderr] --> src/aabb.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn split_four(&self) -> AabbSplitFour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `double_about_centre` [INFO] [stderr] --> src/aabb.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn double_about_centre(&self) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `entity_id_allocator` [INFO] [stderr] --> src/game.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | entity_id_allocator: EntityIdAllocator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:33 [INFO] [stderr] | [INFO] [stderr] 113 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:54 [INFO] [stderr] | [INFO] [stderr] 113 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:175:41 [INFO] [stderr] | [INFO] [stderr] 175 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 176 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 177 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 178 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 202 | | _ => (), [INFO] [stderr] 203 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 176 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 177 | running = false; [INFO] [stderr] 178 | } [INFO] [stderr] 179 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 180 | if let Some(virtual_keycode) = input.virtual_keycode { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `AabbSplitFour` [INFO] [stderr] --> src/aabb.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub struct AabbSplitFour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/aabb.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new(top_left_coord: Vector2, size: Vector2) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_centre_and_half_size` [INFO] [stderr] --> src/aabb.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn from_centre_and_half_size( [INFO] [stderr] 24 | | centre: Vector2, [INFO] [stderr] 25 | | half_size: Vector2, [INFO] [stderr] 26 | | ) -> Self { [INFO] [stderr] ... | [INFO] [stderr] 29 | | Self::new(top_left_coord, size) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_intersecting` [INFO] [stderr] --> src/aabb.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn is_intersecting(&self, other: &Aabb) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `centre` [INFO] [stderr] --> src/aabb.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn centre(&self) -> Vector2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `split_four` [INFO] [stderr] --> src/aabb.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn split_four(&self) -> AabbSplitFour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `double_about_centre` [INFO] [stderr] --> src/aabb.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn double_about_centre(&self) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `entity_id_allocator` [INFO] [stderr] --> src/game.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | entity_id_allocator: EntityIdAllocator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:33 [INFO] [stderr] | [INFO] [stderr] 113 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:113:54 [INFO] [stderr] | [INFO] [stderr] 113 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:175:41 [INFO] [stderr] | [INFO] [stderr] 175 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 176 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 177 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 178 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 202 | | _ => (), [INFO] [stderr] 203 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 176 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 177 | running = false; [INFO] [stderr] 178 | } [INFO] [stderr] 179 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 180 | if let Some(virtual_keycode) = input.virtual_keycode { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 25s [INFO] running `"docker" "inspect" "762d23f03c56ea1f52bb73a0a891d746761ef9857355aebe22b67374579b3d62"` [INFO] running `"docker" "rm" "-f" "762d23f03c56ea1f52bb73a0a891d746761ef9857355aebe22b67374579b3d62"` [INFO] [stdout] 762d23f03c56ea1f52bb73a0a891d746761ef9857355aebe22b67374579b3d62