[INFO] updating cached repository stevebob/pixel-shadow-experiment [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stevebob/pixel-shadow-experiment [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/pixel-shadow-experiment" "work/ex/clippy-test-run/sources/stable/gh/stevebob/pixel-shadow-experiment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevebob/pixel-shadow-experiment'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/pixel-shadow-experiment" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/pixel-shadow-experiment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/pixel-shadow-experiment'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 50f1d33273fbbeccd21e609d62e493930b993174 [INFO] sha for GitHub repo stevebob/pixel-shadow-experiment: 50f1d33273fbbeccd21e609d62e493930b993174 [INFO] validating manifest of stevebob/pixel-shadow-experiment on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stevebob/pixel-shadow-experiment on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stevebob/pixel-shadow-experiment [INFO] finished frobbing stevebob/pixel-shadow-experiment [INFO] frobbed toml for stevebob/pixel-shadow-experiment written to work/ex/clippy-test-run/sources/stable/gh/stevebob/pixel-shadow-experiment/Cargo.toml [INFO] started frobbing stevebob/pixel-shadow-experiment [INFO] finished frobbing stevebob/pixel-shadow-experiment [INFO] frobbed toml for stevebob/pixel-shadow-experiment written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/pixel-shadow-experiment/Cargo.toml [INFO] crate stevebob/pixel-shadow-experiment has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stevebob/pixel-shadow-experiment against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stevebob/pixel-shadow-experiment:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 476d3eaa2077fd92611ece7b100e1a270edbc0156b79c627f4eb197546d51345 [INFO] running `"docker" "start" "-a" "476d3eaa2077fd92611ece7b100e1a270edbc0156b79c627f4eb197546d51345"` [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Checking inflate v0.4.2 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking gif v0.10.0 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking x11-dl v2.17.5 [INFO] [stderr] Compiling syn v0.14.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.15.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.13.1 [INFO] [stderr] Checking gfx_device_gl v0.15.2 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_glutin v0.23.0 [INFO] [stderr] Checking pixel-shadow-experiment v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:33 [INFO] [stderr] | [INFO] [stderr] 135 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:54 [INFO] [stderr] | [INFO] [stderr] 135 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:162:41 [INFO] [stderr] | [INFO] [stderr] 162 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 163 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 164 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 165 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 181 | | _ => (), [INFO] [stderr] 182 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 162 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 163 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 164 | running = false; [INFO] [stderr] 165 | } [INFO] [stderr] 166 | glutin::WindowEvent::CursorMoved { [INFO] [stderr] 167 | position: (x, y), .. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:169:40 [INFO] [stderr] | [INFO] [stderr] 169 | } => if x >= 0. && x < image_width as f64 && y >= 0. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(image_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:170:28 [INFO] [stderr] | [INFO] [stderr] 170 | && y < image_height as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(image_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:33 [INFO] [stderr] | [INFO] [stderr] 135 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:54 [INFO] [stderr] | [INFO] [stderr] 135 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:162:41 [INFO] [stderr] | [INFO] [stderr] 162 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 163 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 164 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 165 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 181 | | _ => (), [INFO] [stderr] 182 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 162 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 163 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 164 | running = false; [INFO] [stderr] 165 | } [INFO] [stderr] 166 | glutin::WindowEvent::CursorMoved { [INFO] [stderr] 167 | position: (x, y), .. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:169:40 [INFO] [stderr] | [INFO] [stderr] 169 | } => if x >= 0. && x < image_width as f64 && y >= 0. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(image_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:170:28 [INFO] [stderr] | [INFO] [stderr] 170 | && y < image_height as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(image_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 27s [INFO] running `"docker" "inspect" "476d3eaa2077fd92611ece7b100e1a270edbc0156b79c627f4eb197546d51345"` [INFO] running `"docker" "rm" "-f" "476d3eaa2077fd92611ece7b100e1a270edbc0156b79c627f4eb197546d51345"` [INFO] [stdout] 476d3eaa2077fd92611ece7b100e1a270edbc0156b79c627f4eb197546d51345