[INFO] updating cached repository stevebob/life-gl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stevebob/life-gl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/life-gl" "work/ex/clippy-test-run/sources/stable/gh/stevebob/life-gl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevebob/life-gl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/life-gl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/life-gl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/life-gl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 710d1c512a1b59eeadd7b16d9e8a068c7400a11d [INFO] sha for GitHub repo stevebob/life-gl: 710d1c512a1b59eeadd7b16d9e8a068c7400a11d [INFO] validating manifest of stevebob/life-gl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stevebob/life-gl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stevebob/life-gl [INFO] finished frobbing stevebob/life-gl [INFO] frobbed toml for stevebob/life-gl written to work/ex/clippy-test-run/sources/stable/gh/stevebob/life-gl/Cargo.toml [INFO] started frobbing stevebob/life-gl [INFO] finished frobbing stevebob/life-gl [INFO] frobbed toml for stevebob/life-gl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/life-gl/Cargo.toml [INFO] crate stevebob/life-gl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stevebob/life-gl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stevebob/life-gl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 94df27786b3fc7830a3d75223b2ebab93ad18589d5c22f9e1017b260adceea15 [INFO] running `"docker" "start" "-a" "94df27786b3fc7830a3d75223b2ebab93ad18589d5c22f9e1017b260adceea15"` [INFO] [stderr] Compiling cc v1.0.24 [INFO] [stderr] Compiling log v0.4.5 [INFO] [stderr] Checking memchr v2.0.2 [INFO] [stderr] Checking simon v0.1.0 [INFO] [stderr] Checking parking_lot_core v0.3.0 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.18.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Checking wayland-client v0.20.12 [INFO] [stderr] Checking wayland-protocols v0.20.12 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_glutin v0.26.0 [INFO] [stderr] Checking life-gl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | out_colour: out_colour, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_colour` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | out_colour: out_colour, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | out_colour: out_colour, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | out_colour: out_colour, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_colour` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | out_colour: out_colour, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | out_colour: out_colour, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_colour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/colour.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | named!(hex_primary<&str, u8>, map_res!(take_while_m_n!(2, 2, is_hex_digit), from_hex)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colour.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | ([red as f32 / 255., green as f32 / 255., blue as f32 / 255., 1.]) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colour.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | ([red as f32 / 255., green as f32 / 255., blue as f32 / 255., 1.]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colour.rs:20:47 [INFO] [stderr] | [INFO] [stderr] 20 | ([red as f32 / 255., green as f32 / 255., blue as f32 / 255., 1.]) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/colour.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | named!(hex_primary<&str, u8>, map_res!(take_while_m_n!(2, 2, is_hex_digit), from_hex)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colour.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | ([red as f32 / 255., green as f32 / 255., blue as f32 / 255., 1.]) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colour.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | ([red as f32 / 255., green as f32 / 255., blue as f32 / 255., 1.]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colour.rs:20:47 [INFO] [stderr] | [INFO] [stderr] 20 | ([red as f32 / 255., green as f32 / 255., blue as f32 / 255., 1.]) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:352:41 [INFO] [stderr] | [INFO] [stderr] 352 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 353 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 354 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 355 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 383 | | _ => (), [INFO] [stderr] 384 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 352 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 353 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 354 | running = false; [INFO] [stderr] 355 | } [INFO] [stderr] 356 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 357 | if let Some(virtual_keycode) = input.virtual_keycode { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:359:25 [INFO] [stderr] | [INFO] [stderr] 359 | / match input.state { [INFO] [stderr] 360 | | glutin::ElementState::Pressed => match virtual_keycode { [INFO] [stderr] 361 | | glutin::VirtualKeyCode::Space => { [INFO] [stderr] 362 | | renderer.init(&mut encoder, &mut rng, colours, game_params); [INFO] [stderr] ... | [INFO] [stderr] 366 | | _ => (), [INFO] [stderr] 367 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 359 | if let glutin::ElementState::Pressed = input.state { match virtual_keycode { [INFO] [stderr] 360 | glutin::VirtualKeyCode::Space => { [INFO] [stderr] 361 | renderer.init(&mut encoder, &mut rng, colours, game_params); [INFO] [stderr] 362 | } [INFO] [stderr] 363 | _ => (), [INFO] [stderr] 364 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:360:62 [INFO] [stderr] | [INFO] [stderr] 360 | glutin::ElementState::Pressed => match virtual_keycode { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 361 | | glutin::VirtualKeyCode::Space => { [INFO] [stderr] 362 | | renderer.init(&mut encoder, &mut rng, colours, game_params); [INFO] [stderr] 363 | | } [INFO] [stderr] 364 | | _ => (), [INFO] [stderr] 365 | | }, [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 360 | glutin::ElementState::Pressed => if let glutin::VirtualKeyCode::Space = virtual_keycode { [INFO] [stderr] 361 | renderer.init(&mut encoder, &mut rng, colours, game_params); [INFO] [stderr] 362 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/main.rs:532:38 [INFO] [stderr] | [INFO] [stderr] 532 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 532 | for (i, ) in buf.iter_mut().enumerate().take(8) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:352:41 [INFO] [stderr] | [INFO] [stderr] 352 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 353 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 354 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 355 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 383 | | _ => (), [INFO] [stderr] 384 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 352 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 353 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 354 | running = false; [INFO] [stderr] 355 | } [INFO] [stderr] 356 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 357 | if let Some(virtual_keycode) = input.virtual_keycode { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:359:25 [INFO] [stderr] | [INFO] [stderr] 359 | / match input.state { [INFO] [stderr] 360 | | glutin::ElementState::Pressed => match virtual_keycode { [INFO] [stderr] 361 | | glutin::VirtualKeyCode::Space => { [INFO] [stderr] 362 | | renderer.init(&mut encoder, &mut rng, colours, game_params); [INFO] [stderr] ... | [INFO] [stderr] 366 | | _ => (), [INFO] [stderr] 367 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 359 | if let glutin::ElementState::Pressed = input.state { match virtual_keycode { [INFO] [stderr] 360 | glutin::VirtualKeyCode::Space => { [INFO] [stderr] 361 | renderer.init(&mut encoder, &mut rng, colours, game_params); [INFO] [stderr] 362 | } [INFO] [stderr] 363 | _ => (), [INFO] [stderr] 364 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:360:62 [INFO] [stderr] | [INFO] [stderr] 360 | glutin::ElementState::Pressed => match virtual_keycode { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 361 | | glutin::VirtualKeyCode::Space => { [INFO] [stderr] 362 | | renderer.init(&mut encoder, &mut rng, colours, game_params); [INFO] [stderr] 363 | | } [INFO] [stderr] 364 | | _ => (), [INFO] [stderr] 365 | | }, [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 360 | glutin::ElementState::Pressed => if let glutin::VirtualKeyCode::Space = virtual_keycode { [INFO] [stderr] 361 | renderer.init(&mut encoder, &mut rng, colours, game_params); [INFO] [stderr] 362 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/main.rs:532:38 [INFO] [stderr] | [INFO] [stderr] 532 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 532 | for (i, ) in buf.iter_mut().enumerate().take(8) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 09s [INFO] running `"docker" "inspect" "94df27786b3fc7830a3d75223b2ebab93ad18589d5c22f9e1017b260adceea15"` [INFO] running `"docker" "rm" "-f" "94df27786b3fc7830a3d75223b2ebab93ad18589d5c22f9e1017b260adceea15"` [INFO] [stdout] 94df27786b3fc7830a3d75223b2ebab93ad18589d5c22f9e1017b260adceea15