[INFO] updating cached repository stevebob/hello-cpal [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stevebob/hello-cpal [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/hello-cpal" "work/ex/clippy-test-run/sources/stable/gh/stevebob/hello-cpal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevebob/hello-cpal'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/hello-cpal" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/hello-cpal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/hello-cpal'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d7025a8778223566609c5e49021ec68c2d8b8a7e [INFO] sha for GitHub repo stevebob/hello-cpal: d7025a8778223566609c5e49021ec68c2d8b8a7e [INFO] validating manifest of stevebob/hello-cpal on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stevebob/hello-cpal on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stevebob/hello-cpal [INFO] finished frobbing stevebob/hello-cpal [INFO] frobbed toml for stevebob/hello-cpal written to work/ex/clippy-test-run/sources/stable/gh/stevebob/hello-cpal/Cargo.toml [INFO] started frobbing stevebob/hello-cpal [INFO] finished frobbing stevebob/hello-cpal [INFO] frobbed toml for stevebob/hello-cpal written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/hello-cpal/Cargo.toml [INFO] crate stevebob/hello-cpal has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stevebob/hello-cpal against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stevebob/hello-cpal:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8ad13ba6b71930305f8466a9d4862104ccfe5c97f2958c6506e1eb99665538d8 [INFO] running `"docker" "start" "-a" "8ad13ba6b71930305f8466a9d4862104ccfe5c97f2958c6506e1eb99665538d8"` [INFO] [stderr] Checking getopts v0.2.18 [INFO] [stderr] Checking alsa-sys v0.1.2 [INFO] [stderr] Checking cpal v0.8.2 [INFO] [stderr] Checking simon v0.1.0 [INFO] [stderr] Checking hello-cpal v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:22:68 [INFO] [stderr] | [INFO] [stderr] 22 | let index_multiplier = freq_hz * ::std::f64::consts::PI * 2. / (samples_per_second as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(samples_per_second)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:24:59 [INFO] [stderr] | [INFO] [stderr] 24 | ((sample_index as f64 * index_multiplier).sin() * (::std::i16::MAX as f64)) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(::std::i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:28:51 [INFO] [stderr] | [INFO] [stderr] 28 | event_loop.run(move |_stream_id, stream_data| match stream_data { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 29 | | cpal::StreamData::Output { [INFO] [stderr] 30 | | buffer: cpal::UnknownTypeOutputBuffer::I16(mut buffer), [INFO] [stderr] 31 | | } => for elem in buffer.iter_mut() { [INFO] [stderr] ... | [INFO] [stderr] 35 | | _ => (), [INFO] [stderr] 36 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | event_loop.run(move |_stream_id, stream_data| if let cpal::StreamData::Output { [INFO] [stderr] 29 | buffer: cpal::UnknownTypeOutputBuffer::I16(mut buffer), [INFO] [stderr] 30 | } = stream_data for elem in buffer.iter_mut() { [INFO] [stderr] 31 | *elem = sample_index_to_sample(sample_index); [INFO] [stderr] 32 | sample_index += 1; [INFO] [stderr] 33 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:22:68 [INFO] [stderr] | [INFO] [stderr] 22 | let index_multiplier = freq_hz * ::std::f64::consts::PI * 2. / (samples_per_second as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(samples_per_second)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:24:59 [INFO] [stderr] | [INFO] [stderr] 24 | ((sample_index as f64 * index_multiplier).sin() * (::std::i16::MAX as f64)) as i16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(::std::i16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:28:51 [INFO] [stderr] | [INFO] [stderr] 28 | event_loop.run(move |_stream_id, stream_data| match stream_data { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 29 | | cpal::StreamData::Output { [INFO] [stderr] 30 | | buffer: cpal::UnknownTypeOutputBuffer::I16(mut buffer), [INFO] [stderr] 31 | | } => for elem in buffer.iter_mut() { [INFO] [stderr] ... | [INFO] [stderr] 35 | | _ => (), [INFO] [stderr] 36 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | event_loop.run(move |_stream_id, stream_data| if let cpal::StreamData::Output { [INFO] [stderr] 29 | buffer: cpal::UnknownTypeOutputBuffer::I16(mut buffer), [INFO] [stderr] 30 | } = stream_data for elem in buffer.iter_mut() { [INFO] [stderr] 31 | *elem = sample_index_to_sample(sample_index); [INFO] [stderr] 32 | sample_index += 1; [INFO] [stderr] 33 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.52s [INFO] running `"docker" "inspect" "8ad13ba6b71930305f8466a9d4862104ccfe5c97f2958c6506e1eb99665538d8"` [INFO] running `"docker" "rm" "-f" "8ad13ba6b71930305f8466a9d4862104ccfe5c97f2958c6506e1eb99665538d8"` [INFO] [stdout] 8ad13ba6b71930305f8466a9d4862104ccfe5c97f2958c6506e1eb99665538d8