[INFO] updating cached repository stevebob/hello-3d [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stevebob/hello-3d [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/hello-3d" "work/ex/clippy-test-run/sources/stable/gh/stevebob/hello-3d"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevebob/hello-3d'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/hello-3d" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/hello-3d"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/hello-3d'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1c3b00a960892d177675a3ff1e8e0fe818ee62d3 [INFO] sha for GitHub repo stevebob/hello-3d: 1c3b00a960892d177675a3ff1e8e0fe818ee62d3 [INFO] validating manifest of stevebob/hello-3d on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stevebob/hello-3d on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stevebob/hello-3d [INFO] finished frobbing stevebob/hello-3d [INFO] frobbed toml for stevebob/hello-3d written to work/ex/clippy-test-run/sources/stable/gh/stevebob/hello-3d/Cargo.toml [INFO] started frobbing stevebob/hello-3d [INFO] finished frobbing stevebob/hello-3d [INFO] frobbed toml for stevebob/hello-3d written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/hello-3d/Cargo.toml [INFO] crate stevebob/hello-3d has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stevebob/hello-3d against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stevebob/hello-3d:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1c1ceccc231a1e9048f91621d17b697a747f7fc78aea5706fb34651e9e36249e [INFO] running `"docker" "start" "-a" "1c1ceccc231a1e9048f91621d17b697a747f7fc78aea5706fb34651e9e36249e"` [INFO] [stderr] Compiling log v0.4.5 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Compiling wayland-scanner v0.20.12 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking x11-dl v2.18.3 [INFO] [stderr] Compiling syn v0.15.13 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Compiling wayland-client v0.20.12 [INFO] [stderr] Compiling wayland-protocols v0.20.12 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.18.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling derivative v1.0.1 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_glutin v0.26.0 [INFO] [stderr] Checking hello-3d v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/main.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | offsets: QUAD_INDICES.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:284:41 [INFO] [stderr] | [INFO] [stderr] 284 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 285 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 286 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 287 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 341 | | _ => (), [INFO] [stderr] 342 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 284 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 285 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 286 | running = false; [INFO] [stderr] 287 | } [INFO] [stderr] 288 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 289 | if let Some(virtual_keycode) = input.virtual_keycode { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/main.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | offsets: QUAD_INDICES.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:284:41 [INFO] [stderr] | [INFO] [stderr] 284 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 285 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 286 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 287 | | running = false; [INFO] [stderr] ... | [INFO] [stderr] 341 | | _ => (), [INFO] [stderr] 342 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 284 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 285 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 286 | running = false; [INFO] [stderr] 287 | } [INFO] [stderr] 288 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 289 | if let Some(virtual_keycode) = input.virtual_keycode { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 30s [INFO] running `"docker" "inspect" "1c1ceccc231a1e9048f91621d17b697a747f7fc78aea5706fb34651e9e36249e"` [INFO] running `"docker" "rm" "-f" "1c1ceccc231a1e9048f91621d17b697a747f7fc78aea5706fb34651e9e36249e"` [INFO] [stdout] 1c1ceccc231a1e9048f91621d17b697a747f7fc78aea5706fb34651e9e36249e